Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Improving code
Top Forums Shell Programming and Scripting Improving code Post 302991069 by Corona688 on Monday 6th of February 2017 11:04:03 AM
Old 02-06-2017
I'll cut to the chase and be a bit more generous -- you are reprocessing your input files over, and over, and over, and over, and over, and over, and over, when you could have done so just once or twice.

Your code is too big a mess to replace wholesale, especially since we know nothing about your input, but 'filter by conditions' is particularly egregious. You are allowed to put more than one statement in an awk program! You could have done 5 times as much work at once. Here is pseudocode.

Code:
read vpff vpds4a vpds4b vpds4 vpdsss <<EOF
$( awk '
        awk-range1 { count1++ }
        awk-range2 { count2++ }
        awk-range3 { count3++ }
        awk-range4 { count4++ }
        awk-range5 { count5++ }
        END { print count1+0, count2+0, count3+0, count4+0, count5+0; }' tmp4 )
EOF

The idea is to have awk print a line like "5 7 3 9 12" which gets dumped into read and split among its variables.
This User Gave Thanks to Corona688 For This Post:
jiam912
 

6 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

improving my script

Hi; I want to access our customer database to retreive all clients that have as language index 2 or 3 and take their client number. My input is a file containing all client numbers. i access the data base using a function call "scpshow". The total number of clients i want to scan is 400 000... (6 Replies)
Discussion started by: bcheaib
6 Replies

2. UNIX for Dummies Questions & Answers

Improving Unix Skills

Kindly any advice to improve my unix skills as electronic books i can download or valuable sites as this one etc... (3 Replies)
Discussion started by: sak900354
3 Replies

3. Shell Programming and Scripting

Improving this validate function

Hi guys, I use this function which was provided to me by someone at this site. It works perfectly for validating a users input option against allowed options.. example: validateInput "1" "1 3 4 5" would return 0 (success) function validateInput { input=$1 allowedInput=$2 for... (4 Replies)
Discussion started by: pyscho
4 Replies

4. Shell Programming and Scripting

Improving code by using associative arrays

I have the following code, and I am changing it to #!/bin/bash hasArgumentCModInfile=0 hasArgumentSrcsInfile=0 hasArgumentRcvsInfile=0 OLDIFS="$IFS" IFS="|=" # IFS controls splitting. Split on "|" and "=", not whitespace. set -- $* # Set the positional... (3 Replies)
Discussion started by: kristinu
3 Replies

5. Shell Programming and Scripting

Basic help improving for in loop

I'm obviously very new to this. I'm trying to write a simple for loop that will read the directory names in /Users and then copy a file into the same subdir in each user directory. I have this, and it works but it isn't great. #!/bin/bash HOMEDIRS=/Users/* for dirs in $HOMEDIRS; do if ];... (5 Replies)
Discussion started by: Heath_T
5 Replies

6. Shell Programming and Scripting

Need help improving my script.

Thank you for taking the time to look at this and provide input. To start, I am not a linux/unix expert but I muddle through the best I can. I am also in no way shape or form a programmer. Please keep that in mind as you read this script. This script is designed to find all files in a given... (8 Replies)
Discussion started by: garlandxj11
8 Replies

LEARN ABOUT MOJAVE

osacompile

OSACOMPILE(1)						    BSD General Commands Manual 					     OSACOMPILE(1)

NAME

     osacompile -- compile AppleScripts and other OSA language scripts

SYNOPSIS

     osacompile [-l language] [-e command] [-o name] [-d] [-r type:id] [-t type] [-c creator] [-x] [-s] [-u] [-a arch] [file ...]

DESCRIPTION

     osacompile compiles the given files, or standard input if none are listed, into a single output script.  Files may be plain text or other
     compiled scripts.	The options are as follows:

     -l language
	   Override the language for any plain text files.  Normally, plain text files are compiled as AppleScript.

     -e command
	   Enter one line of a script.	Script commands given via -e are prepended to the normal source, if any.  Multiple -e options may be given
	   to build up a multi-line script.  Because most scripts use characters that are special to many shell programs (e.g., AppleScript uses
	   single and double quote marks, ``('', ``)'', and ``*''), the command will have to be correctly quoted and escaped to get it past the
	   shell intact.

     -o name
	   Place the output in the file name.  If -o is not specified, the resulting script is placed in the file ``a.scpt''.  The value of -o
	   partly determines the output file format; see below.

     -x    Save the resulting script as execute-only.

     The following options are only relevant when creating a new bundled applet or droplet:

     -s    Stay-open applet.

     -u    Use startup screen.

     -a arch
	   Create the applet or droplet for the specified target architecture arch.  The allowable values are ``ppc'', ``i386'', and ``x86_64''.
	   The default is to create a universal binary.

     The following options control the packaging of the output file.  You should only need them for compatibility with classic Mac OS or for cus-
     tom file formats.

     -d    Place the resulting script in the data fork of the output file.  This is the default.

     -r type:id
	   Place the resulting script in the resource fork of the output file, in the specified resource.

     -t type
	   Set the output file type to type, where type is a four-character code.  If this option is not specified, the creator code will not be
	   set.

     -c creator
	   Set the output file creator to creator, where creator is a four-character code.  If this option is not specified, the creator code will
	   not be set.

     If no options are specified, osacompile produces a Mac OS X format script file: data fork only, with no type or creator code.

     If the -o option is specified and the file does not already exist, osacompile uses the filename extension to determine what type of file to
     create.  If the filename ends with ``.app'', it creates a bundled applet or droplet.  If the filename ends with ``.scptd'', it creates a bun-
     dled compiled script.  Otherwise, it creates a flat file with the script data placed according to the values of the -d and -r options.

EXAMPLES

     To produce a script compatible with classic Mac OS:

	   osacompile -r scpt:128 -t osas -c ToyS example.applescript

SEE ALSO

     osascript(1), osalang(1)

Mac OS X							 November 12, 2008							  Mac OS X
All times are GMT -4. The time now is 07:57 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy