Improving code Post: 302991069

Sponsored Content

Top Forums Shell Programming and Scripting Improving code Post 302991069 by Corona688 on Monday 6th of February 2017 11:04:03 AM

02-06-2017

Registered User

I'll cut to the chase and be a bit more generous -- you are reprocessing your input files over, and over, and over, and over, and over, and over, and over, when you could have done so just once or twice.

Your code is too big a mess to replace wholesale, especially since we know nothing about your input, but 'filter by conditions' is particularly egregious. You are allowed to put more than one statement in an awk program! You could have done 5 times as much work at once. Here is pseudocode.

Code:

read vpff vpds4a vpds4b vpds4 vpdsss <<EOF
$( awk '
        awk-range1 { count1++ }
        awk-range2 { count2++ }
        awk-range3 { count3++ }
        awk-range4 { count4++ }
        awk-range5 { count5++ }
        END { print count1+0, count2+0, count3+0, count4+0, count5+0; }' tmp4 )
EOF

The idea is to have awk print a line like "5 7 3 9 12" which gets dumped into read and split among its variables.

This User Gave Thanks to Corona688 For This Post:

Corona688

View Public Profile for Corona688

Visit Corona688's homepage!

Find all posts by Corona688

6 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

improving my script

Hi; I want to access our customer database to retreive all clients that have as language index 2 or 3 and take their client number. My input is a file containing all client numbers. i access the data base using a function call "scpshow". The total number of clients i want to scan is 400 000...

2. UNIX for Dummies Questions & Answers

Improving Unix Skills

Kindly any advice to improve my unix skills as electronic books i can download or valuable sites as this one etc...

3. Shell Programming and Scripting

Improving this validate function

Hi guys, I use this function which was provided to me by someone at this site. It works perfectly for validating a users input option against allowed options.. example: validateInput "1" "1 3 4 5" would return 0 (success) function validateInput { input=$1 allowedInput=$2 for...

4. Shell Programming and Scripting

Improving code by using associative arrays

I have the following code, and I am changing it to #!/bin/bash hasArgumentCModInfile=0 hasArgumentSrcsInfile=0 hasArgumentRcvsInfile=0 OLDIFS="$IFS" IFS="|=" # IFS controls splitting. Split on "|" and "=", not whitespace. set -- $* # Set the positional...

5. Shell Programming and Scripting

Basic help improving for in loop

I'm obviously very new to this. I'm trying to write a simple for loop that will read the directory names in /Users and then copy a file into the same subdir in each user directory. I have this, and it works but it isn't great. #!/bin/bash HOMEDIRS=/Users/* for dirs in $HOMEDIRS; do if ];...

6. Shell Programming and Scripting

Need help improving my script.

Thank you for taking the time to look at this and provide input. To start, I am not a linux/unix expert but I muddle through the best I can. I am also in no way shape or form a programmer. Please keep that in mind as you read this script. This script is designed to find all files in a given...

LEARN ABOUT PHP

php_strip_whitespace

PHP_STRIP_WHITESPACE(3) 						 1						   PHP_STRIP_WHITESPACE(3)

php_strip_whitespace - Return source with stripped comments and whitespace

SYNOPSIS

       string php_strip_whitespace (string  $filename)

DESCRIPTION

	Returns the PHP source code in $filename with PHP comments and whitespace removed. This may be useful for determining the amount of actual
       code in your scripts compared with the amount of comments. This is similar to using php -w from the commandline.

PARAMETERS

	      o $filename
		- Path to the PHP file.

RETURN VALUES

	The stripped source code will be returned on success, or an empty string on failure.

       Note

	       This function works as described as of PHP 5.0.1. Before this it would only return an empty string. For more  information  on  this
	      bug and its prior behavior, see bug report #29606.

EXAMPLES

       Example #1

	      php_strip_whitespace(3) example

	      <?php
	      // PHP comment here

	      /*
	       * Another PHP comment
	       */

	      echo	  php_strip_whitespace(__FILE__);
	      // Newlines are considered whitespace, and are removed too:
	      do_nothing();
	      ?>

	      The above example will output:

	      <?php
	       echo php_strip_whitespace(__FILE__); do_nothing(); ?>

	       Notice the PHP comments are gone, as are the whitespace and newline after the first echo statement.

PHP Documentation Group 												   PHP_STRIP_WHITESPACE(3)