Sponsored Content
Full Discussion: Improving code
Top Forums Shell Programming and Scripting Improving code Post 302991069 by Corona688 on Monday 6th of February 2017 11:04:03 AM
Old 02-06-2017
I'll cut to the chase and be a bit more generous -- you are reprocessing your input files over, and over, and over, and over, and over, and over, and over, when you could have done so just once or twice.

Your code is too big a mess to replace wholesale, especially since we know nothing about your input, but 'filter by conditions' is particularly egregious. You are allowed to put more than one statement in an awk program! You could have done 5 times as much work at once. Here is pseudocode.

Code:
read vpff vpds4a vpds4b vpds4 vpdsss <<EOF
$( awk '
        awk-range1 { count1++ }
        awk-range2 { count2++ }
        awk-range3 { count3++ }
        awk-range4 { count4++ }
        awk-range5 { count5++ }
        END { print count1+0, count2+0, count3+0, count4+0, count5+0; }' tmp4 )
EOF

The idea is to have awk print a line like "5 7 3 9 12" which gets dumped into read and split among its variables.
This User Gave Thanks to Corona688 For This Post:
 

6 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

improving my script

Hi; I want to access our customer database to retreive all clients that have as language index 2 or 3 and take their client number. My input is a file containing all client numbers. i access the data base using a function call "scpshow". The total number of clients i want to scan is 400 000... (6 Replies)
Discussion started by: bcheaib
6 Replies

2. UNIX for Dummies Questions & Answers

Improving Unix Skills

Kindly any advice to improve my unix skills as electronic books i can download or valuable sites as this one etc... (3 Replies)
Discussion started by: sak900354
3 Replies

3. Shell Programming and Scripting

Improving this validate function

Hi guys, I use this function which was provided to me by someone at this site. It works perfectly for validating a users input option against allowed options.. example: validateInput "1" "1 3 4 5" would return 0 (success) function validateInput { input=$1 allowedInput=$2 for... (4 Replies)
Discussion started by: pyscho
4 Replies

4. Shell Programming and Scripting

Improving code by using associative arrays

I have the following code, and I am changing it to #!/bin/bash hasArgumentCModInfile=0 hasArgumentSrcsInfile=0 hasArgumentRcvsInfile=0 OLDIFS="$IFS" IFS="|=" # IFS controls splitting. Split on "|" and "=", not whitespace. set -- $* # Set the positional... (3 Replies)
Discussion started by: kristinu
3 Replies

5. Shell Programming and Scripting

Basic help improving for in loop

I'm obviously very new to this. I'm trying to write a simple for loop that will read the directory names in /Users and then copy a file into the same subdir in each user directory. I have this, and it works but it isn't great. #!/bin/bash HOMEDIRS=/Users/* for dirs in $HOMEDIRS; do if ];... (5 Replies)
Discussion started by: Heath_T
5 Replies

6. Shell Programming and Scripting

Need help improving my script.

Thank you for taking the time to look at this and provide input. To start, I am not a linux/unix expert but I muddle through the best I can. I am also in no way shape or form a programmer. Please keep that in mind as you read this script. This script is designed to find all files in a given... (8 Replies)
Discussion started by: garlandxj11
8 Replies
UPDATE-XFONTS-TRADITIONAL(8)					 chiark utilities				      UPDATE-XFONTS-TRADITIONAL(8)

NAME
update-xfonts-traditional - generate traditional ASCII fixed-with fonts SYNOPSIS
update-xfonts-traditional --bdf-filter update-xfonts-traditional --process-pcf in.pcf.gz out.pcf.gz update-xfonts-traditional --process-fontdirs fontdir ... update-xfonts-traditional --process-fonttrees fonttree ... DESCRIPTION
update-xfonts-traditional generates versions of X11 PCF fonts which have been edited to restore compatibility with traditional versions of US-ASCII, and to restore some of the glyphs to more traditional appearance. MODES
--bdf-filter Takes a BDF on standard input and tries to generate an edited BDF on standard output. --process-pcf Takes to PCF filename arguments; the input PCF is uncompressed, decompiled to a BDF, processed, recompiled to a PCF and recom- pressed. --process-fontdirs In each fontdir all files font.pcf.gz are processed, to generate where applicable corresponding trad--font.pcf.gz files. The mtime, ctime and inode number of the input files are recorded so that reprocessing the same directory later will be fast. --process-fonttrees Each fonttree is searched for font directories which are processed as above. --update Each built in font tree location is searched for font directories which are processed as above. OPTIONS
-R|--rules-path rulespath Prepend rulespath to the path of directories from which to load glyph editing rules. --share-dir share-dir Use share-dir instead of /usr[/local]/share/xfonts-traditional. --parallel|-j cpus Use up to cpus cores for processing fonts. The default is all the cpus available. --always-reprocess When scanning font directories, always reprocess all the fonts, regardless of whether we think they have been done already. --no-tolerate-bad-fonts Treat bad input fonts (eg, ones for which pcf2bdf crashes, or ones with other problems) as a fatal error. Normally they just pro- duce a warning. FILES
xfonts-traditional.done In each font directory, records information about processed fonts, so as to optimise away unnecessary reprocessing. xfonts-traditional.log In each font directory, records a lot of which fonts were processed and to a certain extent if not why not. /usr/share/fonts/X11 /usr/local/share/fonts/X11 Default font tree paths for --update. trad--font.pcf.gz In any font directory, our output files. Any other files matching this pattern may be overwritten or deleted. EXIT STATUS
0 All went well and there were no warnings. 2 With --bdf-filter and --process-pcf only, indicates that the input font did not need to be edited, or was not suitable for editing, and has not been written out, so the output is incomplete, but this is not an error. any other There were problems. BUGS
Only the 6x13 font conventionally called supported. This package comes too late to rescue Unix from an incompatible change to its charac- ter set. Greenend 2012 UPDATE-XFONTS-TRADITIONAL(8)
All times are GMT -4. The time now is 05:28 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy