02-02-2017
You don't need the local variable a,b,c, because all java functions pass primitive types by value (making a local copy of them). I would keep the same naming convention on setMaximum (calling the parameters a,b,c), because I see no reason to make it different from getMaximum and maximum. FInally I would get rid of maximum (not necessary), make setMaximum a void function (returns nothing) and decouple getMaximum from setMaximum (not calling setMaximum from inside it)and make it return maxVal instead of SetMaximum.
Edit. Another possible better solution would be to create a third function called calculateMaximum or something like that and put in it all the logic that it is currently in setMaximum. After it determines the greatest value it could call directly setMaximum that would have as it's only parameter the biggest value. In that case calculateMaximum would be void.
Or you can make it return the biggest value (in this case it won't be a void function), throw it in some variable and pass the variable as the argument for setMaximum, or be more direct and use determineMaximum as the argument of setMaximum, as it will return the maximum value that will be passed to setMaximum
Last edited by colt; 02-02-2017 at 07:12 PM..
9 More Discussions You Might Find Interesting
1. Shell Programming and Scripting
Hello everybody,
I have a problem about running a java class with a cron :
I have Cron.txt file which has :
0,5,10,15,20,25,30,35,40,45,50,55 * * * * CronJava.txt
I have CronJava.txt wihich has :
cd ias/j2ee/SapAktarim/applications/SapAktarim/SapAktarim/WEB-INF/classes/;java -classpath... (3 Replies)
Discussion started by: UBGandalf
3 Replies
2. Shell Programming and Scripting
Like class loader in java, can we make a function loader in shell script, for this can someone throw some light on how internally bash runs a shell script , what happenes in runtime ...
thanks in advance.. (1 Reply)
Discussion started by: mpsc_sela
1 Replies
3. Shell Programming and Scripting
Hi,
Is it possible to call the constructur of a java class in a shell script?
I know you can call static methods, but can you also call the constructor?
tnx. (1 Reply)
Discussion started by: thebladerunner
1 Replies
4. Fedora
Hi, everyone:
I'm trying to connect to DB using JDBC on fedora. I have successfully installed jdk and it's ok to run common java program.
The environment variables:
JAVA_HOME=/installed/mycoy/jdk1.6.0
PATH=$JAVA_HOME/bin:$PATH... (3 Replies)
Discussion started by: mycoy
3 Replies
5. Programming
hello all,
i want to know if there is any difference in working and syntax declaration of abstract class in Java and C++. (1 Reply)
Discussion started by: haravivar
1 Replies
6. Programming
Is anyone know how to write a class in separate file? While method does it needs to be contained in a printwriter class? Can I have the format of the printwriter class as a reference? Thanks a lot. (1 Reply)
Discussion started by: eel
1 Replies
7. Programming
Hi, I need help to Link array from one class to another class
Firstly CSVParser Class what it did is load csv file and store into array
Secondly WarehouseItem where each record is store
How can I get a list of array that I load to CSVParser Class and store them to WarehouseItem and... (0 Replies)
Discussion started by: guidely
0 Replies
8. Shell Programming and Scripting
Hi,
I would really appreciate some help, I couldn't nail my problem:
I would like to create some setter and getter functions to make my life easier.
my sample file contains:
keyword - some tabs - value - semicolon
number 12.1;
float .3;
double 12;
real 12.2324;
stuff .234;
decimal... (5 Replies)
Discussion started by: Toorop
5 Replies
9. Programming
I am looking at a website to learn Java and this is one of the exercises.
Write a program that will show different time and date information based on what number you send it. The codes are:
0 - number of milliseconds since January 1, 1970
1 - number of seconds since January 1, 1970
2 -... (6 Replies)
Discussion started by: totoro125
6 Replies