Bash script: problem with a function which use colors Post: 302989820

Sponsored Content

Top Forums Shell Programming and Scripting Bash script: problem with a function which use colors Post 302989820 by Corona688 on Wednesday 18th of January 2017 02:49:23 PM

01-18-2017

Registered User

I think that color_in_red=("${red}"$2"${none}") this is incorrect, putting it in ( ) like that will make it an array. You should just do color_in_red="${red}$2${none}"

Also, if you're using BASH, you can avoid a lot of those echo -e's by just storing the binary values in the first place.

Also, you don't have to re-open the same logfile every time to print one line, you can open the logfile once and write to it as many times as you want:

Also, if you print the color ones to stderr, they will go straight to console and won't muck up your pipes, etc.

Code:

#!/bin/bash

exec 5>>logfile


logthis() {
    green=$'\033[0;32m' # The variables will hold actual escape sequence, not backslash-zero-three-three
    red=$'\033[0;31m'
    none=$'\033[0m'

    printf "%s: %s\n" "$(date)" "$1" >&5 # Print to file opened above into FD 5
    printf "%s%s%s\n" "$green" "$1" "$none" >&2 # To stderr
}

Last edited by Corona688; 01-18-2017 at 03:58 PM..

This User Gave Thanks to Corona688 For This Post:

Corona688

View Public Profile for Corona688

Visit Corona688's homepage!

Find all posts by Corona688

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

colors in BASH, doubt with script

I was trying to see all combinations of foreground and background colors in BASH. This works fine for me, echo -e '\E[37;46m TEXT' but when I tried the below script, the variables i and j do not expand. #!/bin/sh for i in `seq 30 37` # foreground do for j in `seq 40...

2. UNIX for Dummies Questions & Answers

Easy About Bash Script function

Hi to all, first of all,i am working on MINIX 3 OS. I want to create a bash script file,which will create a list of files(not directories) that have been modified one specific day (i.e today) under my home directory. thank you very much!! :)

3. Shell Programming and Scripting

Run function from script over ssh (BASH)

Hi, Is there any cleaver way to run function from the bash scrip over ssh? For example: #!/bin/bash #Function 1 FN1 () { ls -l } #Main run ssh user@host FN1 exit 0 Yeah, I know it will not work, but I'm asking how to make it to work :) I'm suspecting that it would be...

4. UNIX for Advanced & Expert Users

AWK sub function curious problem under bash

I need to detect the number of pages in a print job when it is available so I can warn users when they try to print a report much larger than they expected. Sometimes they are trying to print 1000 page reports when they thought they were getting a 10 page report. Under linux I am scanning the...

5. Shell Programming and Scripting

error when call function in bash script

Dear all, Could you please advice as I when call function i found the following error " refills: command not found" note that refills is function name. following also the function and how i call it function refills { echo "formatting refills and telepin" >> $log awk -F,...

6. Shell Programming and Scripting

bash script function parameters

I have a question about bash script. Can I create a function there that accept parameters like functions in program language?

7. Shell Programming and Scripting

Help with grep and read function in a BASH Script

I'm putting together a script that will search my mail archives for emails that meet certain criteria and output the files to a text file. I can manually cat that text file and pipe it into sendmail and it will work (i.e. cat /pathtofile/foo.txt | sendmail -t me@company.com) My script sends...

8. Shell Programming and Scripting

Passing parameters to bash script function (or subroutine)

I've found a few posts regarding passing parameters to a function or subroutine, but for some reason when I try to run a command based on part with these parameters it's not working. If I have the function echo the parameters they show correctly so I believe they are being passed right but the...

9. Shell Programming and Scripting

Calling function from another bash script

I would like to call functions from another bash script. How can I do it? Some code More code

10. Shell Programming and Scripting

Bash function problem

I am trying to figure out why I am having a "problem" with some functions in a bash script I am running. The reason for air quoting is that the functions are working, they are just not displaying anything to screen when called from another function. Here's an example: function Create_Input {...

LEARN ABOUT V7

ppmdither

ppmdither(1)						      General Commands Manual						      ppmdither(1)

NAME

       ppmdither - ordered dither for color images

SYNOPSIS

       ppmdither [-dim power] [-red shades] [-green shades] [-blue shades] [ppmfile]

DESCRIPTION

       Reads  a  portable  pixmap as input, and applies dithering to it to reduce the number of colors used down to the specified number of shades
       for each primary.  The default number of shades is red=5, green=9, blue=5, for a total of 225 colors.  To convert the image to a binary rgb
       format suitable for color printers, use -red 2 -green 2 -blue 2.

OPTIONS

       -dim power    The  size of the dithering matrix.  The dithering matrix is a square whose dimension is a power of 2.  power is that power of
		     2.  The default is 4, for a 16 by 16 matrix.

       -red shades   The number of red shades to be used, including black; minimum of 2.

       -green shades The number of green shades to be used, including black; minimum of 2.

       -blue shades  The number of blue shades to be used, including black; minimum of 2.

SEE ALSO

       pnmdepth(1), ppmquant(1), ppm(5)

AUTHOR

       Copyright (C) 1991 by Christos Zoulas.

								   14 July 1991 						      ppmdither(1)

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

colors in BASH, doubt with script

Discussion started by: jaduks

2. UNIX for Dummies Questions & Answers

Easy About Bash Script function

Discussion started by: kostis1904

3. Shell Programming and Scripting

Run function from script over ssh (BASH)

Discussion started by: columb

4. UNIX for Advanced & Expert Users

AWK sub function curious problem under bash

Discussion started by: Max Rebo