Yes.

I will point out the most obvious ones, but i wouldn't bet on having found all of them. The script is in a state which begs a rewrite anyway.

Code:

#!/bin/bash

You mentioned using AIX. The system shell is ksh, not bash. Use it!

Code:

Now=date + %M/%D/%Y

I suppose you want to use the date command to fill a variable there. This will fill the variable "Now" with the string "date" instead and the rest of the line will produce a syntax error. You do it this way (i have corrected the date-command too):

Code:

Now=$(date +"%M/%D/%Y")

Code:

while [[ -z $groups || -z $date1 || -z $n|| -z $email ]]; do

This is not ouright wrong, just dangerous. Suppose the variable groups has no content: this would leave the following command to be executed:

Code:

while [[ -z || -z $date1 || -z $n|| -z $email ]]; do

similar, if groups contains a space char:

Code:

while [[ -z foo bar || -z $date1 || -z $n|| -z $email ]]; do

and this, subsequently, will lead to a syntax error. If you query variables and their contents do it this way (notice the quoting):

Code:

while [[ -z "$groups" || -z "$date1" || -z "$n" || -z "$email" ]]; do

or, even more preferably, because being POSIX-compliant:

Code:

while [ -z "$groups" || -z "$date1" || -z "$n" || -z "$email" ] ; do

This will also not work:

Code:

 dialog --separate-widget $\n 
       --clear \

Notice the "n" at the end of the first line. When you continue a line with a backslash, it needs to be the absolutely last character in this line, because in fact you are escaping the following newline character with it. If there is another character (common problem: a space) after it, the backslash will escape that instead of the newline.

Code:

DISKINFO=tail -$n "/var/LV/$disk_'date +%Y.%H.%d'.txt"

Same as above, if you want a variable filled from a commands output you need to do it like this:

Code:

DISKINFO=$(tail -$n "/var/LV/$disk_$(date +"%Y.%H.%d").txt")

Code:

regex=/^[0-1][0-9]/[0-3][0-9]/[0-9]\{4\}$/
if [[$regex =~ date -d "$date1"]]

This won't work at all. First, "date -d" is not available in AIX (and in no other POSIX-compliant UNIX, because "-d" is not part of the POSIX standard). Since i cannot figure out what you are trying to achieve no suggestion for an alternative here, but explain what it should do and we probably find a solution.

Code:

if ! grep -q '$group' $DISKINFO ; then

almost correct. The problem is that variables ("$group") will not be expanded inside single quotes, only double quotes. And "grep" only works on files or streams, not on fixed strings:

Code:

if ! echo "$DISKINFO" | grep -q "$group" ; then

Finally: capitalisation is not arbitrary in UNIX. If a keyword is "else", it is supposed to be "else", not "Else", "ELSE" or anything else either (sorry for the pun). Likewise with all the other keywords: do, done, if, while, then, ...

I hope this helps.

bakunin