so the ! means if its not equal to 0/doesnt succeed/fails in doing the tar command it will send a mail and remove the tar file?
Yes. Whenever the tar-command returns a non-zero value the part between "then" and "fi" (or, in case an else-branch is there, the "then and the "else") is executed. In your case, since there is a "mail"-command and an "rm"-command it will do exactly that.
Quote:
Originally Posted by robertkwild
sorry to bang on about this just learning so excuse me if i am annoying you guys
You are not annoying us because of your questions. What is really annoying is the way you constantly ignore what we say about indenting. Believe me, i have written several hundred thousands lines of code in my life (and Don, i believe, something in the same order of magnitude) and i can tell you that it is absolutely necessary! I wrote programs in Assembler, C, FORTRAN, Clipper, and some interpreted languages (mostly shells) and this was constant in all of them!
If you do not understand how to indent properly: say so. We will explain it to you. But to simply ignore our many suggestions, THAT is really annoying - because it creates a feeling that what we do is in vain.
Here is a simple procedure how to indent properly (in every language):
Indentation is for making stand out two sorts of statements: conditionally executed ones and loop contents. Here is how a loop should look like:
What you see instantly is: 1) where the loop starts and 2) where it ends and 3) what it consists of (the "loops body").
Here is a real-world example in shell:
Now, this is my style of doing it, Don Cragun does it a bit different (but equally correct - that is a matter of personal taste):
Now the conditionals: the same principle applies. Whatever is causing the condition (the "if"-part) is put into a line, then everything between that and the else-line is indented, the "else" itself is at the same level as the "if" and then everything else is indented again until the end of the "if":
Here is a real-world example, this time not in shell but in C:
Notice again how the important parts - which condition everything is based upon ("a < b"), which part is executed when and where each part begins and ends - stand out.
Most programming languages allow to "chain" if-statements. Altough it is not necessary i always align the various conditions horizontally so that they start at the same column. I find that easier to keep track of:
Finally there is another conditional in most programming languages: "case" (or, in C, "switch"). It allows for several branches depending on various values of a single variable or expression. The syntax differs from language to language, but the sctructure is always the same:
Here is the chained if-else-construct from above, this time with a "case":
Notice how the important parts spring right into your eyes: the beginning and end of the construct, the various possible values (1, 2, *) and what part of the code is to be executed if these were to be the case (again, with the beginning and the ending of each).
Finally: you define some "indenting step" for yourself. Pick anything you are comfortable with. I prefer 5 spaces because i like the clear picture it gives. On the other hand you start pretty soon to get far right if you have many indentation steps. Some prefer only 3 spaces, some even two. One can nest more levels with less indentation but at the same time different parts of the code are not separated as clearly as with more indentation. Find your own optimum but FIND one. Do NOT write code the way you do because you will hate yourself once you have to correct or change your own programs after a while.
I hope this helps.
bakunin
These 3 Users Gave Thanks to bakunin For This Post:
Hi.
I'm trying to copy multiple folders from the remote machine to the local machine. I wrote a batch file to run an ftp window.
The problem I am having is that the only command to copy files is mget *, and this copies only files, not folders.
For example, ftp ts555
cd ts555/test
' test... (5 Replies)
I have written a shell script to perform backups using tar, rsync and optionally utilise lvm snapshots. The script is not finished but is in a working state and comments/descriptions are poor.
I would greatly appreciate any criticism and suggestions of the script to help improve my own learning... (0 Replies)
I have in directory /media/AUDIO/WAVE many .mp3 files with names like:
my filename_01of02.mp3
my filename_02of02.mp3
Your File_01of06.mp3
Your File_02of06.mp3
etc....
In the same directory, /media/AUDIO/WAVE, I have many folders with names like
9780743579490
9780743579491
etc..
Inside... (7 Replies)
I have 1000's of directories which is named as numbers. Each directory contains multiple files. Each of these directories have a file named "att". I need to rename all the att files by adding the directory name followed by "_" then att for each of the directories.
Directories
120
att... (2 Replies)
Hi all,
I have a tar file and inside that tar file is a folder with additional tar.gz files. What I want to do is look inside the first tar file and then find the second tar file I'm looking for, look inside that tar.gz file to find a certain directory. I'm encountering issues by trying to... (1 Reply)
I would like to confirm my file.tar is been tar-ed correctly before I remove them. But I have very limited disc space to untar it.
Can I just do the listing instead of actual extract it? Can I say confirm folder integrity if the listing is sucessful without problem?
tar tvf file1.tar
... (1 Reply)
Hi All,
I have to requirement to write a shell script to move file from one folder (A) to another five folder (B,C,D,E,F) and destination folder should be blank. In not blank just skip.
This script will run as a scheduler every 2 minutes. It will check number of files in folder A and move 1 to... (9 Replies)
Good day, everyone!
I'm very new to bash scripting. Our teacher gave us a task to create a script that basically does the same job the 'du' command does, with the difference that 'du' command gives an output in the form of
<size> <folder name>and what we need is
<folder name> <size>As for... (1 Reply)
1. The problem statement, all variables and given/known data:
The task is to create a script that would reproduce the output of 'du' command, but in a different way: what 'du' does is:
<size> <folder name>and what is needed is
<folder name> <size>We need to show only 10 folders which are the... (3 Replies)
HI Guys,
I have some 8 files with different name and extensions. I need to check if they are present in a specific folder or not and also want that script to show me which all are not present. I can write if condition for each file but from a developer perspective , i feel that is not a good... (3 Replies)