Need help improving my script. Post: 302970872

Sponsored Content

Top Forums Shell Programming and Scripting Need help improving my script. Post 302970872 by Scrutinizer on Tuesday 12th of April 2016 10:48:15 PM

04-12-2016

Moderator

I would suggest to also use some of you vertical real estate, since that will greatly improve readability for future maintenance..

I expect Don's suggestion of using the + instead of \; will significantly increase processing speed.

An untested example of what a single awk might look like:

Code:

find /var/network_logs/gc/archive/asalog*  -mtime -7 -exec zcat {} +  |
awk '
  !/Built inbound|Built outbound/ || /10\.10\.120\.145/ {
    next
  }
  {
    $0=$10 FS $11 FS $15 FS $18                   # recalculate fields
    gsub("[/:]",FS)
    if ($1 == "inbound")
      $0=$1 FS $2 FS $3 FS $4 FS $6 FS $7 FS $8   # recalculate fields
    else if ($1 == "outbound")
      $0=$1 FS $2 FS $6 FS $7 FS $3 FS $4 FS $5   # recalculate fields
  } 
  !seen[$0]++
' >> /home/kenneth.cramer/asa/GC_ports.txt

Last edited by Scrutinizer; 04-12-2016 at 11:57 PM..

Scrutinizer

View Public Profile for Scrutinizer

Find all posts by Scrutinizer

8 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

improving my script (find & replace)

Hi all, I have a script that scan files, find old templet and replace it with new one. #!/bin/ksh file_name=$1 old_templet=$2 new_templet=$3 # Loop through every file like this for file in file_name do cat $file | sed "s/old_templet/new_templet/g" > $file.new #do a global searce and...

2. Shell Programming and Scripting

improving my script

Hi; I want to access our customer database to retreive all clients that have as language index 2 or 3 and take their client number. My input is a file containing all client numbers. i access the data base using a function call "scpshow". The total number of clients i want to scan is 400 000...

3. UNIX for Dummies Questions & Answers

Improving Unix Skills

Kindly any advice to improve my unix skills as electronic books i can download or valuable sites as this one etc...

4. Shell Programming and Scripting

Improving this validate function

Hi guys, I use this function which was provided to me by someone at this site. It works perfectly for validating a users input option against allowed options.. example: validateInput "1" "1 3 4 5" would return 0 (success) function validateInput { input=$1 allowedInput=$2 for...

5. Shell Programming and Scripting

Improving code by using associative arrays

I have the following code, and I am changing it to #!/bin/bash hasArgumentCModInfile=0 hasArgumentSrcsInfile=0 hasArgumentRcvsInfile=0 OLDIFS="$IFS" IFS="|=" # IFS controls splitting. Split on "|" and "=", not whitespace. set -- $* # Set the positional...

6. Shell Programming and Scripting

Basic help improving for in loop

I'm obviously very new to this. I'm trying to write a simple for loop that will read the directory names in /Users and then copy a file into the same subdir in each user directory. I have this, and it works but it isn't great. #!/bin/bash HOMEDIRS=/Users/* for dirs in $HOMEDIRS; do if ];...

7. Shell Programming and Scripting

Help with improving korn shell script

I am primarily a SQA/Tester and new to korn shell. How can I improve the following script? #/bin/ksh SourceLocation=~/Scripts/Test/Source TrackerLocation=~/Scripts/Test/Tracker TargetLocation=rdbusse@rdbmbp:/Users/rdbusse/Scripts/Test/Target for file in $(cd $SourceLocation; ls) do ...

8. Shell Programming and Scripting

Improving code

Gents, I did the below code to get an output (report) ,.. the code works fine but I believe it can be more shorted using better method. Please if you can help, to generate same output improving the code , will be great. here my code. # get diff in time awk '{$9=$8-prev8;prev8=$8;print...

LEARN ABOUT OSF1

mkcover

MKCOVER(8)						      System Manager's Manual							MKCOVER(8)

NAME

       mkcover - HylaFAX continuation cover page generation command

SYNOPSIS

       /var/spool/hylafax/bin/mkcover qfile template result

DESCRIPTION

       bin/mkcover  is the command invoked by the facsimile server when a continuation cover page is required for an outbound job that is about to
       be retried.  It generates a single POSTSCRIPT(R) page that is imaged according to the remote capabilities  and  transmitted  as	the  cover
       page.  The arguments are:

       qfile	 the job description file for the outbound job.

       template  the cover page template file, as used by the faxcover(1) program.

       result	 the filename where the resultant POSTSCRIPT document should be written.

       The default mkcover command is a shell script that uses awk(1) to parse the job description file and generate the cover page document.  The
       template file may be optionally compressed with compress(1), pack(1), or gzip(1); the filename suffix is used to decide whether or not  the
       template file contains compressed data.

SEE ALSO

       faxq(8), hylafax-config(5), sendq(5)

								   June 20, 1994							MKCOVER(8)