Sorry, but this question reeks like homework so much i have to close it.

Moderator's Comments:

@sudobash: if this is homework please say so. (send a PM to me or any other moderator) The thread will be transferred to the homework and coursework forum and you can continue there. Please notice that in the homework forum special rules are in place. If this is not homework, please explain what you try to achieve. We might find a better solution for your original problem instead of improving what you think is a solution. This thread is closed and will only be opened after a declaration of this either being or not being homework. @all other contributors, especially vgersh99: we are quite proud of our continued efforts to avoid doing the homework for students (which would be counterproductive not only for us because we''ll get unfit colleagues but also for the students who will be robbed the chance to learn and improve their skills). But to do this we need to rely on you, especially the longterm-members and contributing experts answering threads here. I suppose you have, over time, deveoped the same "homework-radar" as most of us have. Please use your good judgement and DO NOT ANSWER threads that are likely to be homework until this question is answered. Yes, i am aware that it is hard to know the answer and not post it. But weighing several aspects against each other we came to the conclusion that the overall good is best served this way. vgersh99's first post was hidden from public view for exactly that reason. If you want to contribute to this (or any other) decision we make: you are invited to write in the Underground and we value your input. We always try to replace good systems and decisions with better ones and if you want to contribute to this process we will be indebted to no end. But, for the reasons above, this thread is closed.

@thread-op:

Your solution:

Code:

for i in `cat text.file`
do
sed "s/\$i/$var1" text.file > text.file.new

has two shortcomings:

first, the sed-statement is incomplete and should read:

Code:

"s/\$i/$var1/"

Notice the "/" at the end. Second, your for-loop is not closed:

Code:

for <var> in <list of values>
do
   cmd1
   cmd2
   ...
done

You might want to correct these and then look what your code produces and if it matches what you want. Chances are there are still differences.

Btw., using "for"-loops with open-ended lists (you do not know beforehand how long text.file will be) is never a good idea, though not syntactically wrong. Better replace such constructs with a "while"-loop, which will do the same:

Code:

while read <var> ; do
    cmd1 "$VAR"
    cmd2 "$VAR"
    ....
done < /path/to/input.file

I hope this helps.

bakunin