Improve script and get new output file Post: 302946889

Sponsored Content

Top Forums Shell Programming and Scripting Improve script and get new output file Post 302946889 by RudiC on Saturday 13th of June 2015 05:13:42 PM

06-13-2015

Registered User

A good step into the right direction! Some comments:
Once you adopted a style, you should stay consistent (which doesn't mean you can't evolve over time). In above, in "create DBase", you have "continuation backslashes", in the other, you don't (as they obviously aren't needed). You should stick to one single syntax.
And this }END{ is absolutely horrible to read. awk uses
pattern {action}
pairs, c.f. man awk. You could reflect that in your style. Why don't you look around in here and find a neat style that you like and can adopt and adapt?

---------- Post updated at 23:13 ---------- Previous update was at 23:02 ----------

Regarding your performance issue: Having a loop running awk to produce a shell script full of sed commands which then is executed by sh smells like to be sloooow.
And - your script has changed from post#1 to post#5. Sure it's still working?

There certainly are ways to improve, but I don't think I'll be working on THAT script. Explain verbosely and exactly what you need to be done, post sample input and output files, and someone in here might come up with a good solution for you.

Last edited by RudiC; 06-13-2015 at 06:38 PM..

These 2 Users Gave Thanks to RudiC For This Post:

RudiC

View Public Profile for RudiC

Find all posts by RudiC

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Can I improve this script ???

Hi all, Still a newbie and learning as I go ... as you do :) Have created this script to report on disc usage and I've just included the ChkSpace function this morning. It's the first time I've read a file (line-by-bloody-line) and would like to know if I can improve this script ? FYI - I...

2. Shell Programming and Scripting

Any way to improve performance of this script

I have a data file of 2 gig I need to do all these, but its taking hours, any where i can improve performance, thanks a lot #!/usr/bin/ksh echo TIMESTAMP="$(date +'_%y-%m-%d.%H-%M-%S')" function showHelp { cat << EOF >&2 syntax extreme.sh FILENAME Specify filename to parse EOF...

3. Shell Programming and Scripting

Improve the performance of a shell script

Hi Friends, I wrote the below shell script to generate a report on alert messages recieved on a day. But i for processing around 4500 lines (alerts) the script is taking aorund 30 minutes to process. Please help me to make it faster and improve the performace of the script. i would be very...

4. Shell Programming and Scripting

Want to improve the performance of script

Hi All, I have written a script as follows which is taking lot of time in executing/searching only 3500 records taken as input from one file in log file of 12 GB Approximately. Working of script is read the csv file as an input having 2 arguments which are transaction_id,mobile_number and search...

5. Shell Programming and Scripting

Var Check Script (Help improve if possible)

I am working on a script to check the var on all of my systems. Can someone help me fix it to work better or give me suggestions. #!/bin/ksh IN=/path/to/list_of_workstations.txt while read hostnames do if ping $hostnames 1 | grep alive > /dev/null then percent=`ssh -q...

6. Shell Programming and Scripting

Looking to improve the output of this awk one-liner

I have the following awk one-liner I came up with last night to gather some data. and it works pretty well (apologies, I'm quite new with awk, and don't know how to format this pretty-printed). You can see the output with it. awk '{if ($8 == 41015 && $21 == "requests") arr+=$20;if ($8 == 41015...

7. UNIX for Dummies Questions & Answers

How to improve the performance of this script?

Hi , i wrote a script to convert dates to the formate i want .it works fine but the conversion is tkaing lot of time . Can some one help me tweek this script #!/bin/bash file=$1 ofile=$2 cp $file $ofile mydates=$(grep -Po '+/+/+' $ofile) # gets 8/1/13 mydates=$(echo "$mydates" | sort |...

8. Shell Programming and Scripting

Improve sftp script

Dear all, I have written two scripts to transfer files to another server outside the company. One is a batch script , and the other script calls the batch script, send the files and archive the file sent. The problem is, that I want to get the list of files which have been uploaded the the...

9. Shell Programming and Scripting

How to improve an script?

Gents. I have 2 different scripts for the same purpose: raw2csv_1 Script raw2csv_1 finish the process in less that 1 minute raw2csv_2 Script raw2csv_2 finish the process in more that 6 minutes. Can you please check if there is any option to improve the raw2csv_2. To finish the job...

10. Shell Programming and Scripting

Improve script

Gents, Is there the possibility to improve this script to be able to have same output information. I did this script, but I believe there is a very short code to get same output here my script awk -F, '{if($10>0 && $10<=15) print $6}' tmp1 | sort -k1n | awk '{a++} END { for (n in a )...

LEARN ABOUT DEBIAN

installsieve

INSTALLSIEVE(1) 					      General Commands Manual						   INSTALLSIEVE(1)

 *

NAME

       installsieve - user utility for managing sieve scripts

SYNOPSIS

       installsieve

DESCRIPTION

       installsieve is a utility that allows users to manage their sieve scripts kept on the server.

OPTIONS

       -v <name> View script with the given name. The script if retrieved sucessfully is output to standard output.

       -l  List  all  of  the scripts currently on the server. If one of the scripts is active a arrow is printed indicating that it is the active
       script.

       -p <port> Port to connect to. If left off this defaults to "sieve" as defined in /etc/services.

       -i <file> Install a file onto the server. If a script with the same name already exists on the server it is overwritten.  Upon  sucessfully
       putting	the  script on the server the script is set active. If <file> has the extension .script it is chopped when put on the server since
       sieve names may not contain a '.'.

       -a <name> Set <name> as the active script. The list of available names can be obtained from the '-l' option..

       -d <name> Delete the sieve script on the server with <name>.

       -m <mechanism> Force installsieve to use <mechanism> for authentication. If not specified the strongest authentication mechanism is chosen.

       -g <name> Get the sieve script with <name> and save it to disk with a ".script" extension. If a file with that name already  exists  it	is
       overwritten.

       -u <user> Userid/Authname to use for authentication; by default, the current user.

CMU
								   Project Cyrus						   INSTALLSIEVE(1)