You could simplify the echo/read lines at the beginning:-
Code:
read var?"My prompt:- "
I agree with bakunin though, why is size important? Clear coding that is flexible if you need to adjust it later is far more important. As an exercise I once wrote a menu system in 60 lines no longer than 80 bytes just so I could print it on a single sheet.
It works just fine and was actually used for a production application, but I can hardly read it back now
Write out your logic, then work out the functions. Finally write your code to match your design and put useful comments in. Make it readable.
Also, make sure you do thorough error checking. Imagine if you issue a cd to a directory that does not exist, and then an rm * You might just destroy your home directory or wherever you were
Size should not be an issue. A neat way does not necessarily mean it will be smaller code, for example, using a loop to read a file and then use a single echo .... | cut .... command to extract the data from the line can be a single line, but using two or three variable substitutions may run far faster even if it does take more lines of code.
Sometimes, bigger is better
Robin
These 2 Users Gave Thanks to rbatte1 For This Post:
Hi All
I am reading a huge file of size 2GB atleast. I am reading each line and cutting certain columns and writing it to another file.
Here is the logic.
int main()
{
string u_line;
string Char_List;
string u_file;
int line_pos;
string temp_form_u_file;
... (10 Replies)
Hi All,
I have written a script which does some editing in the files, based on user input.This might not be the most elegant way of doing it and there would be many improvements needed.
Please go through it and let me know how it could be improved.
Suggestions are welcome!!
Thanks!... (2 Replies)
Hi!
Thank you for the help yesterday
This is the finished product
There is one more thing I would like to do to it but I’m not to certain
On how to proceed I would like to log all output to a log in order to
Be able to roll back
This script is meant to be used in repairing a... (4 Replies)
I write reports daily to a directory that is named with the month and year. I wanted to compress all but the last two months worth of these directories to save space. I am going to cron a job to run on the first of each month to do this clean up. I didn't have zip/unzip on my AIX environment so... (0 Replies)
can anyone help to share the knowledge on linux os improvement?
1) os account
- use window AD authentication, such as ldap, but how to set /etc/passwd, where to put user home?
2) user account activity
- how to log os user activity
share the idea and what tools can do that...thx (5 Replies)
Hi All,
Here is my script
#! /bin/sh
var1=some email id
var2=some email id
grep -i "FAILED FILE FORMAT VALIDATION" /opt >tmp2
diff tmp1 tmp2 | grep ">" >tmp3
if
then
cat tmp3 | mailx -s " Error Monitoring" $var2
else
echo "Pattern NOt Found" | mailx -s " Error Monitoring" $var1... (1 Reply)
Below script is used to search numeric data from around 400 files in a folder. I have 300 such folders. Need help in performance improvement in the script.
Below Script searches 20 such folders ( 300 files in each folder) simultaneously. This increases cpu utilization upto 90% What changes... (3 Replies)
Discussion started by: vegasluxor
3 Replies
LEARN ABOUT MINIX
ed
ED(1) General Commands Manual ED(1)NAME
ed - editor
SYNOPSIS
ed file
OPTIONS
- Suppress line/byte count messages (for in scripts)
EXAMPLES
ed prog.c # Edit prog.c
echo '1,$p' | ed - file
# Odd way to write 'cat file'
DESCRIPTION
Ed is functionally equivalent to the standard V7 editor, ed. It supports the following commands:
(.) a: append
(.,.)c: change
(.,.)d: delete
e: edit new file"
f: print name of edited file"
(1,$)g: global command
(.) i: insert
(.,.+1)j: join lines together
(.) k: mark
(.) l: print with special characters in octal
(.,.)m: move
(.,.)p: print
q: quit editor"
(.) r: read in new file
(.,.)s: substitute
(1,$)v: like g, except select lines that do not match
(1,$)w: write out edited file
Many of the commands can take one or two addresses, as indicated above. The defaults are shown in parentheses. Thus a appends to the cur-
rent line, and g works on the whole file as default. The dot refers to the current line. Below is a sample editing session with comments
given following the # symbol.
ed prog.c # Edit prog.c
3,20p # Print lines 3 through 20
/whole/ # Find next occurence of whole
s/whole/while/ # Replace whole by while
g/Buf/s//BUF/g # Replace Buf by BUF everywhere
w # Write the file back
q # Exit the editor
Ed is provided for its sentimental value. If you want a line-oriented editor, try ex. If you want a good editor, use elle, elvis, or
mined.
SEE ALSO elvis(1), elle(9), mined(9).
ED(1)
06-19-2014
