Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Help with script.. it Just doesn't work
Top Forums Shell Programming and Scripting Help with script.. it Just doesn't work Post 302398053 by methyl on Tuesday 23rd of February 2010 06:30:17 PM
Old 02-23-2010
We need to get certain quirks out of the script first to make it understandable.

1) Please remove the semi-colon at the end of any line where it is the last character. This is unix script not Oracle.

2) I am nervous about the line spacing as posted. Was this script created as a unix text file using a unix text editor?
If you do this command does every line end in a $ character (meaning standard unix line terminator)?

Code:
sed -n l the_name_of the_script

3) Tip: If you have called a script with variables, save those variables in meaningfully-named environment variables as soon as possible in case a subsequent command changes those $n variables or the script just becomes difficult to follow. In this script we have no ideas what is in $1 except that it is a directory name and that if it is not provided we can proceed with the script after displaying a meaningless message.

Quote:
if [ "$1" == "" ]; then
echo -ne ""
Perhaps better?
Code:
if [ "$1""X" = "X" ]; then
	echo "Usage: scriptname <directory_name>"
             exit 1



4) Please re-test after removing extraneous semi-colons and removing any extraneous carriage-return characters from the script file (if present). Then please re-post the current version of the script showing exactly how it was called and all output produced (including any error messages).

5) Each time you issue an "ls" where the files may not be present, you need to stop the command failing by redirecting the error channel.

Quote:
result=$(ls -al "$path" |egrep '.*\.sfv')
Code:
result=$(ls -al "$path" 2>/dev/null |egrep '.*\.sfv')

6) Within the commented-out "rar" section, this line is strange:

Quote:
# if [ "$files" == "" ]; then
What do you want the test to achieve?
Last edited by methyl; 02-23-2010 at 08:49 PM.. Reason: ls quirks
 

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

command line work script doesn't

Hello, I'm stuck and confused as to why when I execute things form the command line it works but when in a script it doesn't. My script: ### creating a lock on the console touch /var/run/console.lock chmod 600 /var/run/console.lock echo "$User" >>... (2 Replies)
Discussion started by: larry
2 Replies

2. UNIX for Dummies Questions & Answers

Script doesn't work, but commands inside work

Howdie everyone... I have a shell script RemoveFiles.sh Inside this file, it only has two commands as below: rm -f ../../reportToday/temp/* rm -f ../../report/* My problem is that when i execute this script, nothing happened. Files remained unremoved. I don't see any error message as it... (2 Replies)
Discussion started by: cheongww
2 Replies

3. Shell Programming and Scripting

script doesn't work in another distribution

Hi everybody: I usually use Mandriva distro (in my laptop), and I have made some scripts. These scripts work correctly but now, in other computer which is installed Ubuntu don't work, and I have this error message: The script is: ..... echo "Your option is:" echo read option case... (1 Reply)
Discussion started by: tonet
1 Replies

4. Shell Programming and Scripting

gcd.sh script doesn't work...

Hi there. I'm new to scripting in bash shell and I have this problem. I'm trying to make a script that returns the greatest common divisor of two integer numbers according to Euclid's algorithm... Here is, what I've done: #!/bin/bash m=$1 n=$2 while do if ; #line 8 then m=$m-$n... (1 Reply)
Discussion started by: kantze
1 Replies

5. Shell Programming and Scripting

Expect script doesn't work under crontab

Hi All, Using Expect script when I run it manually it works. But when I put the entry in crontab, the job is still running after 15 hours. The script was created as root. I don't think it's a permission issue. Any idea? This is what I have under root crontab... 00 18 * * 1-5... (4 Replies)
Discussion started by: samnyc
4 Replies

6. Shell Programming and Scripting

two grep in one script doesn't work?

Hi there, the following script doesn't work. the first part works, then the second 'grep' fails with ': not found'. However, if I take out the second part (starting with the grep command) and put in a seperate script, it works. everyone know what's wrong here? no two 'grep' in one script, that... (2 Replies)
Discussion started by: monkey77
2 Replies

7. Shell Programming and Scripting

Script doesn't work in loop but does if not

I have a script that only works if I remove it from the looping scenario. #!/bin/bash # Set the field seperator to a newline ##IFS=" ##" # Loop through the file ##for line in `cat nlist.txt`;do # put the line into a variable. ##dbuser=$line echo "copying plugin..." ... (6 Replies)
Discussion started by: bugeye
6 Replies

8. Shell Programming and Scripting

my script doesn't work :(

i have this script and when i ejecute it, the console tell me this " sintax error line 41 unexpected element "}" " is the sintaxis ok? #!/bin/bash if ;then { exit 0; } if ; then { sudo /etc/init.d/apache2 start; sudo /etc/init.d/mysql start; php5 & nautilus... (3 Replies)
Discussion started by: keiserx
3 Replies

9. Shell Programming and Scripting

[Solved] Script doesn't work..help?

hi, i am trying to run this script.the name of script is final.sh after i run it: #./final.sh & i grep the command # ps -a | grep bash and i see more then one processes runing 3!! Please use code tags how can i solve this problem? my target script must always run in... (8 Replies)
Discussion started by: zigizag
8 Replies

10. Shell Programming and Scripting

Read in script doesn't work

I am trying to run a script to make a simple modification to a number of similar files. The sed works, but after it runs and the differences are displayed, the script does not read ans to start a renaming script if the user answered Y or y.for i in "$@" do sed -f myfile.sed $i >$i.new diff... (2 Replies)
Discussion started by: wbport
2 Replies

LEARN ABOUT XFREE86

checkbashisms

CHECKBASHISMS(1)					      General Commands Manual						  CHECKBASHISMS(1)

NAME

       checkbashisms - check for bashisms in /bin/sh scripts

SYNOPSIS

       checkbashisms script ...
       checkbashisms --help|--version

DESCRIPTION

       checkbashisms, based on one of the checks from the lintian system, performs basic checks on /bin/sh shell scripts for the possible presence
       of bashisms.  It takes the names of the shell scripts on the command line, and outputs warnings if possible bashisms are detected.

       Note that the definition of a bashism in this context roughly equates to "a shell feature that is not required to be supported  by  POSIX";
       this means that some issues flagged may be permitted under optional sections of POSIX, such as XSI or User Portability.

       In  cases  where  POSIX	and  Debian  Policy  disagree, checkbashisms by default allows extensions permitted by Policy but may also provide
       options for stricter checking.

OPTIONS

       --help, -h
	      Show a summary of options.

       --newline, -n
	      Check for "echo -n" usage (non POSIX but required by Debian Policy 10.4.)

       --posix, -p
	      Check for issues which are non POSIX but required to be supported by Debian Policy 10.4 (implies -n).

       --force, -f
	      Force each script to be checked, even if it would normally not be (for instance, it has a bash or non POSIX shell shebang or appears
	      to be a shell wrapper).

       --extra, -x
	      Highlight lines which, whilst they do not contain bashisms, may be useful in determining whether a particular issue is a false posi-
	      tive which may be ignored.  For example, the use of "$BASH_ENV" may be preceded by checking whether "$BASH" is set.

       --version, -v
	      Show version and copyright information.

EXIT VALUES

       The exit value will be 0 if no possible bashisms or other problems were detected.  Otherwise it will be the sum of the following error val-
       ues:

       1      A possible bashism was detected.

       2      A file was skipped for some reason, for example, because it was unreadable or not found.	The warning message will give details.

SEE ALSO

       lintian(1).

AUTHOR

       checkbashisms  was originally written as a shell script by Yann Dirson <dirson@debian.org> and rewritten in Perl with many more features by
       Julian Gilbey <jdg@debian.org>.

DEBIAN
								 Debian Utilities						  CHECKBASHISMS(1)
All times are GMT -4. The time now is 12:01 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy