Login or Register to Ask a Question and Join Our Community

Sponsored Content
Full Discussion: Bash script: issue changing directories in script
Top Forums Shell Programming and Scripting Bash script: issue changing directories in script Post 302319203 by methyl on Sunday 24th of May 2009 03:54:41 PM
Old 05-24-2009
You may be safer with ls -1 (ls hyphen one) which just lists the names for the files, then pipe to a "while read". This is in case you have filenames containing space characters which will break the "for" statement or you have so many files that the "for" statement becomes too long.
You have an issue with $entry which is not referred to at all and is probably surplus.
It would also be better to place $2 in to a named variable for readability.
Notice how we put double quotes round any parameter (including filenames) to preserve any embedded space characters.

I like your use of comment lines. Very good.



Code:
elif [ -d "${2}" ]   #test the command line argument for a directory
then
#change directories to the the second command line argument
        cd "${2}"
        ls -1 | while read filename
        do
        # Verify that the name read in the directory is a file
                if [ -f "${filename}" ]
                then
        # Search the files for the pattern specified by $1, then call search.sh
            ./search.sh "${1}" "${listing}"

Bump: bakunin has made a valid point. The cd could cause the "./search" statement to fail unless the script called "search" existed in that directory.

At the start if the script (or in your .profile) you can change $PATH to ensure that you find your scripts.

Let's say that your scripts are in directory /home/Breakology/scripts .
If we want to refer to our scripts by name we can adjust the PATH.

Code:
PATH=${PATH}:/home/Breakology/scripts
export PATH

The script called "search" can then be called as "search" not "./search".

Addition Information Added:

(I have absolutely no idea where the "bump" came from and I am sending this post to test a theory).
 

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Bash Script to display directories in Path?

Hello there, As a newbie: The directories in PATH can be hard to distinguish when printed out as one line with colon .Please, can i have a sample script to display them,one to a line. Thank you. (1 Reply)
Discussion started by: debut
1 Replies

2. Shell Programming and Scripting

(w)get web server's directories + bash script

Hi everyone. I need to write a script which will download files/folders (a huge collection) to the local file server (centOS 4.4 Server), and check regularly (every 6 hours or so if any new files are present, or if the old ones were modified to update contents). Any insights on how to tackle... (2 Replies)
Discussion started by: reminiscent
2 Replies

3. Shell Programming and Scripting

Bash Script to Read & Write on different directories

Hi, root@server] df -h 121G 14G 101G 12% /home 147G 126G 14G 91% /backup We having our site files and images are storing in /backup/home/user/files/ through symbolic link created in /home directory pointing in /backup directory as following. root@server] cd /home... (1 Reply)
Discussion started by: mirfan
1 Replies

4. Shell Programming and Scripting

bash script to rename multiple directories

Hello I have a directory structure with year in format 4 digits, e.g 2009, below which is month format 1 or 2 digits, e.g 1 or 12, blow which is day format 1 or 2 digits, e.g 1 or 31. I want to change the names of lots of directories to the be Year - 4 digits , e.g 2009 - No change here... (4 Replies)
Discussion started by: garethsays
4 Replies

5. Shell Programming and Scripting

Changing File Time Stamp (Bash Script)

I need some help recovering from a "slight" screwup. We just moved 3 TB of data from one RAID Array to another. Low lever archive files. This was done with a regular cp (for some reason) and now we have lost all the timestamps on the files, and we urgently need to get the timestamps back on these... (7 Replies)
Discussion started by: chj
7 Replies

6. Shell Programming and Scripting

changing cron using bash script

How can I change the cron entries only for ABC and XYZ from dosomething_1.0.sh to nowchanged_2.0 using a bash script ? Any help will be appreciated. # # ABC 00,05,10,15,20,25,30,35,40,45,50,55 * * * * /mydir/dosomething_1.0.sh 1>/dev/null 2>&1 # # ## # DEF... (4 Replies)
Discussion started by: jville
4 Replies

7. Shell Programming and Scripting

Chose list of sub directories in a bash script file

Hi, I have a command in my bash script, searchDirectoryName.sh: DIR_NAME=$(find . -type d) echo "${DIR_NAME}" . ./Dir1 ./Dir1/1.0.2.1 ./Dir2 ./Dir2/1.1 ./Dir3 ./Dir3/2.2.1 How can I select only following directory names with second subdirectoies and without first ./ in the... (3 Replies)
Discussion started by: hce
3 Replies

8. Shell Programming and Scripting

Changing script from csh to bash

Hello Guys I have a script working fine on csh, but I would like to change it to bash, how I should change this command to be able to work as bash script. :wall: if ( $fsw > "0" ) then foreach swath ( `awk 'BEGIN {for (i='$fsw';i<='$lsw';i++) printf ("%s\n", i) }'` ) ## work to be done... (2 Replies)
Discussion started by: jiam912
2 Replies

9. UNIX for Beginners Questions & Answers

Connecting and changing variables in Bash script

#!/bin/bash X=$(</home/cogiz/computerhand.txt) # (3S 8C 2H 6D QC 8S 4H 5H) Y=$(</home/cogiz/topcardinplay.txt) # KS A=( "${Y::1}" ) B=( "${Y:1}" ) for e in ${X}; do if ]; then # searching for valid cards K,S or 8 ... (0 Replies)
Discussion started by: cogiz
0 Replies

10. Shell Programming and Scripting

Changing date using bash script

I am trying to change dates in a bash script. I have a start time and an endtime and want to increment the times. Basically the month and day have to be incremented in a loop to create two strings, stm and etm defining the start and end times. stm="2014-05-13T00:00:00"... (4 Replies)
Discussion started by: novilatte
4 Replies

LEARN ABOUT LINUX

init.d

init.d(4)																 init.d(4)

NAME

       init.d - initialization and termination scripts for changing init states

SYNOPSIS

       /etc/init.d

       /etc/init.d is a directory containing initialization and termination scripts for changing init states. These scripts are linked when appro-
       priate to files in the rc?.d directories, where `?' is a single character corresponding to the init state.  See init(1M) for definitions of
       the states.

       The service management facility (see smf(5)) is the preferred mechanism for service initiation and termination. The init.d and rc?.d direc-
       tories are obsolete, and are provided for compatibility purposes only. Applications launched from these directories by  svc.startd(1M)  are
       incomplete services, and will not be restarted on failure.

       File names in rc?.d directories are of the form [SK]nn<init.d filename>, where S means start this job, K means kill this job, and nn is the
       relative sequence number for killing or starting the job.

       When entering a state (init S,0,2,3,etc.) the rc[S0-6] script executes those scripts in /etc/rc[S0-6].d that are prefixed with  K  followed
       by  those  scripts  prefixed with S. When executing each script in one of the /etc/rc[S0-6] directories, the /sbin/rc[S0-6] script passes a
       single argument. It passes the argument 'stop' for scripts prefixed with K and the argument 'start' for scripts prefixed with S.  There	is
       no harm in applying the same sequence number to multiple scripts. In this case the order of execution is deterministic but unspecified.

       Guidelines  for	selecting  sequence  numbers  are provided in README files located in the directory associated with that target state. For
       example, /etc/rc[S0-6].d/README. Absence of a README file indicates that there are currently no established guidelines.

       Do not put /etc/init.d in your $PATH. Having this directory in your $PATH can cause unexpected behavior. The programs  in  /etc/init.d  are
       associated with init state changes and, under normal circumstances, are not intended to be invoked from a command line.

       Example 1: Example of /sbin/rc2.

       When changing to init state 2 (multi-user mode, network resources not exported), /sbin/rc2 is initiated by the svc.startd(1M) process.  The
       following steps are performed by /sbin/rc2.

       1.  In the directory /etc/rc2.d are files used to stop processes that should not be running in state 2. The filenames are prefixed with	K.
	   Each K file in the directory is executed (by /sbin/rc2) in alphanumeric order when the system enters init state 2. See example below.

       2.  Also in the rc2.d directory are files used to start processes that should be running in state 2. As in Step 1, each S file is executed.

       Assume the file /etc/init.d/netdaemon is a script that will initiate networking daemons when given the argument 'start', and will terminate
       the daemons if given the argument 'stop'. It is linked to /etc/rc2.d/S68netdaemon, and to /etc/rc0.d/K67netdaemon. The file is executed	by
       /etc/rc2.d/S68netdaemon start when init state 2 is entered and by /etc/rc0.d/K67netdaemon stop when shutting the system down.

       svcs(1), init(1M), svc.startd(1M), svccfg(1M), smf(5)

       Solaris	now  provides  an  expanded mechanism, which includes automated restart, for applications historically started via the init script
       mechanism. The Service Management Facility (introduced in smf(5)) is the preferred delivery mechanism  for  persistently  running  applica-
       tions.  Existing init.d scripts will, however, continue to be executed according to the rules in this manual page. The details of execution
       in relation to managed services are available in svc.startd(1M).

       On earlier Solaris releases, a script named with a suffix of '.sh' would be sourced, allowing scripts to modify the  environment  of  other
       scripts	executed  later. This behavior is no longer supported; for altering the environment in which services are run, see the setenv sub-
       command in svccfg(1M).

       /sbin/rc2 has references to the obsolescent rc.d directory. These references are for compatibility with old INSTALL  scripts.  New  INSTALL
       scripts should use the init.d directory for related executables.  The same is true for the shutdown.d directory.

								    17 Aug 2005 							 init.d(4)
All times are GMT -4. The time now is 10:54 PM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy