Please, review script. Post: 302256399

Sponsored Content

Top Forums Shell Programming and Scripting Please, review script. Post 302256399 by Annihilannic on Sunday 9th of November 2008 08:01:35 PM

11-09-2008

Registered User

I would eliminate the use of temporary files where possible and redirect to the report file only once to simplify the script a little. I'd also add indentation for readability.

Also your last line is missing some punctuation in the date command.

For example (untested):

Code:

#!/bin/bash
(
  echo " Exceeded mailbox-quota in domains"
  echo "*************************************"
  #
  ls /home/mailboxes | while read domain; do
    cd /home/mailboxes/$domain
    echo "Checked mailboxes of $domain...."
    du -k --max-depth=1 |
      sort -rn |
      sed -e '1d;s%./% %g' |
      while read num user; do
        if [ $num -ge 100000 ] ; then
        echo " $user's mailbox is $num Kb in $domain. This should be 100000" >> /home/tmp/$domain.report.txt
        echo " $user's mailbox is $num Kb"
        echo " "
        echo "---------------------------"
        #
        /usr/bin/mutt -nx -e 'set from=admin@mailhostingdomain.com; set realname="My RealName"' \
          -s "Noreply: emailquota exceeded " -a /home/tmp/$domain.report.txt postmaster@$domain < /dev/null
        else
        echo " No quota have been exceeded for $domain "
        echo " "
        echo "---------------------------"
        fi
      done
  done
) > /home/work/report-$(date +%F).txt

/usr/bin/mutt -nx -e 'set from=admin@mailhostingdomain.com; set realname="My RealName"' \
  -s "Noreply: New emailquota report $(date + %F) " \
  -a /home/work/report-$(date +%F).txt postmaster@mailhostingdomain.com < /dev/null

Annihilannic

View Public Profile for Annihilannic

Find all posts by Annihilannic

8 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Review the Shell Script

Hi, I want to copy all the log file except current date log from one server to another server. Log File will be like this LOGNIG_08_11_2008*.log For this cd /test/log date -d '1 day ago' "+%d_%m_%Y" -->This command gives previous day scp LOGSNIG_date -d '1 day ago' "+%d_%m_%Y"...

2. Shell Programming and Scripting

Review Check list for Unix Shell Script

Hi, I need Unix Shell Script Review Check list in the format of word or excel. Can any one provide the review checklist for unix shell script. Pls.

3. Shell Programming and Scripting

a shell script for review.

I have written a bit of shell that lets our company check all our SSL certs. the aim is to have a list of servers and run this check from cron once a week. Our managers have decided that we will not run BASH, so it has been written in /bin/sh and only needs openssl, no perl, no bash, no extra...

4. Shell Programming and Scripting

Please review script for search in all files

I have written a little script to scan users home directories for certain commands located inside a file. The script is setup to include a small help section and allows for passing a username argument to override scanning of all users home directories. A lot of searching and trial and error has...

5. UNIX for Dummies Questions & Answers

Question/review my script: removing bad chars from filenames

The task: remove undesirable characters from filenames. Restrictions: Must use basic RE, base utilities (non-GNU) and /bin/sh (ash). No ksh, zsh, perl, etc. Below is what I've come up with. It seems to work OK but I'm open to shorter, more efficient alternatives. Inside the square...

6. Shell Programming and Scripting

Please review error routines in my ksh script

The script distributes files from an AIX server using iether ftp or sftp depending on the constraint of the destination server. I am interested in having the error checking routine critically reviewed. I will only include an excerpt from the script concerning error trapping: (where $FTP_OUT is the...

7. Shell Programming and Scripting

Peer Review File/Folder Script

Hello *nix friends, I've written a shell script that allow web admin's to copy file/folder from a development site to the production site. It's more or less a poor man SVN. I'm posting the script here because I was able to get many questions answered through this forum and also, I want to...

8. Cybersecurity

Log Review- SU

Hi, Can some please provide some hints on what to look for in unix/Linux logs such as sulog from a Information security perspective. Regards

LEARN ABOUT SUNOS

script

script(1)							   User Commands							 script(1)

NAME

       script - make record of a terminal session

SYNOPSIS

       script [-a] [filename]

DESCRIPTION

       The  script  utility  makes a record of everything printed on your screen. The record is written to filename. If no file name is given, the
       record is saved in the file typescript. See WARNINGS.

       The script command forks and creates a sub-shell, according to the value of $SHELL, and records the text from this session. The script ends
       when the forked shell exits or when Control-d is typed.

OPTIONS

       The following option is supported:

       -a	Appends the session record to filename, rather than overwriting it.

NOTES

       script places everything that appears on the screen in filename, including prompts.

ATTRIBUTES

       See attributes(5) for descriptions of the following attributes:

       +-----------------------------+-----------------------------+
       |      ATTRIBUTE TYPE	     |	    ATTRIBUTE VALUE	   |
       +-----------------------------+-----------------------------+
       |Availability		     |SUNWcsu			   |
       +-----------------------------+-----------------------------+
       |CSI			     |Enabled			   |
       +-----------------------------+-----------------------------+

SEE ALSO

       attributes(5)

WARNINGS

       script  can  pose  a  security risk when used in directories that are writable by other users (for example, /tmp), especially when run by a
       privileged user, that is, root. Be sure that typescript is not a link before running script.

SunOS 5.10							    30 Jan 2004 							 script(1)