08-11-2008
You localized a typeglob named SYSMAN in the loop where you build up
the filehandle array.
I am still also used to localizing filehandles like that.
But anyway, as current Perl releases allow to use lexically scoped variables as filehandles (see POD for open, or perlopentut)
have you tried if using them would make a difference?
May I ask why you are using two separate foreach loops in your subs?
If you put it in one loop there was also no need for the @sysmanhandles array.
Also I would assume that the backslashes that quote the single quotes in your su command are redundant here
Quote:
my $sysman="$config{'su'} - $config{'user'} -c \'$config{'sysman'} ${check}Check -m $nd\'";
Last edited by buffoonix; 08-11-2008 at 06:15 AM..
10 More Discussions You Might Find Interesting
1. Shell Programming and Scripting
I have gone to /usr/bin/ and click on perl but notting happens.also notting happens when i click on c/c++ or any other program
whats wrong ? (2 Replies)
Discussion started by: perleo
2 Replies
2. Shell Programming and Scripting
Hello,
I need to print messages both to screen and to file handle in perl , like tee does in unix .
Any suggestions ?
Thanks (2 Replies)
Discussion started by: Alalush
2 Replies
3. Shell Programming and Scripting
Hi All,
I need some expert help in performing the following in Perl.
I have a code below but it doesn;t seem to work. Can any expert give me some advice?
Below are the requirements
1) Open numerous files assigned to an array @FILES. Note that the files are always named with the term... (7 Replies)
Discussion started by: Raynon
7 Replies
4. Shell Programming and Scripting
Hi All,
I have a total of ten file to open in the Perl script and i am using a for loop to open each file and capture some strings inside each file.
Unfortunately, i encounter the below syntax error.
I think there should be something wrong with this term reports_${counting}_${_}.txt but i do... (4 Replies)
Discussion started by: Raynon
4 Replies
5. Shell Programming and Scripting
Hi Guru's,
Pardon me for the breach of rules.....
I have very little knowledge about Shell Programming and Scripting hope you guys help me out of this troble
I have very little time hence could not find the right way to direct my queries.
coming to the problem
I need to call a... (2 Replies)
Discussion started by: saikrishna_tung
2 Replies
6. Shell Programming and Scripting
Good morning guys!!
Im still practicing with Perl and now Im trying to open a file, and copy its contents to another file. Them I want to remeove the information out of the orginal file after it is copied over.
The flow should be messages-->messages1-->messages2.
Kind of like a log... (1 Reply)
Discussion started by: bigben1220
1 Replies
7. Programming
Hi,
i have run the below perl code and i am getting an error
Error:readline() on closed filehandle OR at run.pl line 31.
CODE:
===========================================
open OR,$ARGV;
while (<OR>) { # find the batch date
next if length $_ < 3; # BLANK LINE
# last if $. > 120; #... (3 Replies)
Discussion started by: pspriyanka
3 Replies
8. UNIX for Dummies Questions & Answers
Hi I need to open a file if a condition(for example a if a regular expression) is met. How do i do this ?
open (file) if (some regex)..... (3 Replies)
Discussion started by: manutd
3 Replies
9. Shell Programming and Scripting
Hi
we have one function which is used to append data the file in exclusive lock mode in aperl script.
This script is executed by multiple threads at the same time.
accessing the same file.this script runs throught the day.
sometimes the file2.txt size is getting reduced.
for eg from 10 M... (1 Reply)
Discussion started by: Shahul
1 Replies
10. Shell Programming and Scripting
Hello friends,
i have a perl script as below ...
for (0 ..$#values)
{
##want to print some message here in Report.txt file
print `find /abc/xyz/pqr/$values" -type f -ls` >> Report.txt
}
I am able to get output of print `find /abc/xyz/pqr/$values" -type f -ls` >> Report.txt
in... (2 Replies)
Discussion started by: harpal singh
2 Replies
LEARN ABOUT CENTOS
perl::critic::policy::inputoutput::requirebriefopen
Perl::Critic::Policy::InputOutput::RequireBriefOpen(3) User Contributed Perl Documentation Perl::Critic::Policy::InputOutput::RequireBriefOpen(3)
NAME
Perl::Critic::Policy::InputOutput::RequireBriefOpen - Close filehandles as soon as possible after opening them.
AFFILIATION
This Policy is part of the core Perl::Critic distribution.
DESCRIPTION
One way that production systems fail unexpectedly is by running out of filehandles. Filehandles are a finite resource on every operating
system that I'm aware of, and running out of them is virtually impossible to recover from. The solution is to not run out in the first
place. What causes programs to run out of filehandles? Usually, it's leaks: you open a filehandle and forget to close it, or just wait a
really long time before closing it.
This problem is rarely exposed by test systems, because the tests rarely run long enough or have enough load to hit the filehandle limit.
So, the best way to avoid the problem is 1) always close all filehandles that you open and 2) close them as soon as is practical.
This policy takes note of calls to "open()" where there is no matching "close()" call within "N" lines of code. If you really need to do a
lot of processing on an open filehandle, then you can move that processing to another method like this:
sub process_data_file {
my ($self, $filename) = @_;
open my $fh, '<', $filename
or croak 'Failed to read datafile ' . $filename . '; ' . $OS_ERROR;
$self->_parse_input_data($fh);
close $fh;
return;
}
sub _parse_input_data {
my ($self, $fh) = @_;
while (my $line = <$fh>) {
...
}
return;
}
As a special case, this policy also allows code to return the filehandle after the "open" instead of closing it. Just like the close,
however, that "return" has to be within the right number of lines. From there, you're on your own to figure out whether the code is
promptly closing the filehandle.
The STDIN, STDOUT, and STDERR handles are exempt from this policy.
CONFIGURATION
This policy allows "close()" invocations to be up to "N" lines after their corresponding "open()" calls, where "N" defaults to 9. You can
override this to set it to a different number with the "lines" setting. To do this, put entries in a .perlcriticrc file like this:
[InputOutput::RequireBriefOpen]
lines = 5
CAVEATS
"IO::File->new"
This policy only looks for explicit "open" calls. It does not detect calls to "CORE::open" or "IO::File->new" or the like.
Is it the right lexical?
We don't currently check for redeclared filehandles. So the following code is false negative, for example, because the outer scoped
filehandle is not closed:
open my $fh, '<', $file1 or croak;
if (open my $fh, '<', $file2) {
print <$fh>;
close $fh;
}
This is a contrived example, but it isn't uncommon for people to use $fh for the name of the filehandle every time. Perhaps it's time to
think of better variable names...
CREDITS
Initial development of this policy was supported by a grant from the Perl Foundation.
AUTHOR
Chris Dolan <cdolan@cpan.org>
COPYRIGHT
Copyright (c) 2007-2011 Chris Dolan. Many rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module
perl v5.16.3 2014-06-09 Perl::Critic::Policy::InputOutput::RequireBriefOpen(3)