Create a binary tree Post: 302141282

Sponsored Content

Top Forums Shell Programming and Scripting Create a binary tree Post 302141282 by bakunin on Thursday 18th of October 2007 12:16:56 PM

10-18-2007

Registered User

Quote:

Originally Posted by macvijay1985

the testdir exists already. the problem is it is not producing a balanced binary tree, it seems to go only one way...if someone can find the mistake and correct it, that would be great too

Simple! A little correct quotations here and there and a little streamlining.... you were almost correct already. Here is the correct version (CreateDir() only)

Code:

function CreateDir
{

   # set -xv
   typeset -i level="$1"
   typeset    dirname="$2"

   mkdir $dirname/sub1/
   mkdir $dirname/sub2/

   (( level =- 1 )) 

   if [ $level -gt 0 ] ; then
      CreateDir $level "$dirname/sub1"
      CreateDir $level "$dirname/sub2"
   fi
}

I leave it up to you to spot the difference and why this works and your version didn't. ;-)))

Still, i *would* like to give a few hints for successful shell programming:

1 - Be paranoid about quoting! Shells have the notorious habit of digesting whitespace. Be sure to safeguard you variables between as many "-characters as you can afford.

2 - always program type-clean! If you have a variable holding an integer value do NOT use it as string and vice versa! If you need an integer, then DECLARE an integer (by typeset), etc. Shells are very forgiving when you spare the effort, but your program logic will suffer in the long run.

3 - always declare your variables! Yes, you can omit this in most shells, but still you should go the extra way - if you want to use a variable declare it first.

Overall: Just think how you would do it in C, PASCAL, whatever and do the same in shell, even if it isn't absolutely necessary. At least it is good bookkeeping to take not for granted what you use in you program code, but make shure the constructs you are using are really there and in a way you can use them.

bakunin

bakunin

View Public Profile for bakunin

Find all posts by bakunin

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Creating breadth traversal binary tree

I almost have the entire script written. however the problem is how would i assign the global variable to terminate the process from the bottom up to ensure the child terminates so the parent can. ex. I am proccess 1 I am proccess 2 etc Here is the code $ cat tree.c ...

2. UNIX for Dummies Questions & Answers

Binary Tree Creation Using fork()

Hi, I am working on a program and kind of a stuck,nt getting it done. "The program should take one command line arguments: number of hierarchy level. The hierarchy of your program should of that level and each node have two child processes." Can anyone give me the C code using fork() of this...

3. UNIX for Dummies Questions & Answers

Commands to create hierarchical tree structure

I am creating a hierarchical tree structure and I was wondering what commands I needed to do that. I have 4 directories and sixteen sub directories and 4 files. Thank you for your help in getting my started in right direction.:confused:

4. UNIX for Dummies Questions & Answers

How to create this tree?

a buddy and i are trying to re-learn basic commands. i havent used linux for awhile. so i need help on this. what are the commands to create a tree like this. . |-- a1.A |-- a1.B |-- opt | |-- documents | | `-- tmp | | |-- backup | | `-- etc | |-- music | `--...

5. Programming

Binary Tree

I have just been researching this topic and I was wondering what type of application might a binary tree be used for. For instance what type of application would be a good showcase for a binary tree that I could write as an example?

6. Shell Programming and Scripting

Create an XML tree using perl

Hi, I am having an xml file which looks like this: <Nodes> <Node> <Nodename>Student</Nodename> <Filename>1.txt</filename> <Node> <Nodename>Dummy</Nodename> <Filename>22.txt</filename> </Node> </Node> </Nodes> The text files will have data like this: #1.txt...

7. Shell Programming and Scripting

How we can create the master file through shell to show the tree structure of the directory?

Can we create the master file that show the whole tree structure of the directory till a particular folder? Database that contains four sub repository Sybase,sql,oracle,mysql and sql and oracle contains two subrepostories Siebel and plsql and each repositories contains three folders...

8. Programming

Binary Search Tree Search problem

I am writing code for a binary search tree search and when I compile it i am getting strange errors such as, " /tmp/ccJ4X8Xu.o: In function `btree::btree()': project1.cpp:(.text+0x0): multiple definition of `btree::btree()' " What does that mean exactly? tree.h #ifndef TREE_H #define...

9. Programming

Binary search tree questions. Please help =)

I have some questions about certain placement of child nodes since I'm just learning BSTs and it's quite confusing even after reading some sources and doing some online insertion applets. Let's say I want to add nodes 5,7,3,4 to an empty basic BST. ...

10. Web Development

Problem in printing binary tree using php and mysql

Database Structure Root Table ID Root_ Node Level 1 A 0 2 B 1 3 C 1 Child Table ID Left_Node Right_Node Root_Node Root_ID 1 B C A 1 ...

LEARN ABOUT FREEBSD

basename

BASENAME(1)						    BSD General Commands Manual 					       BASENAME(1)

NAME

     basename, dirname -- return filename or directory portion of pathname

SYNOPSIS

     basename string [suffix]
     basename [-a] [-s suffix] string [...]
     dirname string [...]

DESCRIPTION

     The basename utility deletes any prefix ending with the last slash '/' character present in string (after first stripping trailing slashes),
     and a suffix, if given.  The suffix is not stripped if it is identical to the remaining characters in string.  The resulting filename is
     written to the standard output.  A non-existent suffix is ignored.  If -a is specified, then every argument is treated as a string as if
     basename were invoked with just one argument.  If -s is specified, then the suffix is taken as its argument, and all other arguments are
     treated as a string.

     The dirname utility deletes the filename portion, beginning with the last slash '/' character to the end of string (after first stripping
     trailing slashes), and writes the result to the standard output.

EXIT STATUS

     The basename and dirname utilities exit 0 on success, and >0 if an error occurs.

EXAMPLES

     The following line sets the shell variable FOO to /usr/bin.

	   FOO=`dirname /usr/bin/trail`

SEE ALSO

     csh(1), sh(1), basename(3), dirname(3)

STANDARDS

     The basename and dirname utilities are expected to be IEEE Std 1003.2 (``POSIX.2'') compatible.

BSD
								  April 18, 1994							       BSD

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Creating breadth traversal binary tree

Discussion started by: slurpeyatari

2. UNIX for Dummies Questions & Answers

Binary Tree Creation Using fork()

Discussion started by: learneros

3. UNIX for Dummies Questions & Answers

Commands to create hierarchical tree structure

Discussion started by: GreginNC

4. UNIX for Dummies Questions & Answers

How to create this tree?

Discussion started by: ink