03-07-2002
The particular error that you are searching for is here:
if( fd = open( FILENAME, O_RDWR ) == -1 )
If the open system call succeeds, it will not return -1. Thus you will set fd=(open() == -1) to zero! You will not attempt the creat. Then you stat() the real file. Eventually you attempt a read from fd 0. You could just type something since you're reading from the terminal.
You gotta use:
if ((fd = open() ) == -1)
to get what you want. Don't feel too bad, this one still nails me.
You have several other bugs, but I'll let you find them for the most part. One bug is very subtle though. First you open() the file, if that fails then you creat() it. That is a race condition. Suppose the file is not there, so the open() fails. Just then, another process creates it. Then your creat() call must now fail too. Whenever you check to see if something is possible and then do it if looks possible, you are setting yourself up for this situation. It's ok to do a check first, but then you must check for success to see if it really worked.
9 More Discussions You Might Find Interesting
1. UNIX for Dummies Questions & Answers
I have 6 extra hard drives and want to install them in my boxes and run UNIX, LINUX andyes M$ Winblows. How do I make it so i have the choice of which HD to boot from? Also, which UNIX distribution should i run to get aquainted with it, and wheres the best place to get it? Thank you very much if... (5 Replies)
Discussion started by: r1sk
5 Replies
2. UNIX Desktop Questions & Answers
I am a long-time Windows NT, 2000 user at home and work. I want to learn Unix to broaden myself. What flavor do you recommend and how do you recommend practicing with it at home? how to get a copy of it to practice with? (1 Reply)
Discussion started by: robmaxfli
1 Replies
3. UNIX for Dummies Questions & Answers
Hello!
In my perpetual quest to learn Unix, I want to build a cheap Unix server for my personal use.
Do you guys have suggestions of web sites, vendors etc...where I could get info on things such as step-by-step instruction, 2nd hand hardware etc...
I would like to go preferably with a HP... (2 Replies)
Discussion started by: alan
2 Replies
4. UNIX for Dummies Questions & Answers
I learned Unix about 6 years ago, I think it was the System V version back then.
My course taught me, Unix commands, shell scripting, Vi editor, and probably more stuff.
I wanted to stick with Unix but life didn't allow me to, my college back then used Windows 95 and then my job as a... (8 Replies)
Discussion started by: thoughts
8 Replies
5. UNIX for Dummies Questions & Answers
I originally sent this as a PM to Neo, but I was ignorant towards the rule of PMing someone with technical information. Below is a copy / paste of the questions I asked. If anyone can help, I'd appreciate it tons. Thank you! :D
The first OS I ever encountered was DOS and Windows 3.1. Ever since... (1 Reply)
Discussion started by: ZeeSquared
1 Replies
6. UNIX for Dummies Questions & Answers
Firstly I do need to state that I am turning here as a last resort. Im in my first year of a Computer Networking and technical support course, and as a first year I must complete a Introductory Unix/Linux class. I have been doing well in the course so far however I have been stumped on the final... (1 Reply)
Discussion started by: setaylor5
1 Replies
7. Solaris
Hello,
I have recently completed my training for Solaris 10 and have a good understanding of the bases now. I am playing around with my system but can't do much since my knowledge is limited. I am looking for some projects or some threads where I can learn more and expand my knowledge step by... (16 Replies)
Discussion started by: saudsos
16 Replies
8. UNIX for Dummies Questions & Answers
I am a newbie Oracle DBA. All our oracle servers are hosted in AIX and Solaris Environment. I have no knowledge about this Unix O/S. So, it will be great if anyone here can suggest me any good book which will teach me the basics.
Any inputs/suggestions will be great for me. (1 Reply)
Discussion started by: sandip250382
1 Replies
9. Shell Programming and Scripting
I am working on UNIX AIX to Linux migration.
Does anybody know the good site for doing this?
Thanks for contribution (4 Replies)
Discussion started by: digioleg54
4 Replies
MADVISE(2) BSD System Calls Manual MADVISE(2)
NAME
madvise, posix_madvise -- give advice about use of memory
SYNOPSIS
#include <sys/mman.h>
int
madvise(void *addr, size_t len, int advice);
int
posix_madvise(void *addr, size_t len, int advice);
DESCRIPTION
The madvise() system call allows a process that has knowledge of its memory behavior to describe it to the system. The advice passed in may
be used by the system to alter its virtual memory paging strategy. This advice may improve application and system performance. The behavior
specified in advice can only be one of the following values:
MADV_NORMAL Indicates that the application has no advice to give on its behavior in the specified address range. This is the system
default behavior. This is used with madvise() system call.
POSIX_MADV_NORMAL
Same as MADV_NORMAL but used with posix_madvise() system call.
MADV_SEQUENTIAL Indicates that the application expects to access this address range in a sequential manner. This is used with madvise()
system call.
POSIX_MADV_SEQUENTIAL
Same as MADV_SEQUENTIAL but used with posix_madvise() system call.
MADV_RANDOM Indicates that the application expects to access this address range in a random manner. This is used with madvise() system
call.
POSIX_MADV_RANDOM
Same as MADV_RANDOM but used with posix_madvise() system call.
MADV_WILLNEED Indicates that the application expects to access this address range soon. This is used with madvise() system call.
POSIX_MADV_WILLNEED
Same as MADV_WILLNEED but used with posix_madvise() system call.
MADV_DONTNEED Indicates that the application is not expecting to access this address range soon. This is used with madvise() system call.
POSIX_MADV_DONTNEED
Same as MADV_DONTNEED but used with posix_madvise() system call.
MADV_FREE Indicates that the application will not need the information contained in this address range, so the pages may be reused
right away. The address range will remain valid. This is used with madvise() system call.
MADV_ZERO_WIRED_PAGES
Indicates that the application would like the wired pages in this address range to be zeroed out if the address range is
deallocated without first unwiring the pages (i.e. a munmap(2) without a preceding munlock(2) or the application quits).
This is used with madvise() system call.
The posix_madvise() behaves same as madvise() except that it uses values with POSIX_ prefix for the advice system call argument.
RETURN VALUES
Upon successful completion, a value of 0 is returned. Otherwise, a value of -1 is returned and errno is set to indicate the error.
ERRORS
madvise() fails if one or more of the following are true:
[EINVAL] The value of advice is incorrect.
[EINVAL] The address range includes unallocated regions.
[ENOMEM] The virtual address range specified by the addr and len are outside the range allowed for the address space.
LEGACY SYNOPSIS
#include <sys/types.h>
#include <sys/mman.h>
int
madvise(caddr_t addr, size_t len, int advice);
int
posix_madvise(caddr_t addr, size_t len, int advice);
The include file <sys/types.h> is necessary. The type of addr has changed.
SEE ALSO
mincore(2), minherit(2), mprotect(2), msync(2), munmap(2), compat(5)
HISTORY
The madvise function first appeared in 4.4BSD. The posix_madvise function is part of IEEE 1003.1-2001 and was first implemented in Mac OS X
10.2.
BSD
June 9, 1993 BSD