Sponsored Content
Top Forums Shell Programming and Scripting Can I improve this script ??? Post 12161 by Cameron on Thursday 20th of December 2001 12:55:25 PM
Old 12-20-2001
Question Can I improve this script ???

Hi all,

Still a newbie and learning as I go ... as you do Smilie
Have created this script to report on disc usage and I've just included the ChkSpace function this morning.

It's the first time I've read a file (line-by-bloody-line) and would like to know if I can improve this script ?

FYI - I created the $1.temp file as it was the only way to remove blank lines that I could find.

Cheers,
Cameron

Code:
TVL-AU: cat daily_df
#!/bin/bash
#######################################################
# >> NOTE: Ensure that you comment ANY amendments. <<
#######################################################
#
# SCRIPT NAME : daily_df
#               Creation of daily volume report.
# ----------------------------------------------------
# PURPOSE:
# This macro is intended to be run via CRONTAB every
# evening at 23:55.
#
# ----------------------------------------------------
# AMENDMENTS:
# -DATE- -VER- -WHO- - COMMENTS                      -
# 281101  001   CJY  Initial script.
# 211201  002   CJY  Check mounts and send an email if
#                    any mount reaches 95% if disc
#                    space.
# 241201  003   CJY  Improvements to script.
#
# ----------------------------------------------------
# >> NOTE: Ensure that you comment ANY amendments. <<
#######################################################

# - Environment setup ----------------------------------#

## File location/assignments.
  xdfdir=/amadeus_stats/disc/
  xdfThold=95        # %Threshold required to send email.
  xemail="tvl_ops_reports@???.com.au"
##xemail="cyoung@???.com.au"
  xemailsub="WARNING: Everest-AU Space Shortage."

# - Functions ------------------------------------------#
#
function ChkSpace {

  toobig=0
  grep "/" $1 > $1.temp

  while read f1 f2 f3 f4 f5 xspc ; do
    xspc=${xspc%%%}
    if [ $xspc -ge $xdfThold ] ; then
        toobig=$toobig+1
    fi
  done < $1.temp

  if [ $toobig -gt 0 ] ; then
    # Send email of mount
    mail -s "$xemailsub" $xemail << -END
               THERE ARE MOUNTS SHORT OF SPACE.
     System Performance will be affected if not investigated.
----------------------------------------------------------------------
`cat $1`
----------------------------------------------------------------------
 End-of-Message.
-END
  fi

  rm $1.temp

}  ## End-of-function ChkSpace

# - START-OF-SCRIPT ------------------------------------#
##

set `date '+%Y %b %d'`

if ! [ -d $xdfdir$2$1 ]; then
  echo "Creating New Directory ... "$xdfdir$2$1
  mkdir $xdfdir$2$1
  chown operator:group $xdfdir$2$1
  chmod 744 $xdfdir$2$1

  ## Remove files older than 1 yr.
  find $xdfdir/???20?? -name \*\_df -mtime +366 -type f -exec rm {} \;
  ## Remove directories older than 1 yr.
  find $xdfdir -name ???20?? -mtime +366 -type d -exec rm {} \;
fi

df -v > $xdfdir$2$1/$2$3\_df
chown operator:group $xdfdir$2$1/$2$3\_df
chmod 644 $xdfdir$2$1/$2$3\_df

ChkSpace $xdfdir$2$1/$2$3\_df

##
# - END-OF-SCRIPT --------------------------------------#


Last edited by Cameron; 12-24-2001 at 09:57 AM..
 

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Any way to improve performance of this script

I have a data file of 2 gig I need to do all these, but its taking hours, any where i can improve performance, thanks a lot #!/usr/bin/ksh echo TIMESTAMP="$(date +'_%y-%m-%d.%H-%M-%S')" function showHelp { cat << EOF >&2 syntax extreme.sh FILENAME Specify filename to parse EOF... (3 Replies)
Discussion started by: sirababu
3 Replies

2. Shell Programming and Scripting

Improve the performance of a shell script

Hi Friends, I wrote the below shell script to generate a report on alert messages recieved on a day. But i for processing around 4500 lines (alerts) the script is taking aorund 30 minutes to process. Please help me to make it faster and improve the performace of the script. i would be very... (10 Replies)
Discussion started by: apsprabhu
10 Replies

3. Shell Programming and Scripting

Want to improve the performance of script

Hi All, I have written a script as follows which is taking lot of time in executing/searching only 3500 records taken as input from one file in log file of 12 GB Approximately. Working of script is read the csv file as an input having 2 arguments which are transaction_id,mobile_number and search... (6 Replies)
Discussion started by: poweroflinux
6 Replies

4. UNIX for Dummies Questions & Answers

[please] improve my shell/SQL*Plus script

Hi We generate with PL/SQL *.csv files, archive them and mail to the customer. Here is my script (Solaris 10, ksh): #!/bin/ksh # Unix Shell Script Structure for PL/SQL queries with SQL*Plus . ~/.profile scriptdir=/opt/ora/scripts queryname1=example... (1 Reply)
Discussion started by: slashdotweenie
1 Replies

5. Shell Programming and Scripting

Var Check Script (Help improve if possible)

I am working on a script to check the var on all of my systems. Can someone help me fix it to work better or give me suggestions. #!/bin/ksh IN=/path/to/list_of_workstations.txt while read hostnames do if ping $hostnames 1 | grep alive > /dev/null then percent=`ssh -q... (3 Replies)
Discussion started by: whotippedmycow
3 Replies

6. UNIX for Dummies Questions & Answers

How to improve the performance of this script?

Hi , i wrote a script to convert dates to the formate i want .it works fine but the conversion is tkaing lot of time . Can some one help me tweek this script #!/bin/bash file=$1 ofile=$2 cp $file $ofile mydates=$(grep -Po '+/+/+' $ofile) # gets 8/1/13 mydates=$(echo "$mydates" | sort |... (5 Replies)
Discussion started by: vikatakavi
5 Replies

7. Shell Programming and Scripting

Improve sftp script

Dear all, I have written two scripts to transfer files to another server outside the company. One is a batch script , and the other script calls the batch script, send the files and archive the file sent. The problem is, that I want to get the list of files which have been uploaded the the... (10 Replies)
Discussion started by: arrals_vl
10 Replies

8. Shell Programming and Scripting

How to improve an script?

Gents. I have 2 different scripts for the same purpose: raw2csv_1 Script raw2csv_1 finish the process in less that 1 minute raw2csv_2 Script raw2csv_2 finish the process in more that 6 minutes. Can you please check if there is any option to improve the raw2csv_2. To finish the job... (4 Replies)
Discussion started by: jiam912
4 Replies

9. Shell Programming and Scripting

Improve script and get new output file

Gents, Using the following script, I got the changes as desired in the output file called (spread_2611.x01.new). Complete file as input (spread_2611.x01). Can you please have a look to my script and improve it please. :b: Also I would like to I get a additional selecting only the records... (21 Replies)
Discussion started by: jiam912
21 Replies

10. Shell Programming and Scripting

Improve script

Gents, Is there the possibility to improve this script to be able to have same output information. I did this script, but I believe there is a very short code to get same output here my script awk -F, '{if($10>0 && $10<=15) print $6}' tmp1 | sort -k1n | awk '{a++} END { for (n in a )... (23 Replies)
Discussion started by: jiam912
23 Replies
GIT-STRIPSPACE(1)						    Git Manual							 GIT-STRIPSPACE(1)

NAME
git-stripspace - Remove unnecessary whitespace SYNOPSIS
git stripspace [-s | --strip-comments] git stripspace [-c | --comment-lines] DESCRIPTION
Read text, such as commit messages, notes, tags and branch descriptions, from the standard input and clean it in the manner used by Git. With no arguments, this will: o remove trailing whitespace from all lines o collapse multiple consecutive empty lines into one empty line o remove empty lines from the beginning and end of the input o add a missing to the last line if necessary. In the case where the input consists entirely of whitespace characters, no output will be produced. NOTE: This is intended for cleaning metadata, prefer the --whitespace=fix mode of git-apply(1) for correcting whitespace of patches or files in the repository. OPTIONS
-s, --strip-comments Skip and remove all lines starting with comment character (default #). -c, --comment-lines Prepend comment character and blank to each line. Lines will automatically be terminated with a newline. On empty lines, only the comment character will be prepended. EXAMPLES
Given the following noisy input with $ indicating the end of a line: |A brief introduction $ | $ |$ |A new paragraph$ |# with a commented-out line $ |explaining lots of stuff.$ |$ |# An old paragraph, also commented-out. $ | $ |The end.$ | $ Use git stripspace with no arguments to obtain: |A brief introduction$ |$ |A new paragraph$ |# with a commented-out line$ |explaining lots of stuff.$ |$ |# An old paragraph, also commented-out.$ |$ |The end.$ Use git stripspace --strip-comments to obtain: |A brief introduction$ |$ |A new paragraph$ |explaining lots of stuff.$ |$ |The end.$ GIT
Part of the git(1) suite Git 2.17.1 10/05/2018 GIT-STRIPSPACE(1)
All times are GMT -4. The time now is 02:52 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy