Until loop


 
Thread Tools Search this Thread
Top Forums UNIX for Dummies Questions & Answers Until loop
# 1  
Old 03-16-2009
Until loop

Hi

I just want to know if this until loop is write because my script is not working and I don't know where is my error and maybe it's in this until cicle

until [ ! `cat svn.txt` -eq $pname ]
do

...
done

So basicly I want to know if I can execute that command (cat svn.txt) and if the syntax is write

Thanks in advance
# 2  
Old 03-16-2009
Did you try a trace with set -x? If so, was there anything unusual about it?
By the way, wouldn't it be more readable to write the loop as
Code:
while [[ "`cat svn.txt`" -eq "$pname" ]]
do
...
done

# 3  
Old 03-16-2009
Quote:
Originally Posted by pludi
Did you try a trace with set -x? If so, was there anything unusual about it?
By the way, wouldn't it be more readable to write the loop as
Code:
while [[ "`cat svn.txt`" -eq "$pname" ]]
do
...
done

well it gave me the same error. I will post my script, not because I want you to solve it for me but because I already trying this since last week and as a new guy where I need a lot of help
__________________________________________
Code:

#!/bin/sh

user=`whoami`
pname="svn `whoami`"
var=0

LOGFILE=`mktemp -t svn_checkout.XXXXXX`
ICONPATH="`dirname $0`/svn.xpm"
list=`ssh $user@192.168.1.3 "ls /esp-server/svn"`
URL=`zenity --entry --title="Subversion: Checkout" --text="$list

Enter repository folder according to the the aboves:" --entry-text="" --width=400 --window-icon="$ICONPATH" 2>&1`

#So until where is everything ok and my script work as I want. The problem was when #I wanted to add a progress bar to my script

if [ $? -eq 0 ]
then
  svn checkout svn+ssh://$user@192.168.1.3/esp-server/svn/$URL &> $LOGFILE & pid1=$!
  zenity --progress --pulsate --auto-kill & pid2=$!
  
  while [ $var -lt 1 ]
  do
    ps aux | awk '{ print $11 " " $1 }' | grep svn > svn.txt    
    
#until where is also ok

    infile=`cat svn.txt`
    echo $infile
    until [[ "`cat svn.txt`" -eq "$pname" ]]
    do
#then when it enters where I'm not sure if it works. Like, I know it goes inside the until #because the echo in the next lines are "echoed", but the until never stops and thats #very confusing because my condition is until "`cat svn.txt`" -eq "$pname" and after the svn command is done, the svn.txt is empty and so 
#[["`cat svn.txt`" -eq "$pname" ]] is true and so should go out from the until
    echo $infile
    echo $pname
    
    ps aux | awk '{ print $11 " " $1 }' | grep svn > svn.txt ;
    
    
    done

    $var=2   #this is for exit the while 
    kill $pid2 # and this to kill the progress bar
    
      
    
  done
  rm -f svn.txt
  rm -f $LOGFILE

fi

and by the way, my verbose says error line 44 which is the last if. why


Please help
thanks in advance

Last edited by ruben.rodrigues; 03-16-2009 at 05:59 AM..
# 4  
Old 03-16-2009
First, please edit your post and put [ code][/code ] tags around your source and reformat it properly.

Second, if you want the loop to run until svn.txt is empty again, why do you compare it with the contents of the $pname variable? If you want to find the contents of $pname in the file, use
Code:
while [[ grep -q $pname svn.txt ]]

which will do a "quite" grep, meaning only $? (the exit code) will be set.
# 5  
Old 03-16-2009
Quote:
Originally Posted by pludi
First, please edit your post and put [ code][/code ] tags around your source and reformat it properly.

Second, if you want the loop to run until svn.txt is empty again, why do you compare it with the contents of the $pname variable? If you want to find the contents of $pname in the file, use
Code:
while [[ grep -q $pname svn.txt ]]

which will do a "quite" grep, meaning only $? (the exit code) will be set.
worst. now it kill me the bar before it finishs
just tell me one thing if you know

I have a second script that looks more simple

Code:
#!/bin/sh


user=`whoami`
pname="svn `whoami`"
var=0

LOGFILE=`mktemp -t svn_checkout.XXXXXX`
ICONPATH="`dirname $0`/svn.xpm"
list=`ssh $user@192.168.1.3 "ls /esp-server/svn"`
URL=`zenity --entry --title="Subversion: Checkout" --text="$list

Enter repository folder according to the the aboves:" --entry-text="" --width=400 --window-icon="$ICONPATH" 2>&1`

if ($? == 0) then
  svn checkout svn+ssh://$user@192.168.1.3/esp-server/svn/$URL &> $LOGFILE
  zenity --progress --pulsate --auto-kill & pid=$!
  echo "`ps aux | awk '{ print $11 " " $1 }' | grep svn`"
  echo "before while"
  while [ "`ps aux | awk '{ print $11 " " $1 }' | grep svn`" -eq "svn ruben"]
  do    
    echo "`ps aux | awk '{ print $11 " " $1 }' | grep svn`"
    echo "I'm inside the while"
  done
  kill $pid
fi

echo "end"

but when I execute it gives me this

Checkout2: 26: 0: not found
end

# the end is from the echo and the line 26 is the fi
Why man? like I think that my only error
 
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

For loop or while loop from a text file

Hi all, i developed a script to measure the uptime of a process in a Solaris 10/11 environments. All is well, but i came across a situation where there are multiple processes of the same name. Basically i have the following result file: beVWARS 13357 19592122 beVWARS 14329 19591910... (4 Replies)
Discussion started by: nms
4 Replies

2. Shell Programming and Scripting

awk loop using array:wish to store array values from loop for use outside loop

Here's my code: awk -F '' 'NR==FNR { if (/time/ && $5>10) A=$2" "$3":"$4":"($5-01) else if (/time/ && $5<01) A=$2" "$3":"$4-01":"(59-$5) else if (/time/ && $5<=10) A=$2" "$3":"$4":0"($5-01) else if (/close/) { B=0 n1=n2; ... (2 Replies)
Discussion started by: klane
2 Replies

3. Shell Programming and Scripting

Reset while loop to loop same file multiple times

Hi, I want to read file multiple times. Right now i am using while loop but that is not working. ex. While read line do while read line2 do echo stmt1 #processing some data based on data., done < file2.txt done < file1.txt # This will have 10... (4 Replies)
Discussion started by: tmalik79
4 Replies

4. Shell Programming and Scripting

Array Variable being Assigned Values in Loop, But Gone when Loop Completes???

Hello All, Maybe I'm Missing something here but I have NOOO idea what the heck is going on with this....? I have a Variable that contains a PATTERN of what I'm considering "Illegal Characters". So what I'm doing is looping through a string containing some of these "Illegal Characters". Now... (5 Replies)
Discussion started by: mrm5102
5 Replies

5. Shell Programming and Scripting

My for loop decides to become an infinite loop?

Hi, I was debating if I should put this in the dummies or scripts section, I apologize in advance if I chose poorly. Fairly new to Unix and BASH scripting but I thought I made it fairly well given my limited understanding. However, the output indicates that it's looping and I'm ending up with a... (5 Replies)
Discussion started by: gotreef
5 Replies

6. Shell Programming and Scripting

S# in a for loop - concatenate $(loop counter)

Hi, hope I am posting in the right section. My problem is that I have 2 or more arguments passed and I want to check if the arguments passed exists or not. The first argument should not exist and the remaining others should exist. example: ./shells.sh argument1 argument2 argument3 ... (5 Replies)
Discussion started by: fight4love
5 Replies

7. Shell Programming and Scripting

BASH loop inside a loop question

Hi all Sorry for the basic question, but i am writing a shell script to get around a slightly flaky binary that ships with one of our servers. This particular utility randomly generates the correct information and could work first time or may work on the 12th or 100th attempt etc !.... (4 Replies)
Discussion started by: rethink
4 Replies

8. Shell Programming and Scripting

Null Handling in Until loop. . .loop won't stop

Hi Im running this script, which is supposed to find the max value build some tables and then stop running once all the tables are built. Thing is , it keeps assigning a null value to $h and then $g is null so it keep building tables i.e. testupdateNUL. How can I stop this? Here is what I have: ... (4 Replies)
Discussion started by: brandono66
4 Replies

9. Shell Programming and Scripting

Using variables created sequentially in a loop while still inside of the loop [bash]

I'm trying to understand if it's possible to create a set of variables that are numbered based on another variable (using eval) in a loop, and then call on it before the loop ends. As an example I've written a script called question (The fist command is to show what is the contents of the... (2 Replies)
Discussion started by: DeCoTwc
2 Replies

10. Shell Programming and Scripting

Is there a better way I could have run this loop. (For loop with two variables)

Sorry for such a dreadful title, but I'm not sure how to be more descriptive. I'm hoping some of the more gurutastic out there can take a look at a solution I came up with to a problem, and advice if there are better ways to have gone about it. To make a long story short around 20K pieces of... (2 Replies)
Discussion started by: DeCoTwc
2 Replies
Login or Register to Ask a Question