while do done loop problem


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting while do done loop problem
# 1  
Old 12-17-2008
while do done loop problem

Code:
#!/bin/sh
findit=`find . -name "a.log" | wc -l`
if [ $findit -eq 0 ]; then
   touch a.log
fi
iCOUNT=`grep ERROR a.log | wc -l`
while (1)
do
   fCOUNT=`grep ERROR b.log | wc -l`
   if [ ${fCOUNT} -gt ${iCOUNT} ]; then
      echo "1"
   else
      echo "0"
   fi
done

Hi ,

I am trying to run the above mentioned script, but it is giving infinite response "1". It is not coming out of the loop.

please advice
# 2  
Old 12-17-2008
It is an infinite loop. There is no break in that loop.
You may break the loop by checking some condition.

And I don't understand why a loop is required there.
Pls let us know what is the requirment.
# 3  
Old 12-17-2008
Actually I am trying to make a script that will scan for the errors in the log file. It will compare the previous count of the errors found in the last count with the current count of errors in the present scan. If the current count is more than the previous count , then it will echo "1".
# 4  
Old 12-17-2008
am still not clear with the requirment.

Code:
#!/bin/sh
if [  ! -f a.log ]; then
   touch a.log
fi
iCOUNT=`grep -c ERROR a.log`

fCOUNT=`grep -c ERROR b.log`

if [ ${fCOUNT} -gt ${iCOUNT} ]; then
   echo "1"
else
   echo "0"
fi

Try above code
# 5  
Old 12-17-2008
YES !! it worked.

Now this script will be run again after few minutes again.
At this time we need to take count in the fCOUNT in the last scan. This will be taken as the previous count of errors. We will again scan the file and will count the errors again and this new count will be fCOUNT.

Means the fCOUNT in the last count has become iCOUNT. This iCOUNT will be compared with the new fCOUNT.

Code:
#!/bin/sh
if [  ! -f a.log ]; then
   touch a.log
fi
iCOUNT=`grep -c ERROR a.log`

fCOUNT=`grep -c ERROR b.log`

if [ ${fCOUNT} -gt ${iCOUNT} ]; then
   echo "1"
else
   echo "0"
fi

$fCOUNT > c.log
exit

something like this. We have to compare again & again the previous count because new logs are getting added repeatedly and consequently new errors will be there .
# 6  
Old 12-17-2008
kindly advice ...how to proceed further ??
# 7  
Old 12-17-2008
need to confirm few things.
For the first time:

(1) from which file fcount should be picked up?
(2) from which file icount should be picked up?

For sub sequent run:

(1) from which file fcount should be picked up?
(2) from which file icount should be picked up?
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Problem with loop

Hi all, a problem with a loop. Imagine it starts with var1="$(cat txtif.out )"while do echo file1 echo file2 echo y > txtif.out if then break fi done exit 0 the problem is that if the file is changing during the loop seems to continue as it reads "x" state,... (5 Replies)
Discussion started by: Board27
5 Replies

2. Shell Programming and Scripting

Problem with While Do loop

I am trying to do a while do loop that asks for a password and returns if the password entered is incorrect. I have that part working however i want to modify it so that if a similar word is entered it will read "that is close but incorrect" and i cannot seem to get it working, being new in the... (6 Replies)
Discussion started by: lm5522
6 Replies

3. Shell Programming and Scripting

Problem with loop within loop

Hi, I work on Ab-initio ETL tool which is based on Unix. I made a small script which has two loop's one with in another. All the functionality is working for the first line of outer loop but when it comes to other lines of outer loop it is throwing error as command not found. Below is the... (4 Replies)
Discussion started by: Ravindra Swan
4 Replies

4. Shell Programming and Scripting

Problem with While loop.

Hi Script Gurus, I am facing issue with while loop in bash. The while loop is running as end less loop even after given criteria does not meet. STATE_BEFORE_SPLIT () { for clone in $Clonegroups; do state=$( $Navicmd -listclone -name $clone -cloneid $Cloneid |awk... (3 Replies)
Discussion started by: RobP
3 Replies

5. UNIX for Dummies Questions & Answers

While loop problem

I have a while loop with -f and -o option.Can any one please tell me what that stands for?The Sample code is as follows:- while do ## some processing done (10 Replies)
Discussion started by: Param0073
10 Replies

6. Shell Programming and Scripting

problem with while loop

hi I had created a while loop in a script file called whiletest.sh as follows as follows: count=0 max=10 while do echo $count echo count=$(count+1)" " done echo "value of count:$count" then i run the script with the command sh whilestest.sh but its giving me an error... (5 Replies)
Discussion started by: angel12345
5 Replies

7. Shell Programming and Scripting

Problem in While loop

Hi Guys, This is my code.. I am getting an error in the inside while statement when comparing.. I am not able to figure it out.. Pls help me... while read value fatherid son_id top_id r_type do inside_value=1; echo $inside_value; echo $r_type; while do echo... (6 Replies)
Discussion started by: mac4rfree
6 Replies

8. UNIX for Advanced & Expert Users

loop problem

Hi guys my while do loop is not working properly; As soon as the load_date and run_date is same it should stop can somebody tell me where I am having the problem? In an oracle table I have LOAD_DT=5/1/2009 DATE datatype RUN_DT=5/5/2009 DATE datatype Now in a script with a spool file I get the... (15 Replies)
Discussion started by: henrysmith
15 Replies

9. Shell Programming and Scripting

for loop problem

Hi, I have a directory called logs in which i have the log files. i have to touch the file before deleting it. i am doing like this filestodelete="*.log* *log*" for files in $filestodelete do touch $files $files.$(date +%a) rm -f $filestodelete done touch is not working... (5 Replies)
Discussion started by: namishtiwari
5 Replies

10. Programming

problem with while loop

hi all, i have written the following code: while(proceed !='Y' && proceed!='N' && proceed!='y' && proceed!='n') { printf("\nPress \n\t 'Y' or 'y' to continue \n\t 'N' or 'n' to cancel:"); scanf("%c",&proceed); } the output i am gettin is: Press 'Y' to continue ... (1 Reply)
Discussion started by: mridula
1 Replies
Login or Register to Ask a Question