Shell Programming and Scripting

Hi guys,

Newbe in scripting /bin/ksh I'm needing some help.
Working on : SunOS I386 Solaris5.10

Here is the idea:

I would like to create a function that will show only a part of the command df -h with sed.
The aim is to see only the disk name and the pourcentage of it. (eg"c0t0d0s0 / 70%")

In my full script I had the command and it's working well.
echo "toto" `df -h /|grep %| sed -e 's/[0-9].[0-9]G//g' -e 's/[0-9].[0-9]M//g' -e 's/[0-9]G//g' -e 's/[0-9]M//g' -e 's#/dev/dsk/#/#g'` "\n" >> $LOG &&

I would like to create a function that will take those command.

But I should have some mistakes in because i cannot make it work. Does someone have an idea? thank


Here is my script

#!/bin/ksh
#
DATE=`date '+%y%m%d%H%M'`
LOG=/var/log/autosed$DATE.log
export LOG
DEBUG=echo

#function that permit to sow a part of the df -h command.

call_sed()
{
sedcmd=`grep % | sed -e 's/[0-9].[0-9]G//g' -e 's/[0-9].[0-9]M//g' -e 's/[0-9]G//g' -e 's/[0-9]M//g' -e 's#/dev/dsk/#/#g'` >> $LOG
df -h $1 | $sedcmd
}
call_sed "/"

Your sedcmd command variable is enclosed in back ticks sedcmd=`some commands` which will set sedcmd value to the result of the execution of some commands. Instead use forward ticks(single quotes) to preserve the string value of the commands you want to execute on the next line.

sedcmd='some commands'

You are assigning the output of a command to $sedcmd instead of the command itself.

Don't make your script more complex than it need be:

Code:

call_sed()
{
  df -h $1 |
   grep % | sed -e 's/[0-9].[0-9]G//g' \
                -e 's/[0-9].[0-9]M//g' \
                -e 's/[0-9]G//g' \
                -e 's/[0-9]M//g' \
                -e 's#/dev/dsk/#/#g' >> "$LOG"
}

Hi guys,

Thank you both very much. I'm starting and you help me a lot.

Here is the result of the script with your help :

#!/bin/ksh
#
DATE=`date '+%y%m%d%H%M'`
LOG=/var/log/autosed$DATE.log
export LOG

call_sed()
{
df -h $1 |
grep % |
awk '{print $1" "$5" "$6}'|
sed -e 's#/dev/dsk/#/#g' >> "$LOG"
}
call_sed "/"
call_sed "/var"