PERL script help


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting PERL script help
# 1  
Old 08-30-2005
PERL script help

Hi all

I wrote this, and am very new to PERL. Could someone show me what i might be doing wrong?? Here is my code:

open(DATA1,"ping1.txt");
open(DATA2,"ping2.txt");

$data1 = <DATA1>;
$data2 = <DATA2>;

while ($data1 || $data2) {
next if !strcmp($data1,$data2);
print "<DATA1";
print ">DATA2";

$data1= <DATA1>;
$data2= <DATA2>;

}

basically, i am running a ping and putting the results into a file. What I want to do is compare the 2 largest files and annotate the differences (if any)

the error i get is: undefined subroutine &main::strcmp called at filename.pl <DATA2> chunk1

SO I thought, hmm subroutine. So I tried declaring one before the next if before the { but I received even more errors.

But now I am lost...can anyone provide me some help?

Thanks

Joe

Last edited by caddyjoe77; 08-30-2005 at 03:18 PM..
# 2  
Old 08-30-2005
Unlike C, perl does not have a function called strcmp. To compare two strings, you just have to do this:
Code:
if($data1==$data2) {
--do whatever you want here--
}
else {
--do something else here--
}

# 3  
Old 08-30-2005
strcmp in perl is

if( $data1 eq $data2 ){

}else{

}
# 4  
Old 08-30-2005
Quote:
Originally Posted by photon
strcmp in perl is

if( $data1 eq $data2 ){

}else{

}

Interesting, I sorta found that out, but at first I was using != for not equal. Error city. Anyway, so that is how my script looks. However, all that is output now is

<
>
<
>
<
>

Here is what my script looks like now:

open(DATA1,"ping1.txt");
open(DATA2,"ping2.txt");

$data1 = <DATA1>;
$data2 = <DATA2>;

while ($data1 || $data2) {
if ($data1 ne $data2) {

else print "<$data1";
print ">$data2";
}

$data1= <DATA1>;
$data2= <DATA2>;

}

Like I said, all i get now is
<
>
<
>
in a repeating pattern that never ends. Should I put an EOF in there somewhere? Another question is I KNOW the files are different because i made some changes to test them

I know I am overlooking something here...

Thank You for your inputs. Smilie

Joe
# 5  
Old 08-30-2005
Your code seems to work for me with slight modifications, but give me some weird results at the end.

Try chomping the lines retrieved first before throwing to while {}, and unlike C/Java you always need the braces for blocks like if-else/for even if the block consists of only one statement. This is likely to work better I think:

Code:
open(DATA1,"ping1.txt");
open(DATA2,"ping2.txt");
 
chomp( $data1 = <DATA1>);
chomp( $data2 = <DATA2>);
 
while ($data1 || $data2) {
   if ($data1 ne $data2) {
       print "<$data1\n";
       print ">$data2\n";
   }
 
   chomp($data1= <DATA1>);
   chomp($data2= <DATA2>);
 
 }

# 6  
Old 08-31-2005
Perfect

Thanks!! That works perfectly.

Yes, I am new to perl..lol similar to C but different at the same time.

Smilie
# 7  
Old 08-31-2005
In shell, you can use diff instead.

diff is so powerful.

relative cmd like : paste, comm, join ....
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

PERL: In a perl-scripttTrying to execute another perl-script that SETS SOME VARIABLES !

I have reviewed many examples on-line about running another process (either PERL or shell command or a program), but do not find any usefull for my needs way. (Reviewed and not useful the system(), 'back ticks', exec() and open()) I would like to run another PERL-script from first one, not... (1 Reply)
Discussion started by: alex_5161
1 Replies

2. Shell Programming and Scripting

Excuting perl script from within a perl script with variables.

Not sure what I am doing wrong here, but I can print the list with no issue. Just a blank screen with the 'do'. #!/usr/bin/perl open FILE, "upslist.txt"; while ($line=<FILE>){ if ($line=~/^(.*?),(.*?)$/){ #print "ups:$1 string:$2\n"; do 'check_snmp_mgeups-0.1.pl -H $1 -C $2'; } ... (1 Reply)
Discussion started by: mrlayance
1 Replies

3. Shell Programming and Scripting

Perl : embedding java script with cgi perl script

Hi All, I am aware that html tags can be embedded in cgi script as below.. In the same way is it possible to embed the below javascript in perl cgi script ?? print("<form action="action.htm" method="post" onSubmit="return submitForm(this.Submitbutton)">"); print("<input type = "text"... (1 Reply)
Discussion started by: scriptscript
1 Replies

4. Shell Programming and Scripting

executing perl script from another perl script : NOT WORKING

Hi Folks, I have 2 perl scripts and I need to execute 2nd perl script from the 1st perl script in WINDOWS. In the 1st perl script that I had, I am calling the 2nd script main.pl =========== print "This is my main script\n"; `perl C:\\Users\\sripathg\\Desktop\\scripts\\hi.pl`; ... (3 Replies)
Discussion started by: giridhar276
3 Replies

5. Shell Programming and Scripting

calling a perl script with arguments from a parent perl script

I am trying to run a perl script which needs input arguments from a parent perl script, but doesn't seem to work. Appreciate your help in this regard. From parent.pl $input1=123; $input2=abc; I tried calling it with system("/usr/bin/perl child.pl $input1 $input2"); and `perl... (1 Reply)
Discussion started by: grajp002
1 Replies

6. Shell Programming and Scripting

HELP on Perl array / sorting - trying to convert Korn Shell Script to Perl

Hi all, Not sure if this should be in the programming forum, but I believe it will get more response under the Shell Programming and Scripting FORUM. Am trying to write a customized df script in Perl and need some help with regards to using arrays and file handlers. At the moment am... (3 Replies)
Discussion started by: newbie_01
3 Replies

7. Shell Programming and Scripting

Perl :How to print the o/p of a Perl script on console and redirecting same in log file @ same time.

How can i print the output of a perl script on a unix console and redirect the same in a log file under same directory simultaneously ? Like in Shell script, we use tee, is there anything in Perl or any other option ? (2 Replies)
Discussion started by: butterfly20
2 Replies

8. Shell Programming and Scripting

perl/unix: script in command line works but not in perl

so in unix this command works works and shows me a list of directories find . -name \*.xls -exec dirname {} \; | sort -u | > list.txt but when i try running a perl script to run this command my $query = 'find . -name \*.xls -exec dirname {} \; | sort -u | > list.txt';... (2 Replies)
Discussion started by: kpddong
2 Replies

9. Shell Programming and Scripting

[Perl] Accessing array elements within a sed command in Perl script

I am trying to use a script to replace the header of each file, whose filename are stored within the array $test, using the sed command within a Perl script as follows: $count = 0; while ( $count < $#test ) { `sed -e 's/BIOGRF 321/BIOGRF 332/g' ${test} > 0`; `cat 0 >... (2 Replies)
Discussion started by: userix
2 Replies

10. Shell Programming and Scripting

Perl: Run perl script in the current process

I have a question regarding running perl in the current process. I shall demonstrate with an example. Look at this. sh-2.05b$ pwd /tmp sh-2.05b$ cat test.sh #! /bin/sh cd /etc sh-2.05b$ ./test.sh sh-2.05b$ pwd /tmp sh-2.05b$ . ./test.sh sh-2.05b$ pwd /etc sh-2.05b$ So... (10 Replies)
Discussion started by: vino
10 Replies
Login or Register to Ask a Question