Shell Programming and Scripting

All,
I have a Bash SFTP script that I run and before I would hardcode the file name.

I recently decided to put the filename in a variable called $FILENAME.

I had 2 scripts that run at the same time and it seems like in the middle of one of the scripts the variable called the other scripts $FILENAME for my put command.

So, my question is, aren't the variables in a script supposed to be local to the script? At the beginning of the script the variable was fine, but then the put command put the wrong file. See below, the variable $FILENAME switched from CQ12345 to CT12345 in the middle of the script. The other script I run at the same time's variable in CT12345

Script they both run except the FILENAME variable is different:

Code:

FILENAME=CQ12345
ARCHLOC=
LOGFILE=
GETDATE=`date`


#    echo start date to log

echo "Started script at $GETDATE" >> $LOGFILE

if [ "$(find $ORIGLOC/$FILENAME -type f)" ]; then

#    List files out to log

echo " The following file was found and is about to be transferred..." >> $LOGFILE

ls -l $ORIGLOC/$FILENAME >> $LOGFILE

#    Copy files to archive location

cp -pv $ORIGLOC/$FILENAME $ARCHLOC >> $LOGFILE

#    Copy files to new location

cd $ORIGLOC
echo cd INBOUND > /tmp/sftp.sftp
echo put $FILENAME >> /tmp/sftp.sftp
echo bye >> /tmp/sftp.sftp
sftp -b /tmp/sftp.sftp $DESTUSER@$DESTSERV >> $LOGFILE

Log

Code:

 The following file was found and is about to be transferred...
-rwx------ 1 root root 103675 Nov 26 11:56 /CQ12345
`CQ12345' -> `CQ12345'
sftp> cd INBOUND
sftp> put CT12345
Uploading CT12345 to /INBOUND/CT12345
sftp> bye

Do you have glob turned off? Are the filenames on disk really CQ******?

Normal syntax would be

Code:

FILENAME=CQ*

to find files starting with "CQ"

or CQ?????? to find a file starting with CQ that has any six characters after CQ

Jim, sorry I shouldn't have used **** I was just using that as a comment out for the rest of the characters of the file name. It is something like CQ12345 and the other file is CT12345. My SFTP scripts pull these files from the same directory, but both are separate scripts. One has filename set to CQ12345 and the other CT12345. They execute on the same cron schedule.

If you look at the log, it finds the CQ file, but then when it ran the put command it used the CT file name instead of the CQ file name. Maybe I had it hardcoded still at that portion instead of the $FILENAME as I copied it from my original script and then edited? Could be programmer error, but i'm pretty sure I had $FILENAME right after the put command when I looked it. I know for sure it has it now.

I'm not sure how to check if glob is turned off/on. It is running RHEL 5.5 so whatever the default for that is.

I just wanted to be sure that the variable should stay local to that script. That assumption should be correct right? I can run some tests with echo when I get back in office.

---------- Post updated 12-01-10 at 10:43 AM ---------- Previous update was 11-30-10 at 01:08 PM ----------

I just realized the problem. The temp file I wrote the SFTP commands to that the sftp -b would read from had the same name. So, when they executed at the same time. It overwrote it with the other file names.

Programmer error!