What is on Your Mind?

07-05-2018

Administrator

19,118, 3,359

Join Date: Sep 2000

Last Activity: 15 July 2022, 8:51 AM EDT

Location: Asia Pacific, Cyberspace, in the Dark Dystopia

Posts: 19,118

Thanks Given: 2,351

Thanked 3,359 Times in 1,878 Posts

Update, FYI:

Just updated GeSHI, that is used for our Advanced Syntax Highlighting plugin to the latest 2017 version (GeSHi 1.0.9.0) and FYI, the AWK filter is installed:

awk code:

BEGIN {
  print "Hello World!"
}

Code:

[highlight=awk]BEGIN {
  print "Hello World!"
}[/highlight]

This User Gave Thanks to Neo For This Post:

Neo

07-08-2018

Administrator

19,118, 3,359

Join Date: Sep 2000

Last Activity: 15 July 2022, 8:51 AM EDT

Location: Asia Pacific, Cyberspace, in the Dark Dystopia

Posts: 19,118

Thanks Given: 2,351

Thanked 3,359 Times in 1,878 Posts

Update:

I'm working on some new code so that when we click on code tags, it toggles between different syntax highlighters (and of course the standard way with no 'lighters).

The problem I am having is that the forum bbcode PHP scripts do not pass in unique post ids for each post and also that even when I get this solved, there is also the issue of each unique code tag block per postid.

Each code tag block must be assigned a unique identifier for onclick() to work, per HTML specs. I am hesitate to assign random or sequential numbers or other ways to do it; but I may do this for only registered users if I cannot come up with a better solution.

Or I may just use unique ints for each thread view somehow..... but my preference is to get the unique post ids into the bbcode div tags and then add some unique ints for each code tag block in the posts div ids like codetag$postid_$blocknumber or something like that.

When I get the unique ids for each bbcode tag solved, then it's a piece of cake to add the JS code and HTML to make it work.

Neo

07-08-2018

Administrator

19,118, 3,359

Join Date: Sep 2000

Last Activity: 15 July 2022, 8:51 AM EDT

Location: Asia Pacific, Cyberspace, in the Dark Dystopia

Posts: 19,118

Thanks Given: 2,351

Thanked 3,359 Times in 1,878 Posts

OK.... The first is done.

Thanks to Don Cragun for this idea!

You can now click on a code tag area and it will toggle back and forth between the original and the new style, now only plain (no coloring) but it's a start. It works on both mobile and on the desktop, but mobile default to the new code highlighter and the desktop defaults to the original code tags;

Code:

<script language="javascript" type="text/javascript">
function switchCodeTags(codeTag) {
    var eleA = codeTag +"a";
    var eleB = codeTag +"b";
    var x = document.getElementById(eleA);
    var y = document.getElementById(eleB);
    if (x.style.display === "none") {
        y.style.display = "none";
        x.style.display = "block";
        
    } else {
        x.style.display = "none";
        y.style.display = "block";
    }
}
</script>

Here is the core PHP code I changed in class_bbcode.php

Code:

if ($this->printable)
                {
                        $code = $this->emulate_pre_tag($code);
                        $template = 'bbcode_code_printable';
                }
                else
                {
                        $blockheight = $this->fetch_block_height($code);
                        $template = 'bbcode_code';
                        $template_neo = 'bbcode_code_neo';
                }
                eval('$html = "' . fetch_template($template, 0, true, true) . '";');
                eval('$html_neo = "' . fetch_template($template_neo, 0, true, true) .'";');
                 $codeRand = (int)$post['postid']+mt_rand();
                 $tagid137 = "neocodetagid137".$codeRand;
                 $tagid137a = "neocodetagid137".$codeRand.'a';
                 $tagid38a = "neocodetagid38".$codeRand.'a';
                 $tagid38 = "neocodetagid38".$codeRand;
                 $tagid137b = "neocodetagid137".$codeRand.'b';
                 $tagid38b = "neocodetagid38".$codeRand.'b';
              //error_log($tagid137a."\n\n", 3, '/tmp/bbcodelog.log');
               if($vbulletin->userinfo['styleid'] == '137')
                {
                $out = '<div style="display:none;" onclick="switchCodeTags(\''.$tagid137.'\')" id="'.$tagid137b.'">'.$html."</div>";
                $out .= '<div onclick="switchCodeTags(\''.$tagid137.'\')" id="'.$tagid137a.'">'.$html_neo."</div>";
                }
               else
               {
                $out = '<div onclick="switchCodeTags(\''.$tagid38.'\')" id="'.$tagid38b.'">'.$html."</div>";
                $out .= '<div  style="display:none;" onclick="switchCodeTags(\''.$tagid38.'\')" id="'.$tagid38a.'">'.$html_neo."</div>";
               }
                return $out;

Right now it only works for our generic code tags:

Code:

 [CODE][/CODE]

But it is a start ...

Please note when you edit a post you will have to refresh the page if you want the toggle'ing to work. I will fix this small bug later.

Neo

View Public Profile for Don Cragun

07-08-2018

Registered User

12,315, 4,560

Join Date: Jul 2012

Last Activity: 22 November 2019, 4:29 PM EST

Location: San Jose, CA, USA

Posts: 12,315

Thanks Given: 952

Thanked 4,560 Times in 3,818 Posts

What am I missing? How do I now copy code that is presented in CODE tags so I can paste it into another window?

It seems that all attempts to select text in a CODE tag now changes the view instead of selecting the text. It also appears that <tab>s in CODE tags are expanded to <space>s (as well as COLOR, ITALIC, BOLD, etc. tags being displayed as text instead of being acted upon) in the view with line numbers.

Being able to copy and paste code seems to me to be a basic requirement for text inside CODE segments in this forum!

Don Cragun

Find all posts by Don Cragun

07-08-2018

Administrator

19,118, 3,359

Join Date: Sep 2000

Last Activity: 15 July 2022, 8:51 AM EDT

Location: Asia Pacific, Cyberspace, in the Dark Dystopia

Posts: 19,118

Thanks Given: 2,351

Thanked 3,359 Times in 1,878 Posts

I'm not following you.

Nothing has changed, you can copy and paste the same as before.

You cannot do it with the new tags, but you can do it with the original tags.

So, am not following you at all, sorry.

Neo

07-08-2018

Administrator

19,118, 3,359

Join Date: Sep 2000

Last Activity: 15 July 2022, 8:51 AM EDT

Location: Asia Pacific, Cyberspace, in the Dark Dystopia

Posts: 19,118

Thanks Given: 2,351

Thanked 3,359 Times in 1,878 Posts

Quote:

Originally Posted by Don Cragun

What am I missing? !

Sorry, I am not understanding this.

I can copy and paste and select no problem at all.

Neo