UNIX for Dummies Questions & Answers

hi,

what i want to do is to convert all the txt file under my directory to the properties file using the native2ascii command.

however, when i run my script, i got bad substitution error. what's wrong with my script ? pls help. thanks

#!/bin/sh

curDIR=`pwd`
oldExt='txt'
newExt='properties'

for i in ${curDIR}/* ; do
/opt/FJSVawjbk/jdk13/bin/native2ascii $i ${i%$oldExt}$newExt
done

You're not really using the 'txt' entension....

for i in ${curDIR}/*${oldExt} ; do

But that shouldn't cause you problems..... I have tried this

curDIR=`pwd`
oldExt='properties'
newExt='herlihy'

for i in ${curDIR}/*${oldExt} ; do
/usr/develop/j2sdk1_3_0_02/bin/sparc/native_threads/native2ascii $i ${i%$oldExt}$newExt
done

And it works.....can you replace your native2ascii command and try a copy command instead to see it that accepts...make sure that you have some files with the oldExt - otherwise there is nothing for the script to do.

hi,

after my investigation, the error comes from the ${i%$oldExt}

let's say my $i is /export/home/pbn/Japanese/AdmissionControl.txt

and i set oldExt='txt'

so why ${i%$oldExt} will give me bad substitution error?

pls help

thanks

${i%$oldExt} is only part of that substitution....

How are you sure that's the problem...??

try -
echo ${i%$oldExt}$newExt
echo ${i%$oldExt}
in your script. What do you get?

hi, thank u for ur patient and help.

now this is my source code:
#!/bin/sh

curDIR=`pwd`
oldExt='txt'
newExt='properties'

for i in ${curDIR}/*${oldExt}; do
echo $i
echo ${i%$oldExt}$newExt
echo ${i%$oldExt}

# /opt/FJSVawjbk/jdk13/bin/native2ascii $i ${i%$oldExt}$newExt
done


this is my directory and runtime result:

pbn@hercules:[260] >ls
AdmissionControl.txt DeviceList.txt DiffServPHB.txt MiscMessages.txt PolicyListView.txt UserManagement.txt
BandWidthControl.txt DeviceManagement.txt DiffservClass.txt NetworkView.txt Provisioning.txt native.sh*
pbn@hercules:[261] >native.sh
/export/home/pbn/Japanese/AdmissionControl.txt
native.sh: bad substitution
pbn@hercules:[262] >

Okay one more thing before I give up and suggest that it's somthing to do with the OS version you are using and get well in over my head....

Does

echo ${i%$oldExt}

Work? I.e just comment out the line that has the $newExt in it.

same thing, same error.