I am using ubuntu. I have written a program to calculate prime factors. it works perfectly fine till entered number is less than 9989 (or so ) but when one enters a number higher than that, for example 15000, it does not work. Can anyone guide me whats the problem ? although new codes are welcome, but i want to know problem with my code. thanks in Advance
Can anyone guide me whats the problem ? although new codes are welcome, but i want to know problem with my code
Fair enough. The first problem, without even looking at what your code does, is obvious: use speaking names for your variables. Instead of juggling around "i", "j", "k", "p" and whatnot, like in good old FORTRAN/77, you should write names which tell you instantly what is in them: numbers, primes, factors, whatever. Not only will that help you with housekeeping, it will help you to concentrate on coding instead of remembering what "i" exactly means now in this function.
My personal favorite in this regard (but that is a matter of taste) is "Hungarian Style Notation" - or at least some personal subset variation of it. I prefix my variables names with a type indicator, which helps remembering this vital fact.
Secondly, regarding your code: the problem you are experiencing is IMHO in the function next_prime(), in this line:
Actually the program does what you told it to do and therefore this loop is interrupted at 9999 (not "9989 (or so )", as you said).
Aside from that your code inefficient to the extreme. Because "2" is a prime you could skip all even numbers and increment i by 2 instead of one, yes? This, btw., could be done with all the other found primes too. This consideration is the basis of the "Sieve of Eratosthenes", which will work for very small numbers like the ones you deal with. For bigger numbers you need better algorithms, like Lucas-Lehmer, Adleman-Pomerance-Rumely, etc..
For a quick introduction to primality tests and their pros and cons start with searching for "Primality Test" in Wikipedia.
Hello,
I am new to C++ programming, so I'm still getting a feel for things. I recently wrote a simple C++ program (to be used as a ROOT Macro) to conduct a statistical analysis of a varied version of the Monty Hall problem (code below). Basically, the programs runs a few simple calculations to... (7 Replies)
hi
in the following code, how the memory is allocated for a1 which holds the values of a2 after cpy function call.
#include <stdio.h>
#include <string.h>
void cpy(char* d, const char* s){
while(*d++=*s++);
}
main(){
char* a1;
char* a2="done";
cpy(a1,a2);
... (3 Replies)
When we dynamically allocate the memory say 100 integers say
int *x = new int(1000);
then does entire chunk of memory gets allocated at once after the completion of the statement?
I mean will the the concept of page fault come into picture over here? (3 Replies)
Hi Experts
I need some help in static memory allocation in C. I have a program in which I declared 2 variables, one char array and one integer. I was little surprised to see the addresses of the variables.
First:
int x;
char a;
printf("%u %u\n', &x, a);
I got the addresses displayed... (2 Replies)
Hi everyone,
I'm not new to C programming, but I'm having question regarding the memory allocation of a pointer variable which, for instance, will be declared in main(), but its memory will be allocated in subroutine.
To clearify my question, I provide a small working example:
#include... (1 Reply)
I have a scenario like the client has to search for the active server.There will be many servers.But not all server are active.And at a time not more than one server will be active.
The client will be in active state always i.e, it should always search for an active server until it gets one.I... (1 Reply)
I have a program that will fetch some particular lines and store it in a buffer for further operations.The code which is given below works but with some errors.I couldn't trace out the error.Can anybody help on this plz??
#include <stdio.h>
#include <stdlib.h>
#include<string.h>
#define... (1 Reply)
Hi,
I am trying to process line by line of a file. But I should not be allocating static allocation for reading the contents of the file. The memory should be dynamically allocated. The confusion here is how do I determine the size of each line, put it into a buffer with the memory allocated... (11 Replies)
Hi all,
I have a HP-UX Server with 4 gigabytes of physical RAM. When I use the 'Glance' utility to see what my memory utilization is, my memory usage shows up maxed out at 99%. I shut off all the known processes that I'm running on that box and the memory utilization is still at 78% (with Swap... (3 Replies)