UNIX for Dummies Questions & Answers

Hi there
can anyone help me why my code is saying Badly placed ()'s.

Code:

#!/bin/csh
if ($#argv != 1) then
echo "One file is required"
exit 1
else
set lines=(`grep '404' $1 | cut -d" " -f5`)
foreach line ($lines)
printf ("Abnormal sites: %s\n", $line)
endif

thanks in advance!

Sigh....

Please, STOP USING C-shell while you still can!

C-shell (csh) is considered outdated, very buggy, unreliable and generally to be avoided. Read this in-depth article instead of taking my word for it.

You might want to consider getting a book on shell programming. I suggest "KornShell Programming Tutorial" (Korn shell 88) or the "Hands-On KornShell93 Programming" (Korn shell 93), both by Barry Rosenberg. Both are phantastic reads, humorous writing along with excellent coverage of the subject.

I hope this helps.

bakunin

PS: there is even a logical flaw in your script: even if your number of arguments is correct you are not guaranteed that the user provided a valid file name. You will have to test if the file exists and is readable (use test -r <filename> for this) before piping it through grep or any other utility.

LOL I would like to but it is a task to write it in C shell

Code:

lines=(`grep '404' $1 | cut -d" " -f5`)

Remove the brackets.

Ahem, ..., i can't imagine a production environment where csh is required these days. Even SAP on AIX have their system users use ksh as shell nowadays and they have probably been the last ones to switch over.

Is this some homework or classwork, i have to ask, therefore? If so, there is a special board for this, where you will be helped. If this is not homework i strongly suggest you inform your managers to have that (outright silly and dangerous) requirement changed instead of supporting such nonsense.

I outright denied any requests to write csh code in the last 5 years and made exceptions only for said SAP-on-AIX combination mentioned above for the ten years before. My career hasn't suffered one bit because of this.

bakunin

Thanks a lot but why in some cases it perfectly accepts it with brackets for e.g for

Code:

task=(`ls`)

---------- Post updated at 12:05 PM ---------- Previous update was at 12:01 PM ----------

Home work in summer??? It is not a home work I am just learning system administration by myself and I don't understand csh at all however, at my work we are required to work with it.

I blame alien mind control for the continued use of this obsolete, flawed, and obnoxious shell despite all alternatives and good sense, but it still happens. We get far too many requests here to hope otherwise. It seems to be a BSD thing.