UNIX for Dummies Questions & Answers

Okay I have a 1TB drive that is almost completely full with vids. I am in the process of converting them to mp4. I have two scripts right now. One is a shell script to convert them with Handbrake. The other is a script to get a sort of progress report. To make things easier to understand, I will show you that one:

Code:

#!/bin/bash

# Get a numerical progress report
file1=`find . -name *.avi | wc -l`
file2=`find . -name *.mkv | wc -l`
file3=`find . -name *.mp4 | wc -l`
total=`expr $file1 + $file2 + $file3`
mp4per=$((file3 * 100))
percen=`expr $mp4per / $total`

# Print progress as a ratio of converted to total
log1="You have encoded "
log2="$file3 out of $total files."
log3="$log1""$log2"

echo $log3

# Print progress as a percentage
dia1="You have encoded $percen"
dia2="% of your files."
dia3="$dia1""$dia2"

echo $dia3

As you can see this code uses the equation: %=(Number of converted vids * 100) ÷ Total number of vids
It prints out the encoding progress in the form of
"You have encoded 1724 out of 2381 of files."
"You have encoded 72% of your files"

Here's the problem: If I keep this script as its own file, it works perfectly. I can even turn it into a subroutine and call it and it works perfectly as long as it is a separate file, BUT if I put the subroutine inside the Handbrake Encode script and call it, it errors out.

I was just hoping I could combine them together for simplicity's sake, and I feel like I am missing something simple. Any ideas?

EDIT: As extra info, when I turn it into a subroutine inside the other script, it errors saying that the file1, file2, and file3 variables are non-numeric arguments.

---------- Post updated at 01:08 PM ---------- Previous update was at 10:29 AM ----------

LOL nvm everyone. I got it. Turns out the command I was using for the variables file1, file2, and file3 was putting a space before the number and it was tripping it up. Changing it to this did the trick:

Code:

#!/bin/bash

# Get a numerical progress report
file1=`find . -name *.avi | wc -l|sed 's/ //g'`
file2=`find . -name *.mkv | wc -l|sed 's/ //g'`
file3=`find . -name *.mp4 | wc -l|sed 's/ //g'`
total=`expr $file1 + $file2 + $file3`
mp4per=$((file3 * 100))
percen=`expr $mp4per / $total`

# Print progress as a ratio of converted to total
log1="You have encoded "
log2="$file3 out of $total files."
log3="$log1""$log2"

echo $log3

# Print progress as a percentage
dia1="You have encoded $percen"
dia2="% of your files."
dia3="$dia1""$dia2"

echo $dia3