Question/review my script: removing bad chars from filenames


 
Thread Tools Search this Thread
Top Forums UNIX for Dummies Questions & Answers Question/review my script: removing bad chars from filenames
# 1  
Old 10-03-2010
Question/review my script: removing bad chars from filenames

The task: remove undesirable characters from filenames.

Restrictions: Must use basic RE, base utilities (non-GNU) and /bin/sh (ash). No ksh, zsh, perl, etc.

Below is what I've come up with. It seems to work OK but I'm open to shorter, more efficient alternatives.

Inside the square brackets I've included an assortment of chars I'd like to remove. But I'm not able to get the following chars inside the square brackets so that they are also removed:

- square brackets
- single quotes (apostrophes)

One solution is to pipe into another sed. But I'd like to avoid that. My version of sed does not accept hex or octal.

Code:
# these are for debugging; they just print out the command line 

nsc(){ 
IFS='
';for j in $@ ;do printf "mv -vi \"$j\" \134 \n \"$j\"\n" $@;done | sed '/ \\ $/!s/[[:cntrl:][:blank:]\(\)\{\}:;,!?+*=<>#@\^|]//g;s/\]//g'  ;}

# problem: does not remove square brackets and single quotes

nsc(){ IFS='
';for j in $@ ;do printf "mv -vi \"$j\" \134 \n \"$j\"\n" $@;done | sed 's/ \\ $/!s/[[:cntrl:][:blank:]\(\)\{\}:;,!?+*=<>#@\^|]//g;s/\]//g;s/\[//g' | sed "s/\'//g;s/\[//g;s/\]//g" ;}

# removes single quotes and square brackets but uses an extra sed

Note: I have tried the "while read" approach but I found that the read builtin required filenames that do not contain illegal characters for variables, such as parentheses.

Last edited by uiop44; 10-04-2010 at 12:02 AM..
# 2  
Old 10-04-2010
This sed works for me to remove all of the 'special' characters including both open/close square braces and the single quote, all in a single sed substitute statement:

Code:
sed 's/[]['\''"!@#$%^&*()`~[:cntrl:][:space:]\t]//g'

By placing the close square bracket immediately following the open character class, it is not interpreted as the end of the character class.

Using the '\'' construct you can "insert" a single quote into the class.

I don't know if I picked up all of the specials that you wish to remove, but you should be able to add what ever I missed.
# 3  
Old 10-04-2010
Quote:
Originally Posted by agama
This sed works for me to remove all of the 'special' characters including both open/close square braces and the single quote, all in a single sed substitute statement:

Code:
sed 's/[]['\''"!@#$%^&*()`~[:cntrl:][:space:]\t]//g'

By placing the close square bracket immediately following the open character class, it is not interpreted as the end of the character class.

Using the '\'' construct you can "insert" a single quote into the class.

I don't know if I picked up all of the specials that you wish to remove, but you should be able to add what ever I missed.
I see an escaped t in your sed command. That tells me you're using a sed that supports more than mine does (e.g., symbols for tabs, newlines, etc. plus octal and hex, if it's the GNU version).

My shell with my sed won't let me escape a single quote if I'm also using single quotes to enclose my sed command sequence.
# 4  
Old 10-04-2010
You can replace \t with the tab character if your sed doesn't support it. I use AT&T's sed from their AST tool set. Also, if [:space:] includes tab (too lazy to look it up tonight), then you don't need it at all.

Does your shell allow this:
Code:
sed 's/[]['"'"'!@#$%^&*()`~[:cntrl:][:space:]        ]//g'

That's a single quote to close, then a single quote inside of double quotes and finally a single quote to reopen.

If this fails then I'm out of suggestions.
# 5  
Old 10-04-2010
Many, many thanks agama!

It all works now.

(Your first solution for the single quote actually works too. I hastily overlooked your single quotes around the forward slash.)

Great stuff. This forum is excellent.

Last edited by uiop44; 10-04-2010 at 04:03 AM..
 
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Shell script to split data with a delimiter having chars and special chars

Hi Team, I have a file a1.txt with data as follows. dfjakjf...asdfkasj</EnableQuotedIDs><SQL><SelectStatement modified='1' type='string'><! The delimiter string: <SelectStatement modified='1' type='string'><! dlm="<SelectStatement modified='1' type='string'><! The above command is... (7 Replies)
Discussion started by: kmanivan82
7 Replies

2. UNIX for Beginners Questions & Answers

Change encoding, no removing special chars. inconv

Hi all, I'm using iconv command to change files encoding to UTF-8 If my input file has chars as those are removed creating the file without those special chars. I tried using iconv -c, but there is still the removal. Is there a way to keep those special chars changing just the... (6 Replies)
Discussion started by: mrreds
6 Replies

3. UNIX for Advanced & Expert Users

Removing special chars from file and maintain field separator

Running SunOs 5.6. Solaris. I've been able to remove all special characters from a fixed length file which appear in the first column but as a result all subsequent columns have shifted to the left by the amount of characters deleted. It is a space separated file. Line 1 in input file is... (6 Replies)
Discussion started by: iffy290
6 Replies

4. Shell Programming and Scripting

Removing rows and chars from text file

Dear community, maybe I'm asking the moon :rolleyes:, but I'm scratching my head to find a solution for it. :wall: I have a file called query.out (coming from Oracle query), the file is like this: ADDR TOTAL -------------------- ---------- TGROUPAGGR... (16 Replies)
Discussion started by: Lord Spectre
16 Replies

5. Shell Programming and Scripting

Removing unknow chars from file names.

I'm trying to move a large folder to an external drive but some files have these weird chars that the external drive won't accept. Does anyone know any command of any bash script that will look through a given folder and remove any weird chars? (4 Replies)
Discussion started by: Joktaa
4 Replies

6. Shell Programming and Scripting

removing file with bad characters

I have the following files in the same directory but if you look at the od output you can see one of the files has and "\n" as part of the file name. Is there a way I can only remove the file with the "\n" as part of the file name without affecting the other file. I was thinking about... (4 Replies)
Discussion started by: BeefStu
4 Replies

7. Shell Programming and Scripting

removing spaces in filenames

I have a problem mounting images because of the spaces in the filenames. Does anyone know how to rename files by removing the spaces with the find command? find Desktop/$dir -name "*.dmg" -print -exec ??? (4 Replies)
Discussion started by: ianebaj
4 Replies

8. Shell Programming and Scripting

SED: Removing Filenames From Paths

I'm using a script with a lot of SED commands, in conjunction with grep, cut, etc. I've come up against a wall with a particular road block: I output a file from an SVN registry that gives me a list of files. The list consists of a variable number of lines that contain a path/file. The paths... (4 Replies)
Discussion started by: Brusimm
4 Replies

9. Shell Programming and Scripting

removing non-printable chars from multiple files

How do I remove non-printable characters from all txt files and output the results to one file? I've tried the following: tr -cd '\n' < *.txt > out.txt and it gives ambiguous redirect error. How can I get it to operate on all txt files in the current directory and append the output to... (1 Reply)
Discussion started by: revax
1 Replies

10. UNIX for Dummies Questions & Answers

removing the extension from all filenames in a folder

Hi there, I'm pretty new to UNIX and have tried trawling through this forum to find an answer to what I want to try to do, which I'm sure is very simple but I don't know how to do it. What I have a a folder that contains multiple files that I have copied from Windows and I want to remove the... (5 Replies)
Discussion started by: johnmcclintock
5 Replies
Login or Register to Ask a Question

Featured Tech Videos