Trouble with looping increasing script


 
Thread Tools Search this Thread
Top Forums UNIX for Beginners Questions & Answers Trouble with looping increasing script
# 1  
Old 02-24-2020
Trouble with looping increasing script

I am looking to run this script in a loop but add 1 to the pdf and text names each time until it reaches a certain number. So, in the end, I will change the initial range and conditional stop. I keep getting a line 11 and line 17 - [: missing "]". Please let me know what I am doing wrong or if I am going about this the wrong way.

Here is my code:
Code:
#!/bin/bash

echo "Let's Get This Started!"

n=1

for n in {1..45}

do
		echo $n. "/$n"
		if [ $n -ne "45"];
		then
				linkrot -c -v -o $n.txt '$n.pdf'
				n=($n+1)
		fi

		if [ $n -eq "45"];
		then
				break
				echo "All Done"
		fi
done

Moderator's Comments:
Mod Comment Please use code tags for your code and data, thanks

Last edited by vbe; 02-24-2020 at 03:31 PM..
# 2  
Old 02-24-2020
Start by adding the missing space before the right square bracket:
Code:
[ $n -ne "45" ]

# 3  
Old 02-24-2020
Code:
#!/bin/bash

echo "Let's Get This Started!"

for n in {1..45}
do
echo $n. /$n
if [ $n -lt 45 ]
then
linkrot -c -v -o $n.txt $n.pdf
else
echo All Done
fi
done


Last edited by rdrtx1; 02-24-2020 at 04:54 PM..
# 4  
Old 02-24-2020
And dont forget:
Code:
 let n=($n+1)

# 5  
Old 02-24-2020
One more issue

These fixes appear to work great. Now my issue is that every time it is search for '$n.pdf' while I need the $n part to be the actual variable. Any advice there?
# 6  
Old 02-24-2020
e.g. Remove the single quotes?
# 7  
Old 02-24-2020
Thanks

That was it. It actually needed to be double-quoted. A requirement of the script. Thank you so much for your advice and lightning-fast responses.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Trouble looping commands

Hi, I have encountered a problem that I am unable to find a workaround for. I have 52 numbers and I need to submit an individual job for each pair combination, so too many to do by hand. I have created a submission file (submission_code.sh) which contains the following code: gcta64... (2 Replies)
Discussion started by: tim.morris
2 Replies

2. Shell Programming and Scripting

Infinite looping in script

we have one script which we use to send mail in our environment. If we are giving correct attachment script runs fine but if we give a attachment name which is not present on server then this script go to infinite loop and causing all memory to be used. could any one please suggest me what is wrong... (2 Replies)
Discussion started by: anshu ranjan
2 Replies

3. Shell Programming and Scripting

Looping in the shell script with help of script timer.

Hello Experts- We are facing some issues in the while loop script when we use the script time to decide whether to exist from the loop or continue. Below is the script SrcExitLoop="FALSE" Src_InitialStartTime=`date +%s` Src_StartTime=`date +%s` Src_NUM_ALERTS=0 TOTAL_ALERTS=`expr <SOME... (4 Replies)
Discussion started by: Amey Joshi
4 Replies

4. Shell Programming and Scripting

trouble looping in script

I am having problem looping this script I want to give the user option to decide if they want to continue after each entry but then also loop it back to beginning so they can more to content of there testcase they just created. I fam new to scripting so loops are little tricky for me. code I... (7 Replies)
Discussion started by: andrew.p.mcderm
7 Replies

5. Shell Programming and Scripting

Looping Bash Script

Does anyone have a same of a bash script that cd to a directory and execute a cgi script then moves onto the next directory then executes another cgi ? (3 Replies)
Discussion started by: Virusbot
3 Replies

6. Shell Programming and Scripting

Menu Script looping

Hi , I have a menu driven script as shown below echo "" echo "*** 1 - option 1 " echo "*** " echo "*** 2 - option 2 " echo "*** 3 - option 3 " ... (3 Replies)
Discussion started by: ultimatix
3 Replies

7. Shell Programming and Scripting

Help Looping through files in Vi Script

I am trying to write a script that loops through all the files in the current directory that end in '.slg.gz' and runs a parser on each file. Here is my code: #!/bin/bash FILES_HOME = 'dirname $0' for i in $(ls $FILES_HOME/.slg.gz$);do ./run-feature-parser $(i) > OUTPUT.csv done ... (1 Reply)
Discussion started by: kssteig
1 Replies

8. Shell Programming and Scripting

merge two files via looping script

Hi all, I hope you can help me. I got a file a and a file b File a contains a b c d e f g h File b contains 1 2 3 (8 Replies)
Discussion started by: stinkefisch
8 Replies

9. Shell Programming and Scripting

Looping script with variables

If I have a file with a bunch of various numbers in one column, how can I make a script to take each number in the file and put in into a command line? Example: cat number_file 2 5 8 11 13 34 55 I need a loop to extract each of these numbers and put them into a command line... (1 Reply)
Discussion started by: jojojmac5
1 Replies

10. Shell Programming and Scripting

Looping a perl script in a shell script

I am trying to get the follow script to run in the background on the 'fly'. I can launch it via cron and it will run in the background. BUT when I launch it from the command line it will run in the foreground. I figure it has to do with the while loop I have, but I have no clue how I can run the... (8 Replies)
Discussion started by: edkung
8 Replies
Login or Register to Ask a Question

Featured Tech Videos