Getopts not echoing correctly


 
Thread Tools Search this Thread
Top Forums UNIX for Beginners Questions & Answers Getopts not echoing correctly
# 1  
Old 05-13-2019
Getopts not echoing correctly

Hi,

When I run the the following code:

Code:
#!/bin/bash


if [[ ${#} -lt 1 ]]; then
    usage
fi

if [[ ${UID}  -eq 0 ]]
then
echo "Do not execute this as root, use -s instead"
fi

SERVERFILE="servers"

function usage {
    echo "USAGE: ${0} [-nsv] [-f FILE] COMMAND"
    echo "-f FILE   Use to override the default file"
    echo "-n        Use for dry Run"
    echo "-s        Use to run the command with sudo"
    echo "-v        Use for verbose"
}




#ssh -o ConnectTimeout=2 server01 sudo 

while getopts 'nsvf:' opt
do
    case "${opt}" in
        n)
            shift "$((OPTIND-1))"
            COMMANDS="${*}"
            cat ${SERVERFILE} | while read line 

                do
                echo "DRY RUN ssh -o ConnectTimeout=2 ${line} ${COMMANDS}"
                done
            
            exit 0

        ;;

        s)
            AS_SUDO="YES"
                                  
        ;;

         f)
            
            SERVERFILE=${OPTARG}
        ;;

        v)
            
            echo "verbose mode"
        ;;

    esac
    done
shift "$((OPTIND-1))"

I get the following output:

Code:
[vagrant@admin01 vagrant]$ ./new-script.sh -n test-command
 test-commando ConnectTimeout=2 10.9.8.11
 test-commando ConnectTimeout=2 10.9.8.12

I am not sure why is that. Any help will be appreciated.
# 2  
Old 05-13-2019
Your $SERVERFILE has a CR character at the line end (usually from being edited in WinDos).
Run dos2unix on it!
This User Gave Thanks to MadeInGermany For This Post:
# 3  
Old 05-13-2019
You call the "usage" function before it is defined.
# 4  
Old 05-13-2019
I will add after the above posts:
I dont use bash so I may be wrong, but why do you single quotes in the while line?
You use variable I dont see initialised so no idea what they contain
I have never seen a shift out of a case ( here after done...)
So I suspect you have not given us the whole script so cant guess with what we have here...
# 5  
Old 05-13-2019
Quote:
Originally Posted by MadeInGermany
Your $SERVERFILE has a CR character at the line end (usually from being edited in WinDos).
Run dos2unix on it!
Perfect. Retested it and it's working as expected.

Thanks
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Echoing only once for each subdir

I have a script that runs from this: for i in * ; do (cd $i && echo $i && /test1/execute/testb);done this is testb: for file in `ls *.txt` do if && && && && && ; then echo "NO"; break 1; else echo "it is there" fi done What is happening is that I can get it to run a... (19 Replies)
Discussion started by: newbie2010
19 Replies

2. Shell Programming and Scripting

Echoing silently?

I know, sounds mutually exclusive :-) I have a script where I ask for a password and store it in a variable, and then use it with sudo on an array of other hosts. The password winds up being choed back to my terminal as well as to the process on the remote host, like: Attempting to update... (2 Replies)
Discussion started by: jnojr
2 Replies

3. Shell Programming and Scripting

[QUESTION] echoing a variable

Hi...I am trying to make a script like this: mmc=123 echo "$mmc" > 123.txt The variable "mmc" has to be declared right on the beginning of the script, so when I open 123.txt, I get: 123 My question is, how can I "echo" '$mmc' into 123.txt, retaining the '$mmc' phrase? Which means when... (10 Replies)
Discussion started by: Ryuinferno
10 Replies

4. Shell Programming and Scripting

Echoing command results

Sorry folks, Second time today. I am working on a script that accepts data via pipe and processes it. I expect it to work as: # command | ProcScript.sh Within ProcScript.sh, I want to be able to give the target of the prev run command I am using history 2 | grep -v history | awk... (18 Replies)
Discussion started by: Marc G
18 Replies

5. UNIX for Dummies Questions & Answers

telnet echoing 'trying ip' but no port number

Hi, Well this is probably a silly one that I should know...but I don't ! I'm telnetting to various ports from a shell script and the telnet is echoing back that it's 'trying xxx.xx.xx.xx...' but not the port number it's trying! Any help much appreciated Thanks (1 Reply)
Discussion started by: Grueben
1 Replies

6. Shell Programming and Scripting

Echoing weird variables.

kindly find below:- var="'(]\\{}\$\"" echo $var # it wil give this '(]\{}$" echo "$var" # '(]\{}$" Doesn't make a difference why???. if we set IFS to '\' also the below happens IFS='\' echo $var # '(] {}$" \ converted to space. Why? weird!! echo "$var"... (3 Replies)
Discussion started by: ahmad.diab
3 Replies

7. Shell Programming and Scripting

Why getopts doesn't detect correctly my switches?

Dear all, I have created a KornShell script containing swiches with getopts (command line switches). Normally, my script should work like this: $ ./myscript.ksh -a 12 -b 4 -c 78 The switch a was selected with the argument 12 The switch b was selected with the argument 4 The switch c was... (3 Replies)
Discussion started by: dariyoosh
3 Replies

8. Shell Programming and Scripting

Echoing

I was just wondering how you would echo out different length variables but still have them all line up. I tried putting tabs between the variables but that didn't work as planned. For example this is in some loop, with different variables in it each time: echo "$1 $2 $3 $4 $5" Appears like... (3 Replies)
Discussion started by: Okema
3 Replies

9. UNIX for Dummies Questions & Answers

echo not echoing correctly

Here is the file named tuwork.......... 209 200 WZ 6529 SKTNCA01X4X C POI LODI LODI 738 SKTNCA0127T LOD Here is the scipt....... cat tuwork | while read rva do num=`echo $rva | cut -d" " -f1-2` reg=`echo $rva | cut -c10` ocn=`echo $rva | cut -c12-15` x=`echo $rva | cut -c29`... (3 Replies)
Discussion started by: shorty
3 Replies

10. Shell Programming and Scripting

echoing two variables in one statement

I have the following -------------------- foreach var (STO SNY WKF) set ta = 5 end --------- How can I echo both variables at the same time. Something to the effect of echo ${$var}ta But this doesn't work. Seems like it would. Thanks. (4 Replies)
Discussion started by: wxornot
4 Replies
Login or Register to Ask a Question