Why this script is not working as 'expected' when doing ssh with while read ... really confused?


 
Thread Tools Search this Thread
Top Forums UNIX for Beginners Questions & Answers Why this script is not working as 'expected' when doing ssh with while read ... really confused?
# 1  
Old 05-13-2019
Why this script is not working as 'expected' when doing ssh with while read ... really confused?

Hi,

I have a script below that is running ssh <host> <command> on some servers.

Below is more or less the script. I have to modify it somehow to get rid of the 'confidential' hostnames

Code:
check_log.bash

#!/bin/bash
#

myPID=$$

parse_log ()
{
   sub="parse_log"
   host=${1}
   service=${2}

   echo
   echo "----------------------------------------------------------------"
   echo
   echo "... Parsing listener log on ${host}"

   cat /dev/null > ${sub}.${host}.tmp
   ssh ${host} find /u01/app/grid/diag/tnslsnr/${host} -name "listener*log" -print | tee -a ${sub}.${host}.tmp

   while read log
   do
      echo "     --> Searching ${log} for ${service} on ${host} ..."
      #ssh ${host} grep -i "${service}" ${log}
      #echo
   done < ${sub}.${host}.tmp

   echo
   echo "----------------------------------------------------------------"
   echo
}


########
# MAIN #
########

parse_log "host1" "test_app"
parse_log "host2" "test_app"
parse_log "host3" "test_app"

I am running the script on a mounted filesystem that is accessible to all hosts, i.e. for example /nfs/scripts. So the script is /nfs/scripts/check_log.bash and I just run it from host1 as ./check_log.bash.

So the first ssh below runs fine, it does the find and redirect the result to the .tmp file

Code:
   cat /dev/null > ${sub}.${host}.tmp
   ssh ${host} find /u01/app/grid/diag/tnslsnr/${host} -name "listener*log" -print | tee -a ${sub}.${host}.tmp

I then want to grep for a script like "test_app" from each file which is why I have the following while loop.

Code:
   while read log
   do
      echo "     --> Searching ${log} for ${service} on ${host} ..."
      #ssh ${host} grep -i "${service}" ${log}
      #echo
   done < ${sub}.${host}.tmp

So far so good, I tested and it does shows me the " Searching ..." string. However when I am now ready to run it the ssh and has uncommented the
Code:
#ssh ${host} grep -i "${service}" ${log}

. The while loop is not going thru all the file in the .tmp file, it is only doing it on the first file. It's as if after it run the first ssh it is breaking out of the while loop?

At first I thought maybe it has to do with using /bin/bash. Using /bin/ksh gives the same result.

Not sure what am doing wrong :-) Checking the .tmp file, I can see that each of them has about 6-7 files.
# 2  
Old 05-13-2019
My first guess is that the while read opens the input and reads the first line, then ssh consumes all the residual lines from the input file. Try ssh -n.


But - the approach to loop through the input file and opening an ssh session for every single entry is resource hungry and far from optimal. How about creating a "search" file and running the grep from it in a single session?
# 3  
Old 05-13-2019
Oops, just found the answer from Google. Using ssh -n gives me what I am wanting to do.
This User Gave Thanks to newbie_01 For This Post:
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Is this sort working as it is supposed to be? A bit confused whether it is sorting correctly or not

Hi, Below is the sample file: $ cat x.txt MDSYS|OGIS_GEOMETRY_COLUMNS|TABLE MDSYS|OGIS_SPATIAL_REFERENCE_SYSTEMS|TABLE MDSYS|SDO_IDX_TAB_SEQUENCE|SEQUENCE MDSYS|SDO_PREFERRED_OPS_USER|TABLE MDSYS|SDO_ST_TOLERANCE|TABLE MDSYS|SDO_TOPO_DATA$|TABLE MDSYS|SDO_TOPO_RELATION_DATA|TABLE... (4 Replies)
Discussion started by: newbie_01
4 Replies

2. UNIX for Beginners Questions & Answers

Passing Arguments to shell script from file is not working as expected.

Hi All, I have below simple shell script in cloudera quick start vm cenos 6 which copy file from source to destination. # file_copy.sh source_dir = ${source_dir} target = ${target_dir} cp source_dir target and my parameter file is like below #parameter_file.txt source_dir =... (4 Replies)
Discussion started by: Narasimhasss
4 Replies

3. Shell Programming and Scripting

Bash read input in case statement not working as expected

I'm having an issue with bash read input when using a case statement. The script halts and doesn't read the input on the first loop. if I hit enter then the scripts starts to respond as expected. Need some help here. defaultans=8hrs read -e -i $defaultans -p "${bldwht}How long would you like... (5 Replies)
Discussion started by: woodson2
5 Replies

4. Shell Programming and Scripting

awk matching script not working as expected

This is my ubuntu version: $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 16.04.4 LTS Release: 16.04 Codename: xenial $ /bin/awk -V | head -n1 bash: /bin/awk: No such file or directory I have gotten a script that helps me to parse,... (14 Replies)
Discussion started by: delbroooks
14 Replies

5. Shell Programming and Scripting

awk not working as expected in script

Dear all, I had script which used to work, but recently it is not working as expected. I have command line in my shell script to choose the following format from the output_elog and perform some task afterwards on As you see, I want all numbers in foramt following RED mark except for... (12 Replies)
Discussion started by: emily
12 Replies

6. Shell Programming and Scripting

Script not working as expected

Hi, I have prepared a script and trying to execute it but not getting expected output. Could you please help and advise what is going wrong. "If else" part in below script is not working basically. I am running it on HP-UX. for i in slpd puma sfmdb do echo "******\t$i\t*******" echo... (10 Replies)
Discussion started by: sv0081493
10 Replies

7. Shell Programming and Scripting

Read command not working as expected

I was trying to write a simple script which will read a text file and count the number of vowels in the file. My code is given below - #!/bin/bash file=$1 v=0 if then echo "$0 filename" exit 1 fi if then echo "$file not a file" exit 2 fi while read -n... (14 Replies)
Discussion started by: linux_learner
14 Replies

8. Shell Programming and Scripting

ssh is not working while calling through expect shell script

Hi, Please share you experience and way out on below error:--> #!/bin/bash -xv FILE=login.txt + FILE=login.txt CONNECT=sshlogin.exp + CONNECT=sshlogin.exp SERVERNAME=$1 + SERVERNAME=192.168.12.1 MyServer="" + MyServer= MyUser="" + MyUser= MyPassword="" + MyPassword= exec 3<&0 +... (6 Replies)
Discussion started by: manish_1678
6 Replies

9. Shell Programming and Scripting

Read statement not working in a script

I have a script consisting of certain functions whose input is a file at same location. In that file i have written the name of anothe file at same location. The third file contains a word which act as a function in the first script.Let me give an example i have a scrip file say 1.sh in which i am... (7 Replies)
Discussion started by: sumitdua
7 Replies

10. Shell Programming and Scripting

error "test: [-d: unary operator expected" very confused.

Im trying to check if a series of directory exists and if not create them, and am having issues. All the instances of test return with the error "test: #!/bin/bash location_Parent=~/Documents/sight_of_sound location_IMG=~/Documents/Sight_of_sound/IMG location_AUD=~/Documents/Sight_of_sound/AUD... (4 Replies)
Discussion started by: orionrush
4 Replies
Login or Register to Ask a Question