Shell Script

11-07-2017

Moderator

3,843, 841

Join Date: Jun 2007

Last Activity: 29 June 2020, 12:30 PM EDT

Location: Lancashire, UK

Posts: 3,843

Thanks Given: 2,004

Thanked 841 Times in 727 Posts

Quote:

Originally Posted by Don Cragun

Code:

if [ $(wc -l < "$FILE") -gt 0 ]; then

Would a neater way be to test if the file is null or not? Does it really depend if you file has data or not? If you file does not have separate records and/or one at the end, you might still get the record count of zero, for example:-

Code:

$ printf "Hello unix.com" | wc -l
0
$

If you just want to test for the file size being zero or not, you could try:-

Code:

if [ -s "$FILE" ] ; then .......

This statement is to check "If $FILE exists and has a size greater than zero, then ....."

You might also want to check if the file can be read first with a similar statement, but using the -r test operator. If you need to update the file when your processing is complete, you can check if you can write to it with the -w operator. Have a look and man test for the other options.

Just my thoughts. I hope that this helps,
Robin

These 4 Users Gave Thanks to rbatte1 For This Post:

rbatte1

View Public Profile for rbatte1

Visit rbatte1's homepage!

Find all posts by rbatte1

11-08-2017

Registered User

37, 0

Join Date: Apr 2012

Last Activity: 1 October 2018, 1:02 AM EDT

Posts: 37

Thanks Given: 8

Thanked 0 Times in 0 Posts

Can you guide me how to schedule the script which will run between 12 to 3:30?

then only it has to count the data from the file.. please advise.

vasuvv

View Public Profile for vasuvv

Find all posts by vasuvv

11-08-2017

Registered User

6,384, 2,214

Join Date: May 2005

Last Activity: 28 October 2019, 4:59 PM EDT

Location: In the leftmost byte of /dev/kmem

Posts: 6,384

Thanks Given: 143

Thanked 2,214 Times in 1,548 Posts

Quote:

Originally Posted by vasuvv

Can you guide me how to schedule the script which will run between 12 to 3:30?

I already told you in post #2: use a crontab entry. You can easily find out how to do that by reading the man page of cron and/or crontab respectively. I already told you so in post #2 too.

Could you - instead of asking repeatedly the same question - actually do what is suggested?

I hope this helps.

bakunin

bakunin

View Public Profile for bakunin

Find all posts by bakunin

11-09-2017

Registered User

37, 0

Join Date: Apr 2012

Last Activity: 1 October 2018, 1:02 AM EDT

Posts: 37

Thanks Given: 8

Thanked 0 Times in 0 Posts

Code:

#!/bin/ksh


to = "test@gmail.com"
from = "robin@gmail.com" 
subject= "mesg is mailing" 


DB_DECRYPTED_PASSWORD='xyts'; --Need advise to hide the password
DB_CONNECTION_STRING="(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=$DB_HOST)(PORT=$DB_PORT))(CONNECT_DATA=(SERVICE_NAME=$DB_SID)))"
RERUN=$5
PATH=$PATH:$ORACLE_HOME/bin

echo "---------------------------------------------------"
echo  ENVIRONMENT = $ENV;
echo  DB_HOST =  $DB_HOST
echo  DB_PORT =  $DB_PORT  
echo  DB_USER =  $DB_USER
#echo  DB_PASSWORD =  $DB_PASSWORD
#echo  DB_DECRYPTED_PASSWORD =  $DB_DECRYPTED_PASSWORD
echo  DB_SID =  $DB_SID
echo  DB_CONNECTION_STRING = $DB_CONNECTION_STRING
echo "---------------------------------------------------"  


##################################################


FILE="/usr/jobs/emp_details.txt"
#FILE="emp_details.$(date +%F_%R).txt"
#touch $FILE

echo $ORACLE_HOME/bin/sqlplus
echo "======== START ============="

#$ORACLE_HOME/bin/sqlplus -s scott/tiger@ABC  <<EOF
RESULT=`$ORACLE_HOME/bin/sqlplus  -silent ${DB_USER}/${DB_DECRYPTED_PASSWORD}@${DB_CONNECTION_STRING} <<ENDA
 
 while true
  do
  15 12 * * * /usr/jobs/emp_details.txt
  30 15 * * * /usr/jobs/emp_details.txt
  sleep 900
  done
  
 set pagesize 0 feedback off verify off heading off echo off
column last_business_date format date
<SELECT QUERY> ;
exit;
ENDA`

echo "$RESULT" > $FILE
sed '/#^/G' $FILE
echo "======== END ============="

## READ AND WRITE THE FILE AND TOOK THE BACKUP
 while IFS= read -r line
 do
echo "$line" >> "emp_details.backup.$(date +%F_%R).txt"
done < "$FILE"

##this will fetch the number of lines in the file

if [ $(wc -l < "$FILE") -gt 0 ]; then

cat <<EOF; mailx -s "$subject" -r "$from"  "$to" < "/usr/jobs/emp_details.txt"

fi

suggest to hide the password and correct the code.

Thanks.

vasuvv

View Public Profile for vasuvv

Find all posts by vasuvv

11-09-2017

Registered User

12,315, 4,560

Join Date: Jul 2012

Last Activity: 22 November 2019, 4:29 PM EST

Location: San Jose, CA, USA

Posts: 12,315

Thanks Given: 952

Thanked 4,560 Times in 3,818 Posts

Your code does not match your stated requirements.

Since we do not have your environment, your databases, and still( after asking multiple times) do not even know what operating system you're using, it is difficult to correct your code when we can't see the errors you're getting.

All that we can do to help you is to ask questions that might help us help you fix your code. But, since you refuse to answer most of our questions, I have no confidence there is much we can do to help you:

What operating system are you using?
What errors are you getting when you run the code shown in post #18?
In post #12 you say you want a backup file named EMP_FILE_bkp.txt, your code in post #18 produces a backup filename of the form emp_details.backup.YYYY-MM-DD_HH:MM.txt. Why the discrepancy in your requirements?
Why do you have a cat in your script reading from an unterminated here-document?
You need to submit crontab entries to cron's scheduler using the crontab utility. The Korn shell can't execute crontab entries!
Please explain what you are trying to do with the command: sed '/#^/G' $FILE. The BRE in that address can't match any lines???
Why are you still using wc instead of a test -s to determine whether or not you have data to send in a mail message?

You can choose to answer the above questions in your next post, or we can choose to close this thread. Please help us help you by answering the questions above.

This User Gave Thanks to Don Cragun For This Post:

Don Cragun

View Public Profile for Don Cragun

Find all posts by Don Cragun

11-09-2017

Registered User

37, 0

Join Date: Apr 2012

Last Activity: 1 October 2018, 1:02 AM EDT

Posts: 37

Thanks Given: 8

Thanked 0 Times in 0 Posts

What operating system are you using?

Code:

 LINUX

What errors are you getting when you run the code shown in post #18?

Code:

 not getting any errors but Unable to send Mail with attachement and unable to schedule the job to run in given time intervals.Tried with CRON as am new to these written code wrongly.

In post #12 you say you want a backup file named EMP_FILE_bkp.txt, your code in post #18 produces a backup filename of the form emp_details.backup.YYYY-MM-DD_HH:MM.txt. Why the discrepancy in your requirements?

Code:

 have modified the code to create a backup file the the given format and the file is fetting generated without any issues'

Why do you have a cat in your script reading from an unterminated here-document?

Code:

as gone through the google search gave to see the content of the file. Am sure Its not required.

You need to submit crontab entries to cron's scheduler using the crontab utility. The Korn shell can't execute crontab entries!

Code:

as I have lack of knowledge after googling I gave this nut am not sure how it will work. it would be great if I get from you to write the script properly.

Please explain what you are trying to do with the command: sed '/#^/G'
$FILE. The BRE in that address can't match any lines???

Code:

I am not sure what this command will do..

Why are you still using wc instead of a test -s to determine whether or not you have data to send in a mail message?

Here Again posting my requirement.
[code]

1. Have SQL query. The query should run every day between 12 pm - 3PM for every 15 minutes.
2. within thise duration it has to create backup files.
3. If the query returns any data then need to send a mail with that output file as attachment else no need to send a mail.

If would be great if I get complete script as I tried but failing in writing the script.

Thanks,
Vasu

vasuvv

View Public Profile for vasuvv

Find all posts by vasuvv

11-09-2017

Registered User

6,384, 2,214

Join Date: May 2005

Last Activity: 28 October 2019, 4:59 PM EDT

Location: In the leftmost byte of /dev/kmem

Posts: 6,384

Thanks Given: 143

Thanked 2,214 Times in 1,548 Posts

I won't interfere with what DonCragun already does here, but this:

Quote:

Originally Posted by vasuvv

as I have lack of knowledge after googling I gave this nut am not sure how it will work. it would be great if I get from you to write the script properly.

was my suggestion. I TOLD YOU TO READ THE MAN PAGE OF cron and crontab and if you had done that (instead of googling for recipes) you perhaps would have by now understood how it works.

Sorry, but some things need a certain level of understanding before they can successfully be attempted. "Tell me how to drive a nail in" might work, even if the person never had a hammer in his hands before, but "tell me how to do open-heart surgery" will not equally work for people who are not already fully-qualified surgeons in first place. And even then it is doubtful.

UNIX is not open-heart surgery, but it is not hammer and nail either. Some things you can't just click together. You need to understand what you are doing because you need to (intelligently) make decisions while you do it and these decisions can't all be prefabricated.

So, for the umpteenth time now, execute the two (three) commands:

Code:

man cron
man crontab
man 5 crontab

and read what is written there.

I hope this helps.

bakunin

bakunin

View Public Profile for bakunin

Find all posts by bakunin

UNIX for Beginners Questions & Answers

Shell Script

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Shell script newbie- how to generate service log from shell script

Discussion started by: xiaogeji

2. Shell Programming and Scripting

Pass C shell array to another C shell script(csh) and shell(sh)

Discussion started by: SA_Palani

3. Shell Programming and Scripting

How to write config shell script to pass variables in master shell script?

Discussion started by: dba1981

4. UNIX for Dummies Questions & Answers

How to write Config shell script to pass variables in master shell script?

Discussion started by: dba1981

5. Shell Programming and Scripting

Unable to pass shell script variable to awk command in same shell script

Discussion started by: Ashunayak

6. Shell Programming and Scripting

Correct shell script to Call One shell script from another shell script

Discussion started by: Vineeta Nigam

7. Shell Programming and Scripting

call another shell script and pass parameters to that shell script

Discussion started by: sunrexstar

8. Shell Programming and Scripting

How to use ssh execute other shell script on other host (shell script include nohup)?

Discussion started by: orablue

9. Shell Programming and Scripting

invoking a shell script inside cgi shell script

Discussion started by: smriti_shridhar

10. Shell Programming and Scripting

How to Run a shell script from Perl script in Parent shell?

Discussion started by: hifake