When running if condition, getting the following error


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting When running if condition, getting the following error
# 1  
Old 04-06-2008
When running if condition, getting the following error

Hi All,

My input file name is 1.sh

the contents of file are

cat status2.txt | while read filename
do
echo "$filename"
echo "first content of the file is ${filename[0]}"
echo "second content of the file is ${filename[0]}"
echo "second content of the file is ${filename[0]}"
if [ ${filename[0]} -eq 0 -a ${filename[1]} -eq 0 -a ${filename[2]} -eq 0 ]
then
echo "please execute the step 1, then step 2 and then step3"
elif [ ${filename[0]} -eq 0 ]
then
echo "please execute the step 2 and then step3"
elif [ ${filename[0]} -eq 0 -a ${filename[1]} -eq 0 -a ${filename[2]} -ne 0 ]
then
echo "please execute the last step3"
fi
done


Where status2.txt contains the following contents
0 --> first content is 0
0 --> Second content is 0
--> Third content is the space


Now running the 1.sh file i am getting the following output.

0
first content of the file is 0
second content of the file is 0
second content of the file is 0
./1.sh: [: too many arguments -------> Error
please execute the step 2 and then step3
0
first content of the file is 0
second content of the file is 0
second content of the file is 0
./1.sh: [: too many arguments -------> Error
please execute the step 2 and then step3

first content of the file is
second content of the file is
second content of the file is
./1.sh: [: too many arguments -------> Error
./1.sh: [: -eq: unary operator expected -------> Error
./1.sh: [: too many arguments -------> Error
dmadmin SYDUEND01 /tmp/A380_RFS24


can anybody tell me that why i am getting the above error??
It is very urgent, Please response me ASAP.

Thanks
# 2  
Old 04-06-2008
Presumably ${filename[0]} gets expanded into an empty string, and test isn't able to parse that. Remember that unquoted empty strings will simply disappear. Either quote the strings, or append a character before them (or, to be on the safe side, do both -- that's why you frequently see something like if [ X"$string" = X ])

Code:
vnix$ echo $nosuchvariable


vnix$ [ $nosuchvariable -eq 0 -a $nosuchvariable -eq 0 -a $nosuchvariable -eq 0 ]
bash: [: too many arguments

vnix$ [ "$nosuchvariable" -eq 0 -a "$nosuchvariable" -eq 0 -a "$nosuchvariable" -eq 0 ]
bash: [: : integer expression expected

I don't understand why you expect $filename to turn into an array. Your while loop reads one line at a time, and the value you read replaces the previous value for $filename. If you want it to be an array, you need to initialize it in a different way.

Maybe you really mean something like this.

Code:
exec <status.txt
read file1
read file2
read file3

echo "first content of the file is $file1"
echo "second content of the file is $file2"
echo "third content of the file is $file3"  # or do you really mean to print "second" twice?
if [ "$file1" -eq 0 -a "$file2" -eq 0 -a "$file3" -eq 0 ]
then
echo "please execute the step 1, then step 2 and then step3"
elif [ "$file1" -eq 0 ]
then
echo "please execute the step 2 and then step3"
elif [ "$file1" -eq 0 -a "$file2" -eq 0 -a "$file3" -ne 0 ]
then
echo "please execute the last step3"
fi

This will still print an error message if not all the input is numeric (that's the "integer expression expected" case in the example above). You might be better off using a case statement instead; it's much less sensitive to the type of input etc than test (aka "[").
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

If condition is not working and getting error

Hi Team, If condition is not working properly and getting below error # ./score1.sh Enter your score ('q' for quit): 102 Enter your score ('q' for quit): q ./score1.sh: line 9: q: integer expression expected Average is: 102%. Exit. Actual code # Calculate the average of given... (3 Replies)
Discussion started by: Torrid
3 Replies

2. Shell Programming and Scripting

If condition giving syntax error. Need help.

Hi, I have an if condition on executing it is giving syntax error as below: -------------------------------------------------------------------------------------- line 61: syntax error in conditional expression ./play_test.sh: line 61: syntax error near `]' ./play_test.sh: line 61: ` if... (2 Replies)
Discussion started by: ramki067
2 Replies

3. Shell Programming and Scripting

Error: if condition

please follow below code if ; then its giving me an error as "test1.sh: line 3: r=$(eval echo '$lck_'$TABLE != "") if can anyone tell me how to do inside if condition...with out use any variable.. TIA (6 Replies)
Discussion started by: gnnsprapa
6 Replies

4. UNIX for Dummies Questions & Answers

error in if condition

Hi All, I need to compare the header of the input files which can be comma demilited, tild(~) or Pipr(|) seperated file. I am comparing the file header by taking 1st row and comparing it with input row: Below is the actual code:(ksh script) if then echo $dat >>... (4 Replies)
Discussion started by: abhi_123
4 Replies

5. Shell Programming and Scripting

while condition error:

I'm trying to run following code: while do echo "Hello World" done but I'm getting error on first line: ./test: line 1: syntax error near unexpected token `(' can anyone please tell me who can i run this loop. Also please tell me what will be syntax of do while loop in case i... (11 Replies)
Discussion started by: kashif.live
11 Replies

6. Shell Programming and Scripting

Condition error!

Hi Guys, Can you please help me to check if my condition is correct. if && then if ; then # active SE_USERID_LUZON_5="A" elif ; then # not active SE_USERID_LUZON_5="D" ${ECHO_CMD}... (3 Replies)
Discussion started by: nikki1200
3 Replies

7. Shell Programming and Scripting

Error in if condition string comparison

Hello all! I need help in debugging following script. I have no idea where I am going wrong. #!/bin/bash for p1 in A1 TM MP do for p2 in A1 TM MP do for mp1 in N1 N2 do for mp2 in N1 N2 do for mp3 in N1 N2 do for mp4 in N1 N2 do for... (7 Replies)
Discussion started by: RLOA
7 Replies

8. UNIX for Dummies Questions & Answers

until loop : running even if condition is satisfied

I am checking one until loop with the following logic until || |||| do sleep 30 done before running this i am exporting above variables to SUCCESS.But the loop is running in infinite loop.My requirement is to make the loop run until all the 3 variables are SUCCESS or any of the 3... (2 Replies)
Discussion started by: dr46014
2 Replies

9. Shell Programming and Scripting

error in if-else condition

Hi.. Im using the following script to find whether the present day is monday or not. If it is monday it has to do a specific set of things. #!/bin/sh Present_Date=`date` LOAD_DAY=`date -d "$Present_Date" | cut -d " " -f 1` echo $LOAD_DAY if ;then echo "Monday" #statements;... (6 Replies)
Discussion started by: abala
6 Replies

10. UNIX for Dummies Questions & Answers

Running scripts with condition

I have two scripts: SCR1 which takes between 5 seconds to 15 minutes and needs to be run every 23 minutes. SCR2 which needs to be run every 5 minutes but only if SCR1 is not running at that moment. How can I do this task? Best Regards /Hamid (3 Replies)
Discussion started by: Hamid Afsharazad
3 Replies
Login or Register to Ask a Question