What's wrong here? (Beginner's script)


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting What's wrong here? (Beginner's script)
# 1  
Old 02-16-2008
What's wrong here? (Beginner's script)

Hi Folks,

New member here. I have been using UNIX systems for the past ~4 years (Linux, AIX, HP-UX, mostly) but have never had the need to write a script for myself. Now, things have changed and I'm in a bit of a pickle. I have, what looks to me like a syntactically correct script that's not quite working exactly as I'd hoped. It's for the BASH shell. Here's where it's failing:

Code:
i=0
while [ $i -lt $count ]
do
  trap "ctrlc" SIGINT SIGTERM
  if [ "$i" -eq 0 ]; then
    date > new && ps -o user,pid,command | grep $PATTERN | grep -v ps >> new
    cat new
  else
    mv new old
    date > new && ps -o user,pid,command | grep $PATTERN | grep -v ps >> new
    diffProc()
  fi
  i=$(($i+1))
  echo
  sleep 10
done

The error I'm getting is:
Quote:
line 62: syntax error near unexpected token `fi'
line 62: ` fi'
Line 62 is the 'fi' following the call to diffProc(). I've looked at several BASH tutorials and the if statement here seems to be well-formed. I've turned on debugging but that doesn't really say much more than the error, except for the values of some variables. Any assistance you could give me would be greatly appreciated. Thank you.
# 2  
Old 02-16-2008
diffProc is a function call.

Just call it as
Code:
diffProc

and not as

diffProc()
# 3  
Old 02-16-2008
I knew it had to be something stupid like that. Thanks, matrixmadhan. My Java background definitely came into play there.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Beginner: script headache

Hi, I am new to shell scripting, but doing my best to learn things. Today doing courses there was exercise like this: #!/usr/bin/bash a=$1 b=$2 if ] then echo "Conditions are met" else echo "Conditions are not met" fi I improved it a little, beacuse of curiosity :D to this: ... (8 Replies)
Discussion started by: Rosentine
8 Replies

2. UNIX for Dummies Questions & Answers

Beginner needs help with first script

Hi, so I have been doing ok making a relatively simple script just processing some data. However I am now at the point where im struggling to find the specific help I need. I have files in the form of yyyy.ddd.hh.mm.ss.stationnumber.component (they are earthquake events). eg.... (12 Replies)
Discussion started by: neneman3000
12 Replies

3. Homework & Coursework Questions

Shell Script (beginner)

1. The problem statement, all variables and given/known data: Arguments: http://farm9.staticflickr.com/8070/8212131370_8b6e8c10c5_c.jpg I am given these three arguments. $1, $2, $3 The first argument is the path to a directory. So, how would I go into the directory and compare files? I... (5 Replies)
Discussion started by: spider-man
5 Replies

4. Shell Programming and Scripting

Shell script (beginner) need help...

Hello, I'm new to Sheel script and I need your help for a script I need to develop (for me). Indead, I have a software which log all entry from internet and save it in text file. But, the log is practically unreadable because every 256 characters jump to a new line (even if the message is... (5 Replies)
Discussion started by: acidoangel
5 Replies

5. Shell Programming and Scripting

Debugging a beginner shell script...

I have been following a tutorial on bash which has proven to be very helpful. However, i am stuck with a command not found issue when asking for a y/n response from the user. Below is the part of code I believe is giving me grief... I have been trying to work through this for 3 hours now.... Please... (5 Replies)
Discussion started by: brokepunk
5 Replies

6. Shell Programming and Scripting

Beginner shell script help

. ./testFile.sh url=http://ichart.finance.yahoo.com/table.csv?s= suf=&d=5&e=9&f=2009&g=d&a=1&b=4&c=1999&ignore=.csv wget $url$s1$suf; sleep 10; cat header.txt > $s1.txt; chmod 777 $s1.txt; sed '1d' table.csv?s\=$s1 >> $s1.txt; rm -Rf table* Very new at shell scripting as you can see... (3 Replies)
Discussion started by: harte
3 Replies

7. Shell Programming and Scripting

Need help with (beginner?) script

I am in an intro to unix/linux course, and need some help with a project. We are tasked with creating a basic script to automate a task that an Admin might need to do. We submitted ideas and mine was to have the system keep a record of log in and log out times for users. I thought this was going... (3 Replies)
Discussion started by: DethbyNo
3 Replies

8. Shell Programming and Scripting

Beginner needs help with script

I would like to get a sample script (ksh or bash, or both so I could see the differences) What I want to do with the script is send an daily email to myself that contains the following: The number of files in a directory The total size of the files in that directory The contents of a file... (2 Replies)
Discussion started by: martyb555
2 Replies

9. Shell Programming and Scripting

Shell Script for Beginner

I have a folder with lots of file. e.g. a.txt, b.txt, c.txt.... I want to put these files from the source directory and place them in a destination directory in a specific order, such as /destination/a/a.txt, /destination/b/b.txt, /destination/c/c.txt, ...... Please help. Thx :confused: (3 Replies)
Discussion started by: aaron_fong
3 Replies

10. Shell Programming and Scripting

Beginner trying to write a shell script!

Dear All, I'm trying to write a shell script that continously checks a certain folder. When a file is placed in the directory securely copies the file to another server. I've got the secure copying working, but I don't know how to contiously check a directory for a new file and then use that... (3 Replies)
Discussion started by: duncan_glover
3 Replies
Login or Register to Ask a Question