Shell Programming and Scripting

1. Replace the [[ with the word "test" and get rid of the "]]"

2. Remove the trailing slash on the directory paths for the if/test

3. Remember UNIX file systems are case sensitive

Even though the trailing slash is theoretically irrelevant, it has caused me problems in the past where somehow "/a/b/c/" not equivilant to "/a/b/c".

I see no reason to replace the brackets with the "test" command. Is there a functional difference? I prefer the brackets for readability.

Personal choice, I like to see what is actually happening, ie, "if runs a program to determine which branch is executed".

It's not irrelevant, just different. The test says "is the following entry a directory?" Putting a trailing slash says "Don't match unless this is a directory" it's redundant.

It starts to become extremely important to know the difference when you use mv, if you include a trailing / on the desitnation path, it will fail if the dir does not exist. If you leave it off, it will rename the source to the name of the desitnation directory but only if it doesn't exist :/

''

I've made all the changes I get the same results.

#!/usr/bin/bash

bank=`cat /export/home/usr/banklist.txt`
cdir=`cat /export/home/usr/mountlist.txt`

for d in $cdir ;do
for i in $bank ;do

if [[ -d /apps/data/custdata/$d/$i/incoming ]] ; then
ls -ltra /apps/data/custdata/$d/$i/incoming
fi

if [[ -d /apps/data/custdata/$d/$i/outgoing ]] ; then
ls -ltra /apps/data/custdata/$d/$i/outgoing
fi
done
done;

Or

#!/usr/bin/bash

bank=`cat /export/home/usr/banklist.txt`
cdir=`cat /export/home/usr/mountlist.txt`

for d in $cdir ;do
for i in $bank ;do

if test -d /apps/data/custdata/$d/$i/incoming ; then
ls -ltra /apps/data/custdata/$d/$i/incoming
fi

if test -d /apps/data/custdata/$d/$i/outgoing ; then
ls -ltra /apps/data/custdata/$d/$i/outgoing
fi
done
done;

both get no output.

So let's take a look at the new code then...

And a fully qualified subset list of expected files....