Visit The New, Modern Unix Linux Community


Help With A For Loop Issue


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Help With A For Loop Issue
# 1  
Help With A For Loop Issue

I was wondering how I can modify this for loop, so it only loops through the filenames that do not have an ".old" extension.

Code:
for filename in $(ls "$1")
do
   echo $filename | grep '\.old$' > /dev/null
   if [ $? != 0 ]
      then mv $1/$filename $1/$filename.old
   fi
done

# 2  
one way to loop through is using grep:
eg
ls | grep -v ".old"
another way is using find
eg
find . -type f ! -name "*.old" -print
# 3  
Quote:
Originally Posted by ralts01
I was wondering how I can modify this for loop, so it only loops through the filenames that do not have an ".old" extension.

Code:
for filename in $(ls "$1")
do
   echo $filename | grep '\.old$' > /dev/null
   if [ $? != 0 ]
      then mv $1/$filename $1/$filename.old
   fi
done


Do not use ls; it is unnnecessary and will break your script if any filenames contain spaces or other pathological characters.
Code:
for file in "$1"/*
do
  case $file in
     *.old) ;; ## do nothing
     *) mv "$file" "$file.old" ;;
  esac
done

You should probably also check that the new filename doesn't already exist.
# 4  
Thanks for the replys I'll give those suggestions a try.
# 5  
Code:
for filename in $(ls "$1")
do
   [[ -d "$filename" || ${filename##*.} = "old" ]] || mv $1/$filename $1/$filename.old
done

# 6  
Quote:
Originally Posted by anbu23
Code:
for filename in $(ls "$1")
do
   [[ -d "$filename" || ${filename##*.} = "old" ]] || mv $1/$filename $1/$filename.old
done

Try that script on the directory TESTING after running these commands:
Code:
(
 mkdir TESTING
 cd TESTING
 touch "file one" "file two" "file three"
)


Previous Thread | Next Thread
Thread Tools Search this Thread
Search this Thread:
Advanced Search

Test Your Knowledge in Computers #401
Difficulty: Medium
The 3D printing process builds a three-dimensional object from a computer-aided design (CAD) model.
True or False?

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Issue when doing a loop

Hi, I just have started learning shell scripting (sh). Why do i only get the date? while read dt do echo "Date : ${dt} sed -n '/${dt}/,/${dt}/p' file1.log | grep -w ERROR done < date1.dat INPUT - date1.dat 2019-04-05 04:58:25 2019-04-05 04:58:26 2019-04-05 05:00:56... (3 Replies)
Discussion started by: margel
3 Replies

2. Shell Programming and Scripting

Issue with for loop

Hi Team, I have for loop in my shell script. Which basically loop through all files in the directory, When some files are in the directory it works just fine. But if there are no files at all..still the for loop try to execute. Please help. Below is the code. #!/bin/ksh echo "Program... (5 Replies)
Discussion started by: bharath561989
5 Replies

3. Shell Programming and Scripting

Issue with while loop?

Hi, I have prepared a script to search for backup file information on the Linux server. Script works fine for the most part except the echo statement inside an IF conditional block displays the message ''snapshot directory not found on xxxxx" even though the .snapshot directory is found a... (11 Replies)
Discussion started by: svajhala
11 Replies

4. Shell Programming and Scripting

While Loop issue

Hi, i=0 t5=6000001 while do i=`expr $i + 1` t5=`expr $t5 + 1` echo $t5 done I am able to increment "col3" value but unable to get col1,col2 value. Input: t1=10001 t2=abc t3=ghkc (5 Replies)
Discussion started by: onesuri
5 Replies

5. Shell Programming and Scripting

Issue with using While loop

Hi, I am trying to move a file from remote server to local server and when the transfer completes successfully i call a script in remote server to remove the file which was successfully transferred. I do this by first getting the list of file in remote server and move the text file to local... (8 Replies)
Discussion started by: funonnet
8 Replies

6. Shell Programming and Scripting

for-while loop issue

sup experts..i had a script which was bugging me..was hoping someone could point out the issue here Input file: space separated 2 columns I wanted to print out the 2 columns after assigning them to variables ( bascially the same output but iterate through line by line ). The code worked... (7 Replies)
Discussion started by: foal_newbie
7 Replies

7. Shell Programming and Scripting

until loop issue.

Hi, my script is waiting for 3 files to come to a folder for 30 min but even when all the files arrive in the folder it's still waiting for these three files. Files can come with in 2 min and I want it to start processing them immediately after all the files arrive in the folder. until ; do... (3 Replies)
Discussion started by: gurpartap
3 Replies

8. Shell Programming and Scripting

loop issue

function ext { echo "THANKS & WELCOME BACK" } function upc { echo "TO EXPORT UPROC GIVE UPROC NAME PER LINE IN THE input.txt and PRESS Y" echo "TO GO BACK PRESS 99" read parm0 if ; then start elif ; then for i in `cat input.txt` ; do echo $i $UXEXE/uxext upr upr=$i... (0 Replies)
Discussion started by: kojo
0 Replies

9. Shell Programming and Scripting

loop issue

I have 2 files one of them has all the all mac addresses and the other one has all the ip addresses. Basically, I want to loop thru those 2 files and generate a configuration like below: host www184.domain.com { hardware ethernet 00:13:72:3B:B4:3A; fixed-address 192.168.0.184; }... (4 Replies)
Discussion started by: kkkk
4 Replies

10. Shell Programming and Scripting

while loop issue

Hi, Following is my code and the file FILE_LIST_EXCESS.txt has 40 file names in it while read LineIn do echo ${LineIn} `ftp -vin << END_INPUT >> ${PID}_DS_GET_Log.log 2>&1 open servername user userid password cd FileDir get ${LineIn} END_INPUT`... (4 Replies)
Discussion started by: mgirinath
4 Replies

Featured Tech Videos