Retaining value outside loop


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Retaining value outside loop
# 1  
Old 02-28-2019
Retaining value outside loop

Hi,

I m new to shell scripting. I did some research and understand that unix treats while and other loops as new shell and hence the variable loose its value outside of the loop.

I found solution for integer variable but in mycase this is a string variable.

here variable loc is a multiline string.

Code:
totalstr=""
echo "$loc" | while IFS= read -r line ; do
totalstr=$totalstr,$line;
done
echo "Final Output:$totalstr"

I wish the get the multiline string in variable totalstr this format: string1,string2,string3,string4

But currently it is blank as it looses scope. Can you let me know what should be done ?
# 2  
Old 02-28-2019
Hi,
maybe so
Code:
totalstr=$(grep -o "\S\+" <<<"$loc" | paste -sd,)
echo "Final Output:$totalstr"

# 3  
Old 02-28-2019
Quote:
Originally Posted by nezabudka
Hi,
maybe so
Code:
totalstr=$(grep -o "\S\+" <<<"$loc" | paste -sd,)
echo "Final Output:$totalstr"

Tried this suggestion but i see nothing empty output:

Code:
more list.sh
#!/bin/bash

loc=$1

totalstr=""

totalstr=$(grep -o "\S\+" <<<"$loc" | paste -sd,)

echo "FINAL:$totalstr"

Quote:
OUTPUT:
/opt/myscripts/list.sh 'string1
string2
string3
'
FINAL:
My system is Linux.

Please suggest.
# 4  
Old 02-28-2019
Try double quoting $1 when assigning it to the loc variable, so <NL> won't be lost.


If your target is to replace <NL> chars in a variable by commas, try

Code:
totalstr=${loc//$'\n'/,}

or even
Code:
totalstr=${1//$'\n'/,}

This User Gave Thanks to RudiC For This Post:
# 5  
Old 02-28-2019
Quote:
Originally Posted by knowyrtech
I m new to shell scripting. I did some research and understand that unix treats while and other loops as new shell and hence the variable loose its value outside of the loop.
This is not completely wrong but also not completely right:

"UNIX" is completely indifferent about this topic. This is a property of the shell and hence the behavior you see depends on which shell you use (and how you configure it).

Most of todays shells have a common ancestor, the "Bourne Shell", which indeed shows the behavior you noticed. In the following sample:

Code:
process | while read line ; do
     var=<something>
done

the while-do..done-loop is the second part of a pipeline and therefore executed in a subshell. Therefore, whatever value you assign to "var", it will be lost outside the loop because after the loop the subshell is simply closed. Notice that defining it up front like this:

Code:
var=<value>
process | while read line ; do
     var=<something>
done

will not help: the variable "var" in the subshell may have the same name as the variable "var" in the script shell but they are not the same at all. The only way you can overcome this is by replacing the pipeline with a redirection:

Code:
while read line ; do
     var=<something>
done < $(process)

Today, the real Bourne Shell is rarely used at all (IIRC it is from the beginning of the eighties) but mostly one of its two main successors: Korn Shell (ksh) and the Bourne Again Shell (bash). Both are (almost) completely backwards compatible with the Bourne Shell which means every shell script written for Bourne Shell should run on Korn shell as well as bash.

In ksh this (rather unintuitive, IMHO) behavior of the Bourne Shell was abandoned and therefore the two examples above work absolutely identical.

Code:
i=1
while [ i -le 100 ] ; do
     (( i += 1 ))
done
print $i

This will produce "100" as output in ksh and not "1", like in the Bourne Shell.

In bash, however, the original behavior of the Bourne Shell was retained and hence would produce "1" too. But because that was unintuitive even for the bash programmers in bash 4 (? i am not sure about the exact version) the shell-option "lastpipe" was introduced. If you set that with

Code:
shopt -s lastpipe

bash will work exactly like ksh (in this regard). Notice, though, that you might still come across bash versions which will not understand this configuration. You will have to do it either this way (redirection):

Code:
totalstr=""
while IFS= read -r line ; do
     totalstr=$totalstr,$line;
done < $(echo "$loc")
echo "Final Output:$totalstr"

or you can do it this way (a so-called "here-document"):

Code:
totalstr=""
while IFS= read -r line ; do
     totalstr=$totalstr,$line;
done <<- EOF
     echo "$loc"
EOF
echo "Final Output:$totalstr"

I hope this helps.

bakunin
This User Gave Thanks to bakunin For This Post:
# 6  
Old 02-28-2019
Why use read for a variable? This is exactly what a for loop is for:

Code:
OLDIFS="$IFS"
IFS="
"
for line in $loc
do
        totalstr=$totalstr,$line;
done
IFS="$OLDIFS"

If your multiline variable is simple enough, i.e. no embedded whitespace besides newline, leading, and trailing -- you can omit the IFS stuff for the same result.
This User Gave Thanks to Corona688 For This Post:
# 7  
Old 03-01-2019
A correction:
Code:
i=1
while [ i -le 100 ] ; do
  (( i += 1 ))
done
print $i

produces 101 in ksh and errors in Bourne shell.
While the following
Code:
i=1
while [ $i -le 100 ] ; do
  i=`expr $i + 1`
done
echo $i

runs on both,
but might produce 1 in an old Bourne shell because it always runs the while loop in a sub shell.
A later Bourne shell has got a fix, but seeing a redirection it still runs the sub shell.
Code:
i=1
while [ $i -le 100 ] ; do
  i=`expr $i + 1`
done </dev/null
echo $i

That means all Bourne shells do not work with the previously suggested <<EOF redirection.
The Posix shell has got it all fixed. And all Posix-compatible shells.
But a pipe really forces a sub shell. Because it is the last part of the pipe. Compare with a simple command
Code:
echo "a:b:c:" | IFS=":" read a b c

Only the ksh has got the (incompatible) modification to run the last part of the pipe in the current shell.

Back to the initial post - that works only in ksh.
The following is portable to all Posix-compatible shells:
Code:
totalstr=$(
# sub shell starts
  sep=""
  echo "$loc" |
  while IFS= read -r line ; do
    # the pipe might force a sub sub shell
    printf "%s" "$sep$line"
    sep=","
  done
# sub shell ends
)
echo "Final Output:$totalstr "

As you can see, a sub shell inherits everything from the current shell, but not vice versa.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Retaining latest file

Hi All, I have a requirement where there are 2 files saved on unix directory with names anil_111 and anil_222. I just have to retain the latest file and delete the old file from the directory. Please help me with the shell script to perform this. Thanks, Anil (7 Replies)
Discussion started by: anil029
7 Replies

2. Shell Programming and Scripting

Retaining whitespaces...

There's an input file(input.txt) which has the following details : CBA BA <Please note the second record has a LEADING WHITESPACE which is VALID> I am using the following code to read the content of the said file line by line: while read p ; do echo "$p" done < input.txt This is the... (1 Reply)
Discussion started by: kumarjt
1 Replies

3. Shell Programming and Scripting

Perl: Problem in retaining values after each loop

use strict; use warnings; open (my $fhConditions, "<input1.txt"); #open input file1 open (my $fhConditions1, "<input2.txt");#open input file2 open (my $w1, ">output1"); open (my $w2, ">output2"); our $l = 10;#set a length to be searched for match our $site="AAGCTT";#pattern to be matched... (1 Reply)
Discussion started by: anurupa777
1 Replies

4. Shell Programming and Scripting

help in retaining leading zero

Hello. I'm trying to add multiple numbers with varying length and with leading zeroes in it. However, I'm getting the sum (totalHashAccountNumber) without the leading zeroes in it. How do I retain the leading zeroes? Please pardon the lengthy code.. I'm getting the hash account number from 2... (2 Replies)
Discussion started by: udelalv
2 Replies

5. Shell Programming and Scripting

retaining file path

hi all, Is there any way to retain file path? echo "Please enter your old filename" read a #user input : /blah/blah1 echo "please enter the new filename" read b #user input : dumb mv $a $b What i would like to do is for the user to enter just the "filename" for the new filename... (2 Replies)
Discussion started by: c00kie88
2 Replies

6. UNIX for Dummies Questions & Answers

Retaining Spaces within a word

Hi Experts, I have a 2 GB flat file which have unicode field, some of them are blanks and its size is 4000 character. In the existing system SED command removes the spaces. Because of this field itself....it is taking almost three days to complete the file processing. I removed sed and... (0 Replies)
Discussion started by: RcR
0 Replies

7. Linux

retaining the evironment varaibles...

Hi all, I wrote a shell script in which one of the if condition i tried to set few variables and exported them...and when i am out of if condition i wish to run one of my script which uses those variables exported. But i found that when i am out of the if statement those variables... (5 Replies)
Discussion started by: priya444
5 Replies

8. Shell Programming and Scripting

Retaining tar.gz after gunzip

gunzip fnam.tar.gz After this command execution... .gz file no longer exists... and only fnam.tar is present. Is it possible to retain the tar.gz file after after using the above command thx in advance. (4 Replies)
Discussion started by: devs
4 Replies

9. Shell Programming and Scripting

variable not retaining value

Bourne shell Solaris I'm trying to set a flag to perform an action only when data is found. So I initialize the flag with: X=0 Then I read the data: if ; then while read a b c do X=1 done < ${inputFile} fi The problem is that X will be set to 1 inside the while loop but when... (5 Replies)
Discussion started by: gillbates
5 Replies

10. Shell Programming and Scripting

Retaining value in var for flag.

I have problem like this : while loop 1 var=some expression 2 if then 3 Do something 4 oldVar=$var 5 fi 6 done Then, I am facing error at line number 2, mentioning invalid argument. Can anyone please help me for, How to retain value in oldVar? (4 Replies)
Discussion started by: videsh77
4 Replies
Login or Register to Ask a Question