Use positional parameters in loop / while syntax in whiptail


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Use positional parameters in loop / while syntax in whiptail
# 1  
Old 08-20-2018
Use positional parameters in loop / while syntax in whiptail

I like to “optimize” / make more like a real program my bash script by replacing repetitious code which utilizes positional parameters.


I am having two issues I cannot solve and would appreciate some assistance with resolving them.



a) how to modify the whiptail checklist “menu” and insert it into whiptail
b) how to replace each case with common code checking only even positional parameters


Each and every choice selected is plain command hence a common function.




I did try the while / do done but it did not echo positional parameters





Code:
  
 whiptail_DEBUG_BASE_arg(){
 
 
 # BUG did not print positional parameters
 x=1
 while [ $x -le 5 ]
 do
   echo "Welcome {${x}} times"
   x=$(( $x + 1 ))
 done
 pause
 
 
 whiptail --title "$1" \
 --checklist \
 --separate-output "Choose:" 20 78 15 \
 "$2" "$3" on \
 "$4" "$5" off \
 "$6" "$7" off \
 "$8" "$9" off \
 "${10}" "${11}" off \
 "${12}" "${13}" off \
 "${14}" "${15}" off \
 "${16}" "${17}" off \
 "${18}" "${19}" off \
 "${20}" "${21}" off \
 "${22}" "${23}" off \
 "${24}" "${25}" off \
 "${10}" "${11}" off \
 "${12}" "${13}" off \
 "${14}" "${15}" off \
 "${16}" "${17}" off \
 "${18}" "${19}" off \
 "${20}" "${21}" off \
 "${22}" "${23}" off \
 "${24}" "${25}" off \
  2>results
 
 
 while read choice
 do
         case $choice in
                 $2)
                 $2   # execute command 

                ;;
                 $4)
                 $4
                 ;;
                 $6)
                 $6
                 ;;
                 $8)
                 $8
                 ;;
                 ${10})
                 ${10}
                 ;;
                 ${12})
                 ${12}
                 ;;
                 ${14})
                 ${14}
                 ;;
                 *) echo "Invalid entry!"
                 ;;
 # BUG echo "$choice"
         esac
 done < results
 pause
 
 
  p { margin-bottom: 0.1in; line-height: 115%; }

# 2  
Old 08-20-2018
Regarding the loop:

Your method would need another redirection. In bash this can be done with
Code:
x=1
 while [ $x -le 5 ]
 do
   echo "${!x}"
   x=$(( $x + 1 ))
 done

It is more common to print $1 and shift the parameters to the left ($2 -> $1, $3 -> $2,...)
Code:
x=1
while [ $x -le $# ]
do
  echo "${1}"
  x=$(( $x + 1 ))
  shift
done

Most easy: loop over the argument values with a for loop
Code:
for arg in "$@"
do
  echo "$arg"
done

In a for loop the argument values are the default:
Code:
for arg
do
   echo "${arg}"
done

# 3  
Old 08-20-2018
Here is partial solution for b item.

I need to take a very hard look at the whiptail - "choice" is the key.
The attached code "loops" thru all checked sections in checklist - they are all even positioning

parameters and there is no need to recheck that.



Code:
echo "START read all positionining parameters" 
pause
 while read choice
 do
 echo $choice
 echo "@line $LINENO"
 pause 
 echo "process command $LINENO" 
 $choice
 pause      # wiil not wait for keyboard 
 done < results
 echo "END read all positionining parameters" 
pause

# 4  
Old 08-21-2018
Moderator's Comments:
Mod Comment Thread title changed from "Use positional parameters in loop / while synatx in whiptail" to "Use positional parameters in loop / while syntax in whiptail" to improve likelihood of finding related thread topics.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Positional parameters in if statement

I am trying to code an if statement that accepts two parameters and see if those parameters are in another file called teledir.txt. If it already exists in the file, it is to say "Entry Exists". If not, I add it to the file and say "Entry Added". This is the code I have so far: if ; then ... (1 Reply)
Discussion started by: Eric7giants
1 Replies

2. UNIX for Beginners Questions & Answers

'sed' with Positional Parameters

I'm new with 'sed' and for sure something still I don't understand yet with it. If you see my output on ">Output..." portion, the new directory still on "source_dir" instead of "dest_dir". You may disregard for the "tar" part, this is just a test script, just for me to understand 'sed' using the... (3 Replies)
Discussion started by: daryl0505
3 Replies

3. Homework & Coursework Questions

Positional Parameters Shell Scripting

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted! 1. The problem statement, all variables and given/known data: STEP 1: Create a Bash shell script (myscript) inside the a2 directory. The script should allow the user to pass... (3 Replies)
Discussion started by: tazb
3 Replies

4. Shell Programming and Scripting

Bash Positional Parameters Question

In a Bash script I used getopts command to let a user does something regards to the selected options. The question is: How do you find out what is the name of the file that user inserted in the command line like the following: The good part is this file is always the last argument in the... (2 Replies)
Discussion started by: bashily
2 Replies

5. Shell Programming and Scripting

checking the positional parameters

Hi all, I have one small requirment... I have prepared one script. we have to pass two possitional parameters to the script. What I want to do is if the parameters are not passed then i dont want the script to start the process... For ex: $ ./a.sh parm1 parm2 #Here, it can start... (7 Replies)
Discussion started by: raghu.iv85
7 Replies

6. UNIX for Dummies Questions & Answers

Positional Parameters

Can someone tell me in more layman's terms what positional parameters are and give a good example? My book again is confusing me. :confused: (1 Reply)
Discussion started by: Straitsfan
1 Replies

7. Shell Programming and Scripting

Resetting the Positional parameters values

Hi, Can any one provide the Unix command to reset the positional parameters? Please see the below example where i have to pass 2 parameters to Shell1.sh. Step1) . ./Shell1.sh 2 3 successfully executed, Then i executed(next step only) the same shell script again,this time no... (4 Replies)
Discussion started by: nmk
4 Replies

8. UNIX for Dummies Questions & Answers

Positional parameters

I need to get file names from commandline arguments, it may be any no of arguements, Using for loop i got but how do i display it, bcoz $i will give the number i is assigned $$i is not working either $($i), i need the names of the files got in the arguement (2 Replies)
Discussion started by: shalu@ibm
2 Replies

9. UNIX for Dummies Questions & Answers

Positional Parameters

Hello, I am using the Bourne shell. I am trying to understand the concept of positional parameters. I do understand that positional parameters: 1. Are initialized by shell 2. Have a max of 9 parameters ($1 to $9) 3. Have no limit on the number of arguments 4. Can be rearranged... (15 Replies)
Discussion started by: ericelysia
15 Replies

10. Shell Programming and Scripting

Positional Parameters

HPUX11.0/Korn Shell I have an old script that takes in a series of arguments when its called. The script is really more of a common set of functions that gets called by other scripts as needed. I have been asked to make this into a menu driven script to rollout to app support for their use during... (2 Replies)
Discussion started by: google
2 Replies
Login or Register to Ask a Question