For Loop queries

01-22-2018

Registered User

54, 0

Join Date: Jan 2010

Last Activity: 16 August 2018, 2:05 PM EDT

Posts: 54

Thanks Given: 14

Thanked 0 Times in 0 Posts

For Loop queries

I have Existing FOR loop in script like below. But the zip should happen for only those years in another file generated dynamically.

Existing FOR LOOP -

Code:

for i in XYZ_*ABC${YEAR_2014}.csv; do
    printf "%s\n" "$i"
    done | zip -@ XYZ_2014.zip  >> $XYZ_2014.log 2>&1 || ERROR_COUNT=$((ERROR_COUNT + 1)) 
    
    
for i in XYZ_*ABC${YEAR_2015}.csv; do
    printf "%s\n" "$i"
    done | zip -@ XYZ_2015.zip  >> $XYZ_2015.log 2>&1 || ERROR_COUNT=$((ERROR_COUNT + 1)) 
    
for i in XYZ_*ABC${YEAR_2016}.csv; do
    printf "%s\n" "$i"
    done | zip -@ XYZ_2016.zip  >> $XYZ_2016.log 2>&1 || ERROR_COUNT=$((ERROR_COUNT + 1))

I have file which has the years for which zip should happen.

dynamic_years.txt

Code:

2014
2015

Updated version should look like below

Code:

for i in XYZ_*ABC${YEAR_2014}.csv; do
    printf "%s\n" "$i"
    done | zip -@ XYZ_2014.zip  >> $XYZ_2014.log 2>&1 || ERROR_COUNT=$((ERROR_COUNT + 1)) 
    
    
for i in XYZ_*ABC${YEAR_2015}.csv; do
    printf "%s\n" "$i"
    done | zip -@ XYZ_2015.zip  >> $XYZ_2015.log 2>&1 || ERROR_COUNT=$((ERROR_COUNT + 1))

It would be helpful if you can let me know how to incorporate the dynamic year change in the FOR loop.

Thanks.

Last edited by Scott; 01-22-2018 at 04:48 PM.. Reason: Please use code tags

weknowd

View Public Profile for weknowd

Find all posts by weknowd

01-22-2018

Administrator Emeritus

9,179, 1,331

Join Date: Jun 2009

Last Activity: 26 February 2019, 5:57 PM EST

Posts: 9,179

Thanks Given: 430

Thanked 1,331 Times in 1,120 Posts

Have you considered reading "dynamic_years.txt" first, in a while-loop, and applying that to the inner for-loop?

e.g.

Code:

while read YEAR; do
  for i in XYZ_*ABC$YEAR.csv; do
    printf "%s\n" "$i"
  done | zip -@ XYZ_$YEAR.zip  >> XYZ_$YEAR.log 2>&1 || ERROR_COUNT=$((ERROR_COUNT + 1))
done < dynamic_years.txt

This User Gave Thanks to Scott For This Post:

Scott

View Public Profile for Scott

Find all posts by Scott

01-23-2018

Registered User

15,129, 5,008

Join Date: Jul 2012

Last Activity: 4 May 2020, 4:31 PM EDT

Location: Aachen, Germany

Posts: 15,129

Thanks Given: 735

Thanked 5,008 Times in 4,483 Posts

Is that for loop really necessary? Wouldn't

Code:

ls -1 XYZ_*ABC$YEAR.csv

do?

This User Gave Thanks to RudiC For This Post:

RudiC

View Public Profile for RudiC

Find all posts by RudiC

Shell Programming and Scripting

For Loop queries

9 More Discussions You Might Find Interesting

1. UNIX Desktop Questions & Answers

/etc/motd - queries

Discussion started by: mescu

2. IP Networking

RDNS Queries

Discussion started by: Lost in Cyberia

3. UNIX for Advanced & Expert Users

How many DNS queries

Discussion started by: raggmopp

4. Programming

Combine 3 queries

Discussion started by: dwr80

5. Shell Programming and Scripting

Few queries regarding awk...

Discussion started by: pinga123

6. Homework & Coursework Questions

Queries

Discussion started by: lakers34kb

7. Shell Programming and Scripting

my queries

Discussion started by: whizkidash

8. UNIX for Advanced & Expert Users

Two small queries

Discussion started by: skyineyes

9. UNIX for Advanced & Expert Users

Some queries...

Discussion started by: 12yearold