Shell Programming and Scripting

Hi Don,

I agree with your point so is there a best way to tune the code, Like remove header from only the file which ends with _01.txt and copy to respective folders before i copy to destination folder and also i am using multiple if conditions because i need to copy the files to respective destination folders based on property file.Below code which is making redundant

Code:

if [ "$i" == "aus" ]
then
if [ -f $file ]
then

      	cp $file /output/aus/
else 
	echo "No aus files"

fi

elif [ "$i" == "nz" ]
if [ -f $file ]
then

      	cp $file /output/nz/
else 
	echo "No nz files"

fi

If you keep showing us the same nested if ladder that you know doesn't work when you have had several posts explaining why that code doesn't work and you seem to ignore all of the suggestions provided, it makes the volunteers here who are trying to help you wonder if there is any reason to respond...

You could start by defining the variables i and file before you use them.

Then you could replace the if ladder used to determine what country code to use with a case statement.

Then you could replace the cp statements with sed or tail commands that have been suggested earlier in this thread.

And, you're probably going to want a while loop reading in the values from your country code file surrounding your case statement.

If I understand what you're trying to do, and I am not at all convinced that I do, it would seem that a more direct approach might help:

Code:

cd /country || exit 1
exit_code=0
while read -r country_code
do	file="${country_code}_01.txt"
	if [ -f "$file" ]
	then	sed 1d "$file" > "/output/$country_code/$file" || exit_code=2
	else	printf 'No %s file (%s) found.\n' "$country_code" "$PWD/$file" >&2
		exit_code=2	# omit this line and remove the redirection in the
				# above printf if the above output is a warning rather
				# than an error.
	fi
done < property.txt
exit $exit_code