Color coding breaks ls?


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Color coding breaks ls?
# 1  
Old 10-18-2016
Color coding breaks ls?

I found a script that almost takes care of a bit of clunkiness in git. I say almost, because when I use it, after it does what it's supposed to do, it breaks my shell, or something. After I use it, I can't use wildcards any more. I tried to run `jshint *.js` as I do a million times a day, but it says it can't find any such files. `ls` does the same thing. I can do `ls` by itself, and everything is there, but `ls *.js` or `ls *` just says the files aren't there. I tried googling, but to tell the truth, I don't have a clear idea of what to google for. "bash script breaks ls" didn't turn up anything useful. Can anyone tell me what is wrong with it?

Code:
green=`tput setaf 2`
reset=`tput sgr0`

git-branch-list() {
  set -f
  git branch | while read line; do
    current="  "
    name=${line##\* }   ## removes leading * for current

    if [ ! "$name" = "$line" ]; then
      current="${green}* "
    fi

    description=`git config branch.$name.description`

    if [ "$description" != "" ]; then
      description=" : $description"
    fi

    echo "${reset}${current}${name}${description}${reset}"
  done
}

# 2  
Old 10-18-2016
The offender seems to be set -f. This option tells the shell to disable expansion of wildcards. Putting set +f at the end of the function should solve the problem.
Code:
    ...
    done
    set +f
}

# 3  
Old 10-18-2016
set -f turns off the wildcard globbing, and the effect is global. (Putting it in a function is a bit misleading.)
I see hardly a need for it in the function because most $variables are in quotes that also disables globbing.
So delete it or disable it with
Code:
# set -f

and harden this line
Code:
  description=`git config "branch.$name.description"`

# 4  
Old 10-18-2016
Thank you guys so much! When I first saw the problem, I didn't associate it with the script. I thought my file system was corrupted. I almost reinstalled the os on my machine. Thanks again.

P.S. It works great, but of course you knew it would.
Login or Register to Ask a Question

Previous Thread | Next Thread

3 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Page breaks and line breaks

Hi All, Need an urgent solution to an issue . We have created a ksh file or shell script which generates 1 DAT file. the DAT file contains extract of a select statement . Now the issue is , when we are executing the ksh file , the output is coimng with page breaks and line breaks . We have... (4 Replies)
Discussion started by: Ayaskant
4 Replies

2. UNIX for Dummies Questions & Answers

How to change the background color in the init 3 mode(not line color)

Hello, I am using RHEL 6.1 on VMware I am searching for a way to change background color (not line by line color wich one can using tput command) basically changing the color of the whole screen to white instead of the default black and changing font color to black and alos would like to... (2 Replies)
Discussion started by: Dexobox
2 Replies

3. UNIX for Dummies Questions & Answers

Why can some servers do color-coding?

What is it that allows emacs (terminal-based) on one server to serve up color-coding while on another server it only comes up black & white? (1 Reply)
Discussion started by: jjinno
1 Replies
Login or Register to Ask a Question