Shell Programming and Scripting

i have some script with some paths inside it. The idea is to some files which is on desktop copy and move to another location. Problem is that inside script is similar to this:

Code:

cp test1.zip /root/help/

because I allways have another zip files, does it possible to have some input which ask me for the name of file, and automaticly change in scripts?

Code:

./script
What is the zip name? test2.zip
.
.

And than it copy test2, not test1. I tried to show you what I need, so please ask me if you need some other information.

Moderator's Comments:

Please use CODE tags as required by forum rules!

Not sure I understand your problem correctly. Did you consider the bash builtins read or select?

Look example. I have zip file called test1..if open my script it wont work cause file to copy in script is test....so how to change that name or whole path inside script. Idea is to use that script inside pcs where is different zip files, and i dont want to change name allways inside scripr.

If your script ALWAYS needs to have a zip file, why not just pass the name of that file to your script as an operand:

Code:

./script file.zip

and change the contents of script to:

Code:

cp "$1" /root/help/

Otherwise, assuming that you are using bash as your shell, why not look at the man page for bash on your system and see if the read or select built-ins would help you do what you want (as RudiC suggested)? If you are not using bash as your shell, look at the man page for the shell you are using for the description of the read built-in in whatever shell you are using.

I did my bash like this

Code:

echo -n "give a name for script [ENTER]: " 
read var_name 
var_dir="/root/Documents/test"
 unzip -o $var_name -d  $var_dir 
mv $var_dir/$var_name.c $var_dir/$var_name.d 
sed 's/#SOMETHING="none"/SOMETHING="none"/' configfile.txt 
service something restart

I did in your way Don, but when type a name of script, I used .zip extension. Should I, or just give a name? Why am I asking. Because when I wrote like this

Code:

var_dir="/root/Documents/test"
unzip -o "$1" -d  $var_dir
mv $var_dir/"$1".c $var_dir/"$1".d

script don't work, cause he can't move file because there is no a file like example_of_file.ZIP.C . Can you get a point? If I mv a file and add just a argument, he took and extension, but i don't want to, just a name.

It looks like you now have a working script. Here are a few comments that you may find useful in future projects:Also note that the command:

Code:

sed 's/#SOMETHING="none"/SOMETHING="none"/' configfile.txt

copies the contents of that configuration file to the user's terminal with the possible removal of an octothorp from some lines in the file; but it makes absolutely no changes to the contents of that file.

Consider the following possible alternative for your script (which changes the contents of configfile.txt instead of just displaying a possibly changed version of that file on the users selected output file:

Code:

#!/bin/bash
IAm=${0##*/}	# Save last component of script name for diagnostics

var_dir="/root/Documents/test"
cd "$var_dir" || exit 1	# Exit if we can't get into our target directory

# Prompt for, get, and verify ZIP filename...
printf 'Enter name of file to be unzipped (with or without .zip extension): '
read var_name 
var_base=${var_name%.zip}
if [ ! -r "$var_base".zip ]
then	printf '%s: %s not found or not readable.' "$IAm" "$var_base".zip >&2
	exit 2
fi

# Unzip the named file into the current directory and move the file extracted
# from that archive with the extension ".c" in place of ".zip" for the archive
# to have the extension ".d" instead of ".c".
unzip -o "$var_base".zip || exit 3
mv "$var_base".c "$var_base".d || exit 4

ed -s configfile.txt <<-"EOF" || exit 5
	g/#SOMETHING="none"/s//SOMETHING="none"/
	w
	1,$p
	q
EOF
service something restart

Note that some implementations of sed allow in-place editing of files (like I am doing with ed in the above script), but that option is not portable (and even if it is available on your system, many consider using it dangerous). I am only using features specified by the POSIX standards in this script (other than the absolute pathname for your shell at the start of the script) since you have not specified what operating system you're using. There are some shortcuts that could be used in bash, but I have avoided using them to make your script more portable.

I have told ed to not only update the file, but to also copy the entire contents of the updated file to standard output (to come closer to matching the output your script produced). If you don't need (or want) to see the contents of the updated file, remove the 1,$p line shown in red from the ed commands in the here-document in the script.

By changing directory to $var_dir before the unzip, we get rid of the need for the unzip -d option and speed up the unzip, mv, and ed commands slightly.

i tried your code. When I enter zip name, i god message that file is not found or not readable..