Shell Programming and Scripting

Evening, I'd like to point out I am very much new to anything regarding scripting, so I apologize If I am / will ask stupid questions.

I am currently trying to design a script that will completely setup a server for a group that needs one, so that they can have a easy way of getting up and going, and I thought I was pretty close, till I change some names around, and suddenly everything broke.

I stole this code, which is where I first found whiptail, and wanted to make a cleanup command so that it will run certain tools to ensure the security of the server after the script was ran. (Wipe mem and free space on hd and so forth)

But when I created the "cleanup" and put it into the function folder, it didn't work. I changed the name of one to "server" and it did, but for some reason I can't get the script to point to the cleanup function.

The link to the actual script is here. Apologies for the mess it's in, I'll work on cleanup later.

(I guess i'll add links in the comments? Getting error saying I can't add to main post.

---------- Post updated at 05:56 AM ---------- Previous update was at 05:55 AM ----------

The original script that I copied from : github.com/snwh/ubuntu-post-install

My Script : github.com/keyxmakerx/Setup/blob/master/run.sh

What does it mean to "point" a script to a function? We can't point scripts....

You get the error message "command not found", if the command (in this case whiptail) is neither an alias, nor a shell function, nor an *executable* program in your PATH (i.e. with the x-bit set).

Again, I don't know the actual terminology I'm trying to use. But in the original script he has it to where functions point to other scripts, and it works w/o editing the path (feel free to take a look at what I ment in the original script)

But when I add something to the script, it does work. I am unsure how he was able to get that to work.

I looked and the original script, and it differed from your version enough, that you should research the error from the other side. As I said, verify at the point, where you invoke the command, the aliases, the functions, and the PATH. For the safe side, also enable shell tracing at this point (using set -x).

Then we get some idea about the problem. My guess is that PATH is different at the point of the call of the command, between the original script and the modified script.

i've turned on set -x to test the script.

Though I'd like to point out that his script ran without editing any path variables, and I even changed the name of one to "server" and it worked. Yet, when I added one, it suddenly fell apart.

But as I said I'll try using this set -x thing to see where the issue lies. Thanks,

---------- Post updated at 07:58 AM ---------- Previous update was at 07:29 AM ----------

So I was able to find out that for some reason another function can't be in the same folder as the one serving the function. No idea cause it works now when i move it to a different folder.

So now I just need to figure out how to make a function launch a script which may seem simple for you smart peoples :P

Thanks for the help.

To be honest, I don't understand this sentence. A "function" is never located in a folder, but always in a script. Also, I don't understand what it means to "serve" a function.

Since I can't even guess what's the problem, and you don't know enough yet about shell programming to formulate the problem, may I suggest that you post some (small!) example code, which illustrates your point.

I don't quite understand it myself, like i said I know nothing about the terminology, I'm just going off of what I am seeing. but.

function thirdparty {
eval `resize`
THIRDPARTY=$(whiptail \
--notags \
--title "Third-Party Installation" \
--menu "\nWhat third-party software would you like to install?" \
--ok-button "Install" \
--cancel-button "Go Back" \
$LINES $COLUMNS $(( $LINES - 12 )) \
'birdie' 'Birdie Twitter client' \

the code above, will bring up a menu with the single option birdie. This was from the original script and would launch the function birdie. But. It wouldn't work for me and I didn't understand why, which seems to be because it was in the same directory as the one where this script resided as well. After moving into a sub folder "actions in this case" it worked.

So now what I want to hopefully accomplish is setting up a clean up script (since this is the most important part of the script as it is the scripts security) that will launch if I change the command to clean up. Which I could just mimick what he did with the birdie function.