User input and run awk using the input


Login or Register for Dates, Times and to Reply

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting User input and run awk using the input
# 1  
User input and run awk using the input

I am trying to allow a user to enter in text and then store that text in a variable $gene to run in an awk command in which those values are used to run some calculations. I am getting syntax errors however, when I try. Thank you Smilie.

The awk runs great if it is a pre-defined file that is used, but it could also be user input.

Code:
/home/cmccabe/Desktop/loop.sh: line 87: syntax error near unexpected token `for'
/home/cmccabe/Desktop/loop.sh: line 87: `for f in /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/*base_counts.txt ; do'

Code:
other() {
printf "\n\n"
printf "Please enter the gene(s) of interest, use a comma between multiple: "; IFS="," read -a gene
        printf "the indicated genes will now be loaded and used to calculate coverage\n"
        [ -z "$gene" ] && printf "\n No ID supplied. Leaving match function." && sleep 2 && return
        [ "$gene" = "end" ] && printf "\n Leaving match function." && sleep 2 && return
        for ((i=0; i<${#gene[@]}; i++))

logfile=/home/cmccabe/Desktop/NGS/API/2-12-2015/process.log
for f in /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/*base_counts.txt ; do
     echo "Start custom panel creation: $(date) - File: $f"
     bname=$(basename $f)
     pref=${bname%%.txt}
     awk '
 NR == FNR {input[$0]; next}
 {
    split($5, a, "-")
    if (a[1] in input) {
         key = $4 OFS $5
         n[key]++
         sum[key] += $7
     }
 }
 END {
     for (key in n) 
         printf "%s %.1f\n", key, sum[key]/n[key]
 }
' /home/cmccabe/Desktop/panels/$gene $f | awk '{split($2,a,"-"); print a[1] "\t" $0}' | sort | cut -f2-> /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/${pref}_genescoverage.bed
      echo "End custom panel creation: $(date) - File: $f"
done >> "$logfile"
printf "coverage calculated and log created\n"
}


Last edited by cmccabe; 02-22-2016 at 07:00 PM.. Reason: updated format
# 2  
Give us a little help here. Your script is failing on line 87. But the script you have shown us isn't nearly that long???

What operating system are you using?

What shell are you using?

Note, however, that the syntax for a shell for loop is different than the syntax for an awk for loop. Shell:
Code:
for ...
do      command...
done

awk:
Code:
for ...
        command

or:
Code:
for ... {
        command
        ...
}

This User Gave Thanks to Don Cragun For This Post:
# 3  
I am on Ununtu 14.04 using bash.
Thank you Smilie.

full code
Code:
menu() {
    while true
    do
        printf "\n please make a selection from the MENU \n
        ==================================
        \t 1  Incidental Findings
        \t 2  CHARGE Syndrome
        \t 3  PFS Syndrome
        \t 4  Other
        ==================================\n\n"
        printf "\t Your choice: "; read menu_choice

        case "$menu_choice" in
        1) incidental ;;
        2) charge ;;
        3) pfs ;;
        4) other ;;
        *) printf "\n Invalid choice."; sleep 2 ;;
        esac
    done
}
echo "$menu_choice"

charge() {
printf "\n\n"
printf "the charge syndrome genes will now be loaded and used to calculate coverage\n"
logfile=/home/cmccabe/Desktop/NGS/API/2-12-2015/process.log
for f in /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/*base_counts.txt ; do
     echo "Start custom panel creation: $(date) - File: $f"
     bname=$(basename $f)
     pref=${bname%%.txt}
     awk '
 NR == FNR {input[$0]; next}
 {
    split($5, a, "-")
    if (a[1] in input) {
         key = $4 OFS $5
         n[key]++
         sum[key] += $7
     }
 }
 END {
     for (key in n) 
         printf "%s %.1f\n", key, sum[key]/n[key]
 }
' /home/cmccabe/Desktop/panels/CHARGE_unix.bed $f | awk '{split($2,a,"-"); print a[1] "\t" $0}' | sort | cut -f2-> /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/${pref}_Chargecoverage.bed
      echo "End custom panel creation: $(date) - File: $f"
done >> "$logfile"
printf "coverage calculated and log created\n"
}
pfs() {
printf "\n\n"
printf "the pfs syndrome genes will now be loaded and used to calculate coverage\n"
logfile=/home/cmccabe/Desktop/NGS/API/2-12-2015/process.log
for f in /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/*base_counts.txt ; do
     echo "Start custom panel creation: $(date) - File: $f"
     bname=$(basename $f)
     pref=${bname%%.txt}
     awk '
 NR == FNR {input[$0]; next}
 {
    split($5, a, "-")
    if (a[1] in input) {
         key = $4 OFS $5
         n[key]++
         sum[key] += $7
     }
 }
 END {
     for (key in n) 
         printf "%s %.1f\n", key, sum[key]/n[key]
 }
' /home/cmccabe/Desktop/panels/PFS_unix.bed $f | awk '{split($2,a,"-"); print a[1] "\t" $0}' | sort | cut -f2-> /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/${pref}_Pfscoverage.bed
      echo "End custom panel creation: $(date) - File: $f"
done >> "$logfile"
printf "coverage calculated and log created\n"
}
other() {
printf "\n\n"
printf "Please enter the gene(s) of interest, use a comma between multiple: "; IFS="," read -a gene
        printf "the indicated genes will now be loaded and used to calculate coverage\n"
        [ -z "$gene" ] && printf "\n No ID supplied. Leaving match function." && sleep 2 && return
        [ "$gene" = "end" ] && printf "\n Leaving match function." && sleep 2 && return
        for ((i=0; i<${#gene[@]}; i++))

logfile=/home/cmccabe/Desktop/NGS/API/2-12-2015/process.log
for f in /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/*base_counts.txt ; do
     echo "Start custom panel creation: $(date) - File: $f"
     bname=$(basename $f)
     pref=${bname%%.txt}
     awk '
 NR == FNR {input[$0]; next}
 {
    split($5, a, "-")
    if (a[1] in input) {
         key = $4 OFS $5
         n[key]++
         sum[key] += $7
     }
 }
 END {
     for (key in n) 
         printf "%s %.1f\n", key, sum[key]/n[key]
 }
' /home/cmccabe/Desktop/panels/$gene $f | awk '{split($2,a,"-"); print a[1] "\t" $0}' | sort | cut -f2-> /home/cmccabe/Desktop/NGS/API/2-12-2015/bedtools/${pref}_genescoverage.bed
      echo "End custom panel creation: $(date) - File: $f"
done >> "$logfile"
printf "coverage calculated and log created\n"
}

while true; do
    read -p "Do you want to get coverage of a specific panel?" yn
    case $yn in
        [Yy]* ) menu; break;;
        [Nn]* ) exit;;
        * ) echo "Please answer yes or no.";;
    esac
done

# 4  
This:
Code:
printf "Please enter the gene(s) of interest, use a comma between multiple: "
IFS="," read -a gene
        printf "the indicated genes will now be loaded and used to calculate coverage\n"

Will not work as you expect.

In fact, you tell to only catch the first genom only, and no other.
Because you say the IFS shall be ',' which is shall be used to seperate the genoms, mainwhile, you only read 1 genom, as 'gene' will be split into as many arguments/variables as the user passes using ','.

Saying:
Replcae the IFS= part to a later procedure, when parsing the user input.
Parsing is done after reading, or if while reading, it must be a limited (say pass 3 genoms, then you mus tread 3 variables - not just one).

I'm no scientist, but afaik a genom doesnt have 'spaces' in between, so they might just seperate the genoms passed by spaces OR coma - since the IFS is removed, that doesnt matter, in fact, its even simpler to work with the passed genoms, if the users do not use ',' to seperate the list.

Only use the red parts if you insist of using coma to seperate the list, if using space its not required at all.
Code:
read genes
oIFS="$IFS"
IFS=","
for gene in $genes;do
	echo "Working with genom: $gene"
done
IFS="$oIFS"

Other than that, please make the according corrections of for loops as Don already stated.

Thank you and hope this helps
This User Gave Thanks to sea For This Post:
# 5  
In case what sea said:
Quote:
Other than that, please make the according corrections of for loops as Don already stated.
wasn't clear, line 84 in your script:
Code:
        for ((i=0; i<${#gene[@]}; i++))

is missing a do and a done.

Since the indentation in your code seems to be random, I can't tell what you intend to include inside that for loop (i.e., where the done should be placed).
This User Gave Thanks to Don Cragun For This Post:
# 6  
I updated the portion of code and it does seem to append the entered genes to a file GENE.txt. The problem is even though each line is one a new line a space is put in after wach so no calculation results.

PTPN11,SCN1A,FBN1

GENE.txt looks like
Code:
PTPN11
SCN1A
FBN1

.

However, if there is only one gene entered PTPN11 then the calculation works fine.

I apologize about the indenting, I am a scientist and not a programmer. Can you recommend some books on correct indentation? Thank you Smilie.

Code:
other() {
printf "\n\n"
printf "%s \n" "Please enter gene(s), use a comma between multiple:"
OLDIFS=$IFS
IFS=","
read -a genes
for (( i = 0; i < ${#genes[@]}; i++ ))
    do
    printf "%s \n" "${genes[$i]}" >> /home/cmccabe/Desktop/panels/GENE.txt
    done
IFS=$OLDIFS


Last edited by cmccabe; 02-23-2016 at 04:17 PM.. Reason: updated code
# 7  
There is no strict rule for indention.
Its purpose is to quickly realize the structure. But people are different.
I usually put for/do/done on one indention level, and increase indention of the code block in between
Same for if/then/else/fi (and further indention of the code blocks in between).
--
If you really use the $gene array (and consequent use of ${gene[ ]} index) then your original IFS="," read -a makes sense, and you don't need the extra IFS stuff that SEA suggested.
Code:
other() {
printf "\n\n"
printf "%s \n" "Please enter gene(s), use a comma between multiple:"
IFS="," read -a genes
for (( i = 0; i < ${#genes[@]}; i++ ))
do
    printf "%s \n" "${genes[$i]}"
done > /home/cmccabe/Desktop/panels/GENE.txt


Last edited by MadeInGermany; 02-23-2016 at 06:20 PM.. Reason: Code suggestion
This User Gave Thanks to MadeInGermany For This Post:
Login or Register for Dates, Times and to Reply

Previous Thread | Next Thread
Thread Tools Search this Thread
Search this Thread:
Advanced Search

Test Your Knowledge in Computers #367
Difficulty: Medium
The Single UNIX Specification specifies vi, so every conforming UNIX system must have it.
True or False?

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

awk command to search based on 5 user input fields

Field1=”” Field2=”” Field3=”” Field4=”” Field5=”” USER INPUT UP TO 5 FIELDS awk -F , '{ if ( $3 == Field1 && $6 == Field2 && $8 == Field3 && $9 == Field4 && $10 == Field5) print $0 }' /tmp/rodney.outD INPUT FILE (Rodney.outD): ... (3 Replies)
Discussion started by: rmerrird
3 Replies

2. Programming

Keyboard User Input in awk language ?

Hi, does someone know how to make a keyboard data input in the AWK programming language ? Regards Zabo (6 Replies)
Discussion started by: Zabo
6 Replies

3. Shell Programming and Scripting

Read input files and merge them in given order and write them to input one param or one file

Dear Friends, I am looking for a shell script to merge input files into one file .. here is my idea: 1st paramter would be outfile file (all input files content) read all input files and merge them to input param 1 ex: if I pass 6 file names to the script then 1st file name as output file... (4 Replies)
Discussion started by: hyd1234
4 Replies

4. Shell Programming and Scripting

Script to delete files with an input for directories and an input for path/file

Hello, I'm trying to figure out how best to approach this script, and I have very little experience, so I could use all the help I can get. :wall: I regularly need to delete files from many directories. A file with the same name may exist any number of times in different subdirectories.... (3 Replies)
Discussion started by: *ShadowCat*
3 Replies

5. Shell Programming and Scripting

Awk replacing file with user input

this section of the awk code i have here takes file to work with from the user. the user specifies the file name from the command line and the file name is assigned to the variable $FLIST awk 'BEGIN { while((getline < "'${FLIST}'")>0) S FS="\n"; RS="}\n" } now, i dont want... (5 Replies)
Discussion started by: SkySmart
5 Replies

6. Shell Programming and Scripting

How to get the user input recursively until the user provides valid input

Hi, echo "Enter file name of input file list along with absolute path : " read inputFileList if then for string in `cat inputFileList` do echo $string done else echo " file does not exist" fi From the above code, if the user enters a invalid file... (1 Reply)
Discussion started by: i.srini89
1 Replies

7. Shell Programming and Scripting

How to take input from user or awk script?

Hi Jim, I have following script,i which i need to take dynamic value . script, nawk -v v1=grep"INT_EUR" $propertifilename | cut -d"=" -F2` -F'~' '{if (NF-1 !=v1) {print "Error in " $0 " at line number "NR" tilde count " N-1}}' $filename In the above script i want to use INT_EUR as a variable... (2 Replies)
Discussion started by: Ganesh Khandare
2 Replies

8. Shell Programming and Scripting

Reading specific contents from 1 input files and appending it to another input file

Hi guys, I am new to AWK and unix scripting. Please see below my problem and let me know if anyone you can help. I have 2 input files (example given below) Input file 2 is a standard file (it will not change) and we have to get the name (second column after comma) from it and append it... (5 Replies)
Discussion started by: sksahu
5 Replies

9. Shell Programming and Scripting

AWK set FILENAME via user input

I am trying to write a awk script that prompts user for input to set the FILENAME varable. I can get it set, but I think awk is not doing anything with it. this is what I have so far #!/usr/bin/nawk -f BEGIN { FILENAME = "" printf "Enter name of file to check in : " ... (2 Replies)
Discussion started by: timj123
2 Replies

10. Shell Programming and Scripting

awk user input

Using the following I'm trying to print the user's response to the prompt Y / N but I get nothing other than the contents of $1? awk '{ printf($1 " ? (Y/N)") getline myresponse < "-" system("read myresponse") if (myresponse == "Y") { print $1... (17 Replies)
Discussion started by: gefa
17 Replies

Featured Tech Videos