Issue with while loop?


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Issue with while loop?
# 1  
Old 01-29-2016
Issue with while loop?

Hi,

I have prepared a script to search for backup file information on the Linux server. Script works fine for the most part except the echo statement inside an IF conditional block displays the message ''snapshot directory not found on xxxxx" even though the .snapshot directory is found a specified path. Here is the code.

Code:
#!/bin/bash
fdate=`date "+%Y-%m-%d"`
#set -x
df -h | grep sbl| awk '{print $5}' > /home/greg/fs.out
if [ ! -s /home/greg/fs.out ]
then
 echo "No netapp filesystems found"
 exit 1
else
 echo "netapp filesystems found. continuing to the next step"
while read line
do
echo $line
if [ ! -d "${line}"/.snapshot ]
then
echo "snapshot directory not found on "$line""
else
  cd ${line}/.snapshot
  latest_bkp=`ls -l |grep -v snapmirror | tail -1|awk '{print $9}'`
  bkp_fldr_timestamp=`echo "$latest_bkp"|cut -f3 -d .|cut -f1 -d _`
        if [ ${fdate} != ${bkp_fldr_timestamp} ]
        then
                echo "Today's backup is missing for $line on `hostname`"
        else
                echo "File system backup has been taken for $line on `hostname`"
        fi
fi
done <  /home/greg/fs.out
fi
rm /home/greg/fs.out
exit 0

Here's the output when I execute the script.

Code:
[greg@sbldev01 ~]$ ./fs_bkpchk.sh
netapp filesystems found. continuing to the next step

snapshot directory not found on
/sblmnt/sb_devm2_sbl_01
File system backup has been taken for sblmnt/sb_devm2_sbl_01 on sbldev01

snapshot directory not found on
/sblmnt/sb_devm2_sbl_02
File system backup has been taken for /sblmnt/sb_devm2_sbl_02 on sbldev01

snapshot directory not found on
/sblmnt/sb_devm2_sbl_03
File system backup has been taken for /sblmnt/sb_devm2_sbl_03 on sbldev01

Any pointers will be appreciated.

Thanks,
Greg
# 2  
Old 01-29-2016
The NetApp .snapshot is not visible in all cases.
Try
Code:
[ -d "${line}"/.snapshot/. ]

or use the exit status of cd
Code:
if cd "${line}"/.snapshot
then
   echo "backup"
else 
   echo "does not exist"
fi

This User Gave Thanks to MadeInGermany For This Post:
# 3  
Old 01-29-2016
From what i've found, it seems to valid for mountpoints with spaces in any of the directory structure segments.

With this code, only the first part of a path with a space will be read, and will be missing in the tempfile all together.
Code:
df -h | grep sbl| awk '{print $5}' > /home/greg/fs.out

So, one could remove awk alltogether, but then read the file differently:
Code:
while read _ _ _ _ _ line

Specialy since the 5th variable is only the percentage used, we only name/use the 6th variable, which will include any later variable (path with spaces) as well.

Did some other small changes.
Hope this helps
Code:
#!/bin/bash
#set -x
#
#	Variables
#
	TMP=$HOME/tmp/${0##*/}-fs.out
	HOSTNAME="${HOSTNAME:-$(hostname)}"
	# This will print nothing on my system
	SEARCH="sdb" ## sbl sdb
#
#	Function
#
	check4missing() { # VALUE
	# Compares the current date versus the latest found backup dir
	# Returns false if today's date is not found
		fdate=$(date "+%Y-%m-%d")
		latest_bkp=$(ls -l |grep -v snapmirror | tail -1|awk '{print $9}')
		bkp_fldr_timestamp=$(echo "$latest_bkp"|cut -f3 -d .|cut -f1 -d _)
		if [ "${fdate}" != "${bkp_fldr_timestamp}" ]
		then	return 1
		else	return 0
		fi
	}
#
#	Action
#
	df -h | grep $SEARCH > "$TMP"
#
#	Display
#
	if [ -s "$TMP" ]
	then	# Tempfile has content
		while read _ _  _ _ line
		do 	
			this_snapshot="${line}/.snapshot"
			if [ -d "$this_snapshot" ]
			then
				cd "$this_snapshot"
				if check4missing
				then
					echo "Today's backup is missing for $this_snapshot on $HOSTNAME"
				else
					echo "File system backup has been taken for $this_snapshot on $HOSTNAME"
				fi
			else
				echo "snapshot directory not found on \"$this_snapshot\""
			fi
		done < "$TMP"
	else	# Tempfile is empty
		echo "No netapp filesystems found"
		exit 1
	fi
	rm "$TMP"
	exit 0


Last edited by sea; 02-01-2016 at 07:53 AM.. Reason: changed code
This User Gave Thanks to sea For This Post:
# 4  
Old 01-29-2016
Thanks sea for rewriting the code. However when I execute your code on the server, I get the following output.

Code:
snapshot directory not found on ""
snapshot directory not found on ""
snapshot directory not found on ""
snapshot directory not found on ""
snapshot directory not found on ""
snapshot directory not found on ""

I verified that the temp file has some file system entries.
# 5  
Old 01-29-2016
One _ too many.
4 fields go to _ and the 5th should go to line
Code:
while read _ _ _ _ line

# 6  
Old 01-29-2016
ok, now I get a different output.

Code:
snapshot directory not found on ""
Today's backup is missing for /sblmnt/sb_devm2_sbl_01/.snapshot on sbldev01
snapshot directory not found on ""
Today's backup is missing for /sblmnt/sb_devm2_sbl_02/.snapshot on sbldev01
snapshot directory not found on ""
Today's backup is missing for /sblmnt/sb_devm2_sbl_03/.snapshot on sbldev01

i verified all 3 file systems listed above have .snapshot directories in them and they have today's backup files.
# 7  
Old 02-01-2016
Removed the _ too much.
Changed the variable name on the 'not found' line.

I'm confused... my DF prints the moutpoint on the 6th, not on the 5th.. (the 5th is usage, as you see)
Code:
0 ~ $ LC_ALL=C df -h
Filesystem             Size  Used Avail Use% Mounted on
dev                    3.9G     0  3.9G   0% /dev
run                    3.9G  820K  3.9G   1% /run
....

Please change your working dir to: /sblmnt/sb_devm2_sbl_03/
And print the output of:
Code:
ls -al
df -h
[ -w .snapshot ] ; echo $?

Or even better, print the output of this as well:
Code:
bash -xv ./fs_bkpchk.sh

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Issue when doing a loop

Hi, I just have started learning shell scripting (sh). Why do i only get the date? while read dt do echo "Date : ${dt} sed -n '/${dt}/,/${dt}/p' file1.log | grep -w ERROR done < date1.dat INPUT - date1.dat 2019-04-05 04:58:25 2019-04-05 04:58:26 2019-04-05 05:00:56... (3 Replies)
Discussion started by: margel
3 Replies

2. Shell Programming and Scripting

Issue with for loop

Hi Team, I have for loop in my shell script. Which basically loop through all files in the directory, When some files are in the directory it works just fine. But if there are no files at all..still the for loop try to execute. Please help. Below is the code. #!/bin/ksh echo "Program... (5 Replies)
Discussion started by: bharath561989
5 Replies

3. Shell Programming and Scripting

While Loop issue

Hi, i=0 t5=6000001 while do i=`expr $i + 1` t5=`expr $t5 + 1` echo $t5 done I am able to increment "col3" value but unable to get col1,col2 value. Input: t1=10001 t2=abc t3=ghkc (5 Replies)
Discussion started by: onesuri
5 Replies

4. Shell Programming and Scripting

Issue with using While loop

Hi, I am trying to move a file from remote server to local server and when the transfer completes successfully i call a script in remote server to remove the file which was successfully transferred. I do this by first getting the list of file in remote server and move the text file to local... (8 Replies)
Discussion started by: funonnet
8 Replies

5. Shell Programming and Scripting

for-while loop issue

sup experts..i had a script which was bugging me..was hoping someone could point out the issue here Input file: space separated 2 columns I wanted to print out the 2 columns after assigning them to variables ( bascially the same output but iterate through line by line ). The code worked... (7 Replies)
Discussion started by: foal_newbie
7 Replies

6. Shell Programming and Scripting

until loop issue.

Hi, my script is waiting for 3 files to come to a folder for 30 min but even when all the files arrive in the folder it's still waiting for these three files. Files can come with in 2 min and I want it to start processing them immediately after all the files arrive in the folder. until ; do... (3 Replies)
Discussion started by: gurpartap
3 Replies

7. Shell Programming and Scripting

loop issue

function ext { echo "THANKS & WELCOME BACK" } function upc { echo "TO EXPORT UPROC GIVE UPROC NAME PER LINE IN THE input.txt and PRESS Y" echo "TO GO BACK PRESS 99" read parm0 if ; then start elif ; then for i in `cat input.txt` ; do echo $i $UXEXE/uxext upr upr=$i... (0 Replies)
Discussion started by: kojo
0 Replies

8. Shell Programming and Scripting

loop issue

I have 2 files one of them has all the all mac addresses and the other one has all the ip addresses. Basically, I want to loop thru those 2 files and generate a configuration like below: host www184.domain.com { hardware ethernet 00:13:72:3B:B4:3A; fixed-address 192.168.0.184; }... (4 Replies)
Discussion started by: kkkk
4 Replies

9. Shell Programming and Scripting

while loop issue

Hi, Following is my code and the file FILE_LIST_EXCESS.txt has 40 file names in it while read LineIn do echo ${LineIn} `ftp -vin << END_INPUT >> ${PID}_DS_GET_Log.log 2>&1 open servername user userid password cd FileDir get ${LineIn} END_INPUT`... (4 Replies)
Discussion started by: mgirinath
4 Replies

10. Shell Programming and Scripting

Help With A For Loop Issue

I was wondering how I can modify this for loop, so it only loops through the filenames that do not have an ".old" extension. for filename in $(ls "$1") do echo $filename | grep '\.old$' > /dev/null if then mv $1/$filename $1/$filename.old fi done (5 Replies)
Discussion started by: ralts01
5 Replies
Login or Register to Ask a Question

Featured Tech Videos