Loop counter resets by itself


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Loop counter resets by itself
# 8  
Old 05-24-2015
Quote:
Originally Posted by Flavius
Code:
file_total=`ls -1 $1 | wc -l | tr -d " "`


First, you don't need -1 when the output of ls is not going to a terminal.

Second, the command will fail if $1 contains whitespace or other pathological characters.

Third, there is no need for tr; it has been a long time since wc's output was preceded by a space.
And if it were, you could remove it with:
Code:
file_total=$(( $(ls "$1" | wc -l) ))

Or:

Code:
file_total=$(ls "$1" | wc -l)
file_total=${file_total// /}

But you can do it without any external commands:

Code:
file_list=( "$1"/* )
file_total=${#file_list[@]}

Quote:
Code:
CDR_count=0
CDR_match=0
echo > CDR.tmp

for _file in `ls -1 $1`


See the first 2 comments above.

It can fail even if you quote $1.
Quote:
Code:
  file_count=`expr $file_count + 1`


(( ++file_count ))
Quote:
Code:
     cat $_file | while read _line


UUOC and unquoted variable
Quote:
Code:
     do

             if [ "$_line" = "CDRCCN.ChargingDataOutputRecord.onlineCreditControlRecord" ]; then

                CDR_count=`expr $CDR_count + 1`


(( ++CDR_count ))
Quote:
Code:
                echo "Files processed: $file_count / $file_total       CDRs match : $CDR_match / $CDR_count"

                if [ "`grep "servedAccount : '$2'" CDR.tmp`" != "" ]; then


Code:
if grep "servedAccount : '$2'" CDR.tmp; then

Quote:
Code:
                   CDR_match=`expr $CDR_match + 1`


Code:
(( ++CDR_match ))

Also, if you want to retain the value of variables set in the last process in a pipeline, use:
Code:
shopt -s lastpipe

These 2 Users Gave Thanks to cfajohnson For This Post:
# 9  
Old 05-25-2015
Quote:
Originally Posted by cfajohnson
[..]
Code:
file_total=$(( $(ls "$1" | wc -l) ))

Always a pleasure to read your posts! Nice way of removing spaces by using arithmetic expansion.
Quote:
[..]
But you can do it without any external commands:

Code:
file_list=( "$1"/* )
file_total=${#file_list[@]}

[..]
Other benefits of this method are that it also correctly counts file names that contain newlines (whereas ls|wc -l does not) and that there are no command line length limitations..
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

While loop with limit counter

#!/usr/bin/ksh c=0 while ]; do echo /tmp/unex NOT found, iter : $c; ((c = $c + 1)); sleep 2; done so, the above counter doesn't work, already tried both -lt & -gt, and changed || to && so what am I missing? Thanks in advance (5 Replies)
Discussion started by: unexistance
5 Replies

2. Shell Programming and Scripting

Loop usage with counter

Hi friends, I just want to try some thing with shell using loop and counter I have 30 Directory, in each directory number of files say 5, 10, 20 etc... directory_1 directory_2 directory_n what I want to do is read files from directory_1 say 5 files if my counter is like this m=2000 ... (6 Replies)
Discussion started by: Akshay Hegde
6 Replies

3. Homework & Coursework Questions

Min/Max/counter/while loop from file

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted! 1. The problem statement, all variables and given/known data: The program is supposed to read in text from a given file ( different samples provided in the homework but not... (1 Reply)
Discussion started by: c++newb
1 Replies

4. Shell Programming and Scripting

How to implement the counter in loop?

Hi, I am working on a script where I need to add one functionality i.e. to could the number of tar files at particular location...but the script is working in below way. 1) create sandbox 2) Drop old member function 3) addmember function 4) Apply checkpoint lable 5) Resync operation(This... (1 Reply)
Discussion started by: anuragpgtgerman
1 Replies

5. Shell Programming and Scripting

File merging based on different counter loop

hello, File 1 main Group sub group MIT VAR_1D_DATA_TYPE 23-03-2012 MIT VAR_1D_DATA_TYPE 22-03-2012 MIT VAR_10D_DATA_TYPE 23-03-2012 MIT VAR_10D_DATA_TYPE 22-03-2012 MIT ... (0 Replies)
Discussion started by: manas_ranjan
0 Replies

6. Shell Programming and Scripting

loop with a counter on a constant in bash

Hello Everyone, I'm in need of assistance on creating a script with a counter on a certain string. Basically this script opens a log file and displays certain log data. There are two key words in the log. START and FINISH. In between the START and FINISH is a variable ACTNUMBER. It will... (1 Reply)
Discussion started by: rxc23816
1 Replies

7. Shell Programming and Scripting

S# in a for loop - concatenate $(loop counter)

Hi, hope I am posting in the right section. My problem is that I have 2 or more arguments passed and I want to check if the arguments passed exists or not. The first argument should not exist and the remaining others should exist. example: ./shells.sh argument1 argument2 argument3 ... (5 Replies)
Discussion started by: fight4love
5 Replies

8. Homework & Coursework Questions

Incrementing Variable resets outside of while loop

1. The problem statement, all variables and given/known data: Variable is resetting to 0 after incrementing in while loop My bit of scripting displays the current users logged in the machine. Then it reads in a specific username and displays the processes for that user. The portion that I... (3 Replies)
Discussion started by: ratzlaff
3 Replies

9. Shell Programming and Scripting

Using the counter of a for loop in command line parameter

Say I have (in psuedocode) For i=1 to 10 tar cvfb /... 5*i /junk(i) end What I mean is that I want each successive for loop to have the block size parameter be 5 times the current counter. This isn't my actual code, just a stupid example...So the question is how do I descrive that parameter... (2 Replies)
Discussion started by: jeriryan87
2 Replies

10. Shell Programming and Scripting

Loop counter variable display

Hello everyone, how can I send output to the screen from a running script or tcl, in such a way that if a loop is executing I will see the rolling counter on my screen as the records are processed in the loop. I do not want the screen to scroll, though. In other words can a var's value be painted... (2 Replies)
Discussion started by: lifespan
2 Replies
Login or Register to Ask a Question

Featured Tech Videos