Shell Programming and Scripting

Hi all,

I want to dynamically set variables in a bash script. I made a naive attempt in a while loop that hopefully can clarify the idea.

Code:

n=0; echo "$lst" | while read p; do n=$(($n+1)); p"$n"="$p"; done

The error message is:

Code:

bash: p1=line1: command not found
bash: p2=line2: command not found
bash: p3=line3: command not found
bash: p4=line4: command not found
bash: p5=line5: command not found

I want each line of a list of arbitrary length and content stored in variables, so the content of a specific line can be identified by the variable p[1-5] (in this example).

Any suggestions welcome! If possible, I'd prefer a while loop solution.

Thank you for reading!

Try using eval:

Code:

eval p"$n"="$p"

It's not a very good practise to set variables like this though. A much better way is to set arrays:

Code:

$ a[1]=test
$ echo ${a[1]}
test

Thank you! eval works well for this particular purpose!

Can you elaborate on why it isn't good practice this way?

I not familiar with arrays, so i can't figure out how to implement it on the basis of your example.

You could implement an array like this for example:

Code:

n=0; echo "$lst" | while read p; do n=$(($n+1)); a[$n]="$p"; done

Or this:

Code:

echo "$lst" | while read p ; do a[${#a[@]}]="$p" ; done

the use of eval should be limited as much as possible as it could be used to execute malicious code and it can be very confusing...

Thank you for clarifying and for your example!

This is a poor example because, if someone tried to name an array `rm -Rf ~/`, eval would happily execute that and erase your home directory.

We get dozens and dozens of requests for dynamic variable names, but they don't generally make much sense. How would you even use those variables afterwards? If you take a good look at what you're trying to do, there's usually ways to do it in a far more straightforward way.

One way is arrays. Another way is just not storing the data at all -- you don't have to keep absolutely everything stored in memory at all times. If you only intend to use the lines one at a time, there's no point -- just use them as you read them, then throw them away.

I agree with the use of eval, but I'm confused with your response to my example where I'm suggesting arrays instead of eval. In what way is this a poor example?