Visit The New, Modern Unix Linux Community


Bash script deleting my files, and editing files in subdirectories question


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Bash script deleting my files, and editing files in subdirectories question
# 1  
Bash script deleting my files, and editing files in subdirectories question

Code:
#!/bin/bash
#
name=$1
type=$2

number=1

for file in ./**
do
	if [ $number -lt 10 ]
	then
		filenumber=00$number
	elif [ $number -lt 100 ]
	then
		filenumber=0$number
	fi

	tempname="$name""$filenumber"."$type"

	if [ -f $file ]
	then
		if [ ! -x $file ]
		then
			mv $file $tempname
		fi
	fi

	((number++))
done

So the purpose of this code is to rename files in a directory to a new name, number, and filetype. However anything that has already been renamed in my folder gets deleted. Like if I have:

file001.jpg, file002.jpg, file003.jpg, file004.jpg
newfile1, newfile2, newfile3, newfile4

when I run: ./renumber file jpg
I end up with:

file005.jpg, file006.jpg, file007.jpg, file008.jpg

and my original 4 are gone. What happened?

ALSO!
How can I get the program to also do the same to files in sub directories?
# 2  
This would take some work to keep them in subdirs. I see you already use the globstar ./** for recursion but didn't include the shopt -s globstar
This is bash4 feature, so let's write bash code and use all of it's nice features:

Code:
#!/bin/bash

(( $# == 2 )) || {
        printf 'Usage: %s <prefix> <ext>\n' "$0"
        exit 1
}

prefix=$1
type=$2
number=1
shopt -s globstar

for file in ./**; do
        [ -f "$file" ] || continue # only "regular" files

        printf -v new '%s%03d.%s' "$prefix" $((number++)) "$type"

        # skip to next file if name conflict
        [ -f "$new" ] && continue
        [ -x "$file" ] && continue

        mv "$file" "$new"
        echo "$file -> $new"

done

Code:
mute@thedoctor:~/temp/TheGreatGizmo$ touch IMG_{0000..0005}.jpg more/IMG_{000..0005}.jpg
mute@thedoctor:~/temp/TheGreatGizmo$ ls
IMG_0000.jpg  IMG_0001.jpg  IMG_0002.jpg  IMG_0003.jpg  IMG_0004.jpg  IMG_0005.jpg  more  script
mute@thedoctor:~/temp/TheGreatGizmo$ ./script
Usage: ./script <prefix> <ext>
mute@thedoctor:~/temp/TheGreatGizmo$ ./script file jpg
./IMG_0000.jpg -> file001.jpg
./IMG_0001.jpg -> file002.jpg
./IMG_0002.jpg -> file003.jpg
./IMG_0003.jpg -> file004.jpg
./IMG_0004.jpg -> file005.jpg
./IMG_0005.jpg -> file006.jpg
./more/IMG_0000.jpg -> file007.jpg
./more/IMG_0001.jpg -> file008.jpg
./more/IMG_0002.jpg -> file009.jpg
./more/IMG_0003.jpg -> file010.jpg
./more/IMG_0004.jpg -> file011.jpg
./more/IMG_0005.jpg -> file012.jpg
mute@thedoctor:~/temp/TheGreatGizmo$ ls .
file001.jpg  file003.jpg  file005.jpg  file007.jpg  file009.jpg  file011.jpg  more
file002.jpg  file004.jpg  file006.jpg  file008.jpg  file010.jpg  file012.jpg  script

These 2 Users Gave Thanks to neutronscott For This Post:
# 3  
Could you avoid bash4 (and globstar) requirement by replacing:

Code:
shopt -s globstar

for file in ./**; do
        [ -f "$file" ] || continue # only "regular" files

with

Code:
find . -type f -print | while read file; do

This User Gave Thanks to Chubler_XL For This Post:
# 4  
Sorry, I'm really new to bash. Could someone explain how each part of these code segments work in 3 year old terms? And what the second one does? I like to understand what is going on. These were taken from Neutronscott's reply. Thanks

EDIT: Okay, I see what you did here. Though I'm not sure what the "$0" is for on the end of the printf statement.
Code:
(( $# == 2 )) || {
        printf 'Usage: %s <prefix> <ext>\n' "$0"
        exit 1
}

Code:
shopt -s globstar

Code:
continue # only "regular" files

EDIT: and I understand everything here other than '%s%03d.%s'
Code:
printf -v new '%s%03d.%s' "$prefix" $((number++)) "$type"

Code:
# skip to next file if name conflict
[ -f "$new" ] && continue
[ -x "$file" ] && continue


Last edited by TheGreatGizmo; 02-03-2014 at 10:10 PM..
# 5  
continue just resumes at the next iteration of the enclosing for loop. In this particular code that means stop processing the current file and start processing the next file.

The current code is less than ideal as it will rename existing renamed files and skip files.

see below:

Code:
$ touch abc_{0000..0003} more/img_{0000..0003} file{000..002}.jpg
$ ls
abc_0000  abc_0001  abc_0002  abc_0003  file000.jpg  file001.jpg  file002.jpg  more  script
$ ./script file jpg
./abc_0002 -> file003.jpg
./abc_0003 -> file004.jpg
./file000.jpg -> file005.jpg
./file001.jpg -> file006.jpg
./file002.jpg -> file007.jpg
./more/img_0000 -> file008.jpg
./more/img_0001 -> file009.jpg
./more/img_0002 -> file010.jpg
./more/img_0003 -> file011.jpg
$ ls
abc_0000  file003.jpg  file005.jpg  file007.jpg  file009.jpg  file011.jpg  script
abc_0001  file004.jpg  file006.jpg  file008.jpg  file010.jpg  more


This slight update should be a little safer.

Code:
(( $# == 2 )) || {
        printf 'Usage: %s <prefix> <ext>\n' "$0"
        exit 1
}

prefix=$1
type=$2
number=1

find . -type f -print | while read file; do

        # skip already processed files
        [[ "$file" = ./$prefix[0-9][0-9][0-9].$type ]] && continue

        # skip executable files (eg this script)
        [ -x "$file" ] && continue

        # find next unused sequence
        while true
        do
            printf -v new '%s%03d.%s' "$prefix" $((++number)) "$type"
            [ -f "$new" ] || break
        done

        mv "$file" "$new"
        echo "$file -> $new"

done

This User Gave Thanks to Chubler_XL For This Post:

Previous Thread | Next Thread
Thread Tools Search this Thread
Search this Thread:
Advanced Search

Test Your Knowledge in Computers #872
Difficulty: Medium
In computer science, self-modifying code is code that alters its own instructions while it is executing.
True or False?

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Help with running a script on files located in subdirectories

Hello everyone, I'm am a newbie to coding so I am reaching out in hopes that I can get some help from this forum. I am trying to run the script below from a single directory, however the directory has many subfolders. In each of those subfolders is a file, uniquely named to that specific... (3 Replies)
Discussion started by: azurite
3 Replies

2. Shell Programming and Scripting

Append string to all the files inside a directory excluding subdirectories and .zip files

Hii, Could someone help me to append string to the starting of all the filenames inside a directory but it should exclude .zip files and subdirectories. Eg. file1: test1.log file2: test2.log file3 test.zip After running the script file1: string_test1.log file2: string_test2.log file3:... (4 Replies)
Discussion started by: Ravi Kishore
4 Replies

3. Shell Programming and Scripting

Unzip all the files with subdirectories present and append a part of string from the main .zip files

Hi frnds, My requirement is I have a zip file with name say eg: test_ABC_UH_ccde2a_awdeaea_20150422.zip within that there are subdirectories on each directory we again have .zip files and in that we have files like mama20150422.gz and so on. Iam in need of a bash script so that it unzips... (0 Replies)
Discussion started by: Ravi Kishore
0 Replies

4. UNIX for Dummies Questions & Answers

Crontab deleting files command question

Hello out there, Our system has a pdf generator that creates pdf files. We dont need them pas 120 days. So I have this command in my crontab. I currently set it to "0" for testing. But normally have it set to -mtime 120 to remove files out of the folders from PDF out to several other potential... (7 Replies)
Discussion started by: vsekvsek
7 Replies

5. Shell Programming and Scripting

Script to Archive Files from Subdirectories

Hello, I have a CentOS server that contains a 'storage' directory. Within that directory, there could be any number of subfolders (all with unique names that match usernames). Under each username folder, there are two additional folders: db and files /STORAGE/user1/db/... (3 Replies)
Discussion started by: JasonH
3 Replies

6. Shell Programming and Scripting

Editing lists of integers in 1d files with bash shell

Hi, I need a script that will: 1. Go through about 20 different folders, each containing about 20 1d files. The 1d files go something like this: 22.253 37.707 78.117 112.374 127.944 156.067 180.956 233.785 249.256 ... (1 Reply)
Discussion started by: ac130pilot
1 Replies

7. Shell Programming and Scripting

Bash: Gzip files in Directory and itīs Subdirectories

Hello dear Community, I have a task to wrtie a script which will gzip not zipped files in a directory and itīs subdirectories. I succeeded in gzippung the directory but not the subdirectories: #/bin/bash #go to the directory where to zip cd $1 #Zip unzipped files for i in `ls | xargs... (2 Replies)
Discussion started by: JamesCarter
2 Replies

8. Web Development

bash script editing my apache config files

okay i'm going to try to say this uber-simple: I use dropbox (file-sync service). in order for dropbox sync files, they must be its children eg. somewhere under /home/jzacsh/Dropbox]. I want to now use it to keep my development files in sync across my machines: easy: just move my dev. files... (2 Replies)
Discussion started by: jzacsh
2 Replies

9. Shell Programming and Scripting

Script for editing column files

Hi, I have been doing files editing (using "vi") to change the period (e.g. 0902 to 0903) for 100 files each week as shown in the example below. I would like to have a script to solve this manual files editing. Please advice. Example: Change from: ... (2 Replies)
Discussion started by: JunZ
2 Replies

10. Solaris

editing files with script

hi guys, We have to implement new local (/etc/default/login) USER security policy on almost 50 stations. so editing /etc/default/login and /etc/default/passwd will be way too long work. Can we do the same using some script, I mean editing the above files and putting variables as RETRIES=3, ... (5 Replies)
Discussion started by: Asteroid
5 Replies

Featured Tech Videos