[Solved] Read and validate input arguments

Thread Tools Search this Thread
Top Forums Shell Programming and Scripting [Solved] Read and validate input arguments
# 1  
Old 01-09-2014
[Solved] Read and validate input arguments

I need to get input arguments, as well as validate them. This is how I'm reading them:
args="$@" # save arguments to variable 
## Read input arguments, if so 
while [ $# -ge 1 ]; do 
    case $1 in 
        -v | --verbose ) verbose=true;; 
        -z | --gzip ) compression="gz";; 
        -b | --bzip2 ) compression="bz";; 
        -n | --no-compress) compression="none";;
        -h | --help ) showUsage; exit 0 ;; 
        *) echoErr "Invalid option $1. Use -h or --help to show usage"; exit 1 ;; 

My problem is how validate incompatible arguments. For instance, it's not allowed to call script with both "-z" and "-b", or "-n" and "-z", and so on.
I stored input arguments into a variable called "args" (because shift command unsets them).
Is there a simple way to validate other than a double loop? This is what occurred to me, but is really ugly. Any hint to improve?
args="$@" # store into args variable
# [...] previous while
argsIterate=($args) # I don't know how to iterate over $args, except convert into an array
for (( i=0;i<${#argsIterate[@]};i++)); do # 1st loop over all arguments
    for (( j=i+1;j<${#argsIterate[@]};j++)); do # 2nd loop over rest arguments
        if ([ "${argsIterate[${i}]}" == "-z" ] && ([ "${argsIterate[${j}]}" == "-b" ] || [ "${argsIterate[${j}]}" == "-n" ])) || \
                ([ "${argsIterate[${i}]}" == "-b" ] && ([ "${argsIterate[${j}]}" == "-z" ] || [ "${argsIterate[${j}]}" == "-n" ])) || \
                ([ "${argsIterate[${i}]}" == "-n" ] && ([ "${argsIterate[${j}]}" == "-z" ] || [ "${argsIterate[${j}]}" == "-b" ])) ; then 
            echo "Incompatible arguments ${argsIterate[${i}]} and ${argsIterate[${j}]}"
            exit -1; 

Thanks and sorry for my english

# 2  
Old 01-09-2014
Saving args to a variable like that is going to break down if any of your filenames have spaces or the like.

Just do a little more checking in your input loop:


die() {
        echo "$@" >&2
        exit 1

## Read input arguments
while [ $# -ge 1 ]; do 
    case "$1" in 
        -v | --verbose ) verbose=true;; 
        -z | --gzip )
                [ -z "$compression" ] || die "Conflicting option $1"
        -b | --bzip2 )
                [ -z "$compression" ] || die "Conflicting option $1"
        -n | --no-compress)
                [ -z "$compression" ] || die "Conflicting option $1"
        -h | --help ) showUsage; exit 0 ;; 
        *) die "Invalid option $1. Use -h or --help to show usage" ;; 

This User Gave Thanks to Corona688 For This Post:
# 3  
Old 01-10-2014
It's not what I expected, but it's a nice and simple solution. Did not know why it didn't occur to me... I was stubborn in use an "args" variable, that I didn't realize there was a much simpler solution Smilie

Thanks a lot.

# 4  
Old 01-10-2014
The solution of Corona will indeed work, but i think there is an even more "correct" solution to this: use the getopts keyword of your shell or the /usr/bin/getopts executable respectively.

getopts provides (basic) error handling and essentially does what you want to achieve, plus it understands the common UNIX-syntax: if you have "/some/command" and want to pass it two options, "x" and "y" you would write:

/some/command -xy

rather than

/some/command -x -y

Corona688s way of parsing the commandline would require the latter instead of the former. You might read the man page of getopts and ask again if you have any additional questions about its usage.

Here is a (very basic) example of how to use it: suppose you have 2 legal options, "-a" and "-b", of which one takes an additional argument:

#! /bin/ksh
typeset aflag=""
typeset bflag=""
typeset bval=""
typeset curropt=""
typeset -i OPTIND=0       # number of passed args

while getopts ab: curropt ; do
     case $curropt in


               printf "Usage: %s: [-a] [-b value] args\n" $0
               exit 2

if [ ! -z "$aflag" ] ; then
     printf "Option -a specified\n"

if [ ! -z "$bflag" ]; then
     printf 'Option -b "%s" specified\n' "$bval"

shift $(($OPTIND -1))           # clear cmdline
exit 0

I hope this helps.

This User Gave Thanks to bakunin For This Post:
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Validate input files and update

We have a job which we need to run on daily bases, before loading data in a table we need to validate whether the input file is received or not.Inputfile formatsrc_sps_d_Call_Center_Reporting_yyyymmdd_01.dat SPS-Service nameYYYY-yearMM-MonthDD-dayLike above we will get n number of files for... (1 Reply)
Discussion started by: katakamvivek
1 Replies

2. Shell Programming and Scripting

How to validate user's input..?

$Input_filename=$ARGV; if (!-d $Input_filename && ! -e $Input_filename) { print "USAGE: Please enter '$ABCD/def/dsed.txt' as an arguement \n"; exit; } 1. Input Is suppose to be something like "$ABCD/def/dsed.txt". if the input is wrong the script should throw an ERROR message.... (2 Replies)
Discussion started by: Rashid Khan
2 Replies

3. Shell Programming and Scripting

Epic - Validate input size

Is there an easy way to validate an input field size. Let us say a script is asking to enter 10 digits mobile number, how do I write a script to validate it is numeric and is 10 digits in length? I just need an easy way w/o using looks ...etc. Is there such a away ? Here is what I have so far... (6 Replies)
Discussion started by: mrn6430
6 Replies

4. Shell Programming and Scripting

Another validate input Question.

I'm writing a bash shell script to 'help' me post to susepaste (I can NEVER remember the time options). Here's the code: #!/bin/bash ########## # # Project : personal script. # Started : Wed Aug 03, 2011 # Author : Habitual # Description : susepaste c-li script with user... (5 Replies)
Discussion started by: Habitual
5 Replies

5. Shell Programming and Scripting

The scope of the shell/perl script is to read the input text file. Validate the expiry date of each

The scope of the shell/perl script is to read the input text file. Validate the expiry date of each certificate and send the mail to the user. The user takes action to add the new certificate to the storage file and user owns the responsibility to update the input text file with the new certificate... (5 Replies)
Discussion started by: casmo
5 Replies

6. Shell Programming and Scripting

How to validate input parameters?

Hi, I wonder how I can know if the input parameters to the script are numbers or text Thanks (11 Replies)
Discussion started by: Gengis-Kahn
11 Replies

7. Shell Programming and Scripting

Validate and sort input

Hi, This will most likely be a simple answer. Currently I have a situation where my script will be sent various options: -o1 -o2 -oe3@somthing.com Now, if I want to run a certain command based on the option I am sent, I am doing the following. for o in $(echo $options) do if ... (3 Replies)
Discussion started by: stuaz
3 Replies

8. Shell Programming and Scripting

validate input

the user inputs names that have to be inside square brackets I want to check if the user puts the brackets and if not ask him to re-enter the names (9 Replies)
Discussion started by: DDoS
9 Replies

9. Shell Programming and Scripting

Need to validate a date input format

Hi all, I have a shell script(K shell) which takes a date as input. i want the input to be in DD-MM-YYYY format. Can i enforce such a format of input string using just one line of code? OR do i need to parse the input date into different components and test them using Case statements... (2 Replies)
Discussion started by: rajugp1
2 Replies

10. Shell Programming and Scripting

How to validate input values

Hi How would i validate value of a variable whether it is number,date or string Thanks in advance Sas (5 Replies)
Discussion started by: SasDutta
5 Replies
Login or Register to Ask a Question